From owner-svn-src-all@FreeBSD.ORG  Sun Dec  1 23:07:38 2013
Return-Path: <owner-svn-src-all@FreeBSD.ORG>
Delivered-To: svn-src-all@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115])
 (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by hub.freebsd.org (Postfix) with ESMTPS id 0A8C9CE7;
 Sun,  1 Dec 2013 23:07:38 +0000 (UTC)
Received: from mx1.stack.nl (relay04.stack.nl [IPv6:2001:610:1108:5010::107])
 (using TLSv1 with cipher ADH-CAMELLIA256-SHA (256/256 bits))
 (No client certificate requested)
 by mx1.freebsd.org (Postfix) with ESMTPS id C0C431EFA;
 Sun,  1 Dec 2013 23:07:37 +0000 (UTC)
Received: from turtle.stack.nl (turtle.stack.nl [IPv6:2001:610:1108:5010::132])
 by mx1.stack.nl (Postfix) with ESMTP id 728A0B8059;
 Mon,  2 Dec 2013 00:07:36 +0100 (CET)
Received: by turtle.stack.nl (Postfix, from userid 1677)
 id 41127CB4E; Mon,  2 Dec 2013 00:07:36 +0100 (CET)
Date: Mon, 2 Dec 2013 00:07:35 +0100
From: Jilles Tjoelker <jilles@stack.nl>
To: Konstantin Belousov <kostikbel@gmail.com>
Subject: Re: svn commit: r258779 - in head/sys/dev: cesa drm drm2/i915
 drm2/radeon hatm
Message-ID: <20131201230735.GB24849@stack.nl>
References: <201311302216.rAUMGcPA037268@svn.freebsd.org>
 <20131201075944.GF59496@kib.kiev.ua>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20131201075944.GF59496@kib.kiev.ua>
User-Agent: Mutt/1.5.21 (2010-09-15)
Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org,
 src-committers@freebsd.org, Eitan Adler <eadler@FreeBSD.org>
X-BeenThere: svn-src-all@freebsd.org
X-Mailman-Version: 2.1.16
Precedence: list
List-Id: "SVN commit messages for the entire src tree \(except for &quot;
 user&quot; and &quot; projects&quot; \)" <svn-src-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/svn-src-all>,
 <mailto:svn-src-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-all/>
List-Post: <mailto:svn-src-all@freebsd.org>
List-Help: <mailto:svn-src-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-all>,
 <mailto:svn-src-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sun, 01 Dec 2013 23:07:38 -0000

On Sun, Dec 01, 2013 at 09:59:44AM +0200, Konstantin Belousov wrote:
> On Sat, Nov 30, 2013 at 10:16:38PM +0000, Eitan Adler wrote:
> > Author: eadler
> > Date: Sat Nov 30 22:16:37 2013
> > New Revision: 258779
> > URL: http://svnweb.freebsd.org/changeset/base/258779
> > 
> > Log:
> >   Similar to the (1 << 31) case it is not defined to do (2 << 30).
> > 
> > Modified:
> ...

> >   head/sys/dev/drm2/i915/i915_reg.h

> Revert the drm2/i915 changes from this and following commits now.
> You did not contacted obvious maintainer of the file.

> The changes are pointless and make the import of upstream changes
> harder; for i915_reg.h, much harder.

This is a valid concern. The change should be submitted to upstream; if
upstream does not want the change, it is better to avoid the issue by
adding -fno-strict-overflow for the offending files, matching upstream.

> Not to mention that the whole churn is not needed if the
> -fno-strict-overflow flag is used.

I think the undefined shifts should be fixed where possible and not in
contributed code.

-- 
Jilles Tjoelker