From owner-svn-src-all@freebsd.org Thu Jul 30 16:55:56 2020 Return-Path: Delivered-To: svn-src-all@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id E28203AA6CE; Thu, 30 Jul 2020 16:55:56 +0000 (UTC) (envelope-from st_esser@t-online.de) Received: from mailout10.t-online.de (mailout10.t-online.de [194.25.134.21]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "mailout00.t-online.de", Issuer "TeleSec ServerPass Class 2 CA" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4BHc492PJ7z4dKl; Thu, 30 Jul 2020 16:55:53 +0000 (UTC) (envelope-from st_esser@t-online.de) Received: from fwd21.aul.t-online.de (fwd21.aul.t-online.de [172.20.27.66]) by mailout10.t-online.de (Postfix) with SMTP id 708F541655DA; Thu, 30 Jul 2020 18:55:51 +0200 (CEST) Received: from Stefans-MacBook-Pro-449.fritz.box (JT9t1GZpYhOlPNszakVc8kXyhjq7se5ZLPOftP6B71a-HqXxRQwK3e-yOk0-fxqQd9@[93.200.63.47]) by fwd21.t-online.de with (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384 encrypted) esmtp id 1k1BqK-4D4Hpo0; Thu, 30 Jul 2020 18:55:44 +0200 Subject: Re: svn commit: r363091 - in head/contrib/bc: . include manuals src tests tests/bc To: Jessica Clarke , Ravi Pokala Cc: Baptiste Daroussin , =?UTF-8?Q?Stefan_E=c3=9fer?= , src-committers , svn-src-all@freebsd.org, svn-src-head@freebsd.org References: <202007110733.06B7XJrp033777@repo.freebsd.org> <20200730162009.rnjs6l5rjqsoiqpq@ivaldir.net> <20200730163154.a4d7672xsugkhmxq@ivaldir.net> <7257CDA6-0D66-42EB-9920-90DB90B9CA63@freebsd.org> From: =?UTF-8?Q?Stefan_E=c3=9fer?= Message-ID: <42f2dcf3-6eda-fb69-cc95-30a18e716407@t-online.de> Date: Thu, 30 Jul 2020 18:55:43 +0200 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <7257CDA6-0D66-42EB-9920-90DB90B9CA63@freebsd.org> Content-Type: text/plain; charset=utf-8 Content-Language: de-DE Content-Transfer-Encoding: 8bit X-ID: JT9t1GZpYhOlPNszakVc8kXyhjq7se5ZLPOftP6B71a-HqXxRQwK3e-yOk0-fxqQd9 X-TOI-EXPURGATEID: 150726::1596128144-0000D063-5DF8DEF2/0/0 CLEAN NORMAL X-TOI-MSGID: 1ce1b80d-64de-49f4-bc07-acdad585c175 X-Rspamd-Queue-Id: 4BHc492PJ7z4dKl X-Spamd-Bar: ++ Authentication-Results: mx1.freebsd.org; dkim=none; dmarc=none; spf=none (mx1.freebsd.org: domain of st_esser@t-online.de has no SPF policy when checking 194.25.134.21) smtp.mailfrom=st_esser@t-online.de X-Spamd-Result: default: False [2.43 / 15.00]; MID_RHS_MATCH_FROM(0.00)[]; ARC_NA(0.00)[]; RECEIVED_SPAMHAUS_PBL(0.00)[93.200.63.47:received]; FROM_HAS_DN(0.00)[]; TO_DN_SOME(0.00)[]; FREEMAIL_FROM(0.00)[t-online.de]; TO_MATCH_ENVRCPT_ALL(0.00)[]; MIME_GOOD(-0.10)[text/plain]; DMARC_NA(0.00)[t-online.de]; AUTH_NA(1.00)[]; NEURAL_SPAM_MEDIUM(0.77)[0.774]; RCVD_COUNT_THREE(0.00)[3]; NEURAL_HAM_SHORT(-0.16)[-0.157]; NEURAL_SPAM_LONG(0.91)[0.908]; RCPT_COUNT_SEVEN(0.00)[7]; RCVD_IN_DNSWL_NONE(0.00)[194.25.134.21:from]; R_SPF_NA(0.00)[no SPF record]; FROM_EQ_ENVFROM(0.00)[]; R_DKIM_NA(0.00)[]; MIME_TRACE(0.00)[0:+]; ASN(0.00)[asn:3320, ipnet:194.25.0.0/16, country:DE]; RCVD_TLS_LAST(0.00)[]; FREEMAIL_ENVFROM(0.00)[t-online.de]; RWL_MAILSPIKE_POSSIBLE(0.00)[194.25.134.21:from] X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.33 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 30 Jul 2020 16:55:56 -0000 Am 30.07.20 um 18:45 schrieb Jessica Clarke: > On 30 Jul 2020, at 17:40, Ravi Pokala wrote: >> >> -----Original Message----- >> From: on behalf of Jessica Clarke >> Date: 2020-07-30, Thursday at 09:35 >> To: Baptiste Daroussin >> Cc: Stefan Eßer , src-committers , , >> Subject: Re: svn commit: r363091 - in head/contrib/bc: . include manuals src tests tests/bc >> >> On 30 Jul 2020, at 17:31, Baptiste Daroussin wrote: >>> On Thu, Jul 30, 2020 at 05:28:19PM +0100, Jessica Clarke wrote: >>>> On 30 Jul 2020, at 17:20, Baptiste Daroussin wrote: >>>>> On Sat, Jul 11, 2020 at 07:33:19AM +0000, Stefan Eßer wrote: >>>>>> Author: se >>>>>> Date: Sat Jul 11 07:33:18 2020 >>>>>> New Revision: 363091 >>>>>> URL: https://svnweb.freebsd.org/changeset/base/363091 >>>>>> >>>>>> Log: >>>>>> Update to version 3.1.3 >>>>>> >>>>> Jumping on that commit, since the switch from our previous bc. >>>>> >>>>> The output of the interactive bc has changed, the previous version had a clean >>>>> UI, the new version "pollutes" the output with plenty of lines about the >>>>> copyright: >>>>> >>>>> ==== >>>>> Copyright (c) 2018-2020 Gavin D. Howard and contributors >>>>> Report bugs at: https://git.yzena.com/gavin/bc >>>>> >>>>> This is free software with ABSOLUTELY NO WARRANTY. >>>>> ==== >>>>> >>>>> Imagine if all programs where doing that, it would be painful, do you think >>>>> upstream can be convinced to remove those lines? >>>>> >>>>> I no the GNU version also has the same polluted output which was one of the >>>>> reason I was happy with out previous version of bc. >>>> >>>> By default both will print such a banner if and only if being called >>>> interactively. You can disable the banner explicitly with -q/--quiet >>>> for both GNU bc and this bc. I agree it's a bit noisy and would be >>>> nicer to not have that printed, but it's not without precedent for >>>> REPL-like things. >>> >>> Yes it is not without precedent for REPL-like things, still I dislike this and >>> would be happy to get bc interactive be as nice as the previous one we had :) >>> >>> If not I will deal with it and just yell internally each time I run it :D >> >> `alias bc='bc -q'` / `alias bc bc -q` and preserve your inner zen? :) >> >> Jess >> >> I was actually about to complain about the new `dc' not exiting after evaluating a '-e' expression, without an explicit 'q'. But then I noticed the "DC_EXPR_EXIT" envvar, which restores the desired behavior. That lead me to discover "DC_ENV_ARGS" and, correspondingly, "BC_ENV_ARGS"; that last one would be helpful here. > > That does feel like the wrong default; even GNU dc doesn't do that, and > the principle of least surprise would suggest exiting is the right > thing to do. It's also unlikely you want to evaluate something and then > use it interactively. Interesting observation - I've got to admit that I hardly ever use dc (despite being the owner of a collection of HP UPN calculators ;-) ). I'll forward this to the author of this bc/dc and I'm sure he will offer a patched version (unless there are strong reasons for the current behavior, e.g. compatibility with another dc ...) Regards, STefan