Date: Sat, 26 Oct 2024 14:01:32 +0000 From: bugzilla-noreply@freebsd.org To: ports-bugs@FreeBSD.org Subject: [Bug 281800] news/nzbget: Update to 24.3 Message-ID: <bug-281800-7788-g3Tj7UiGPR@https.bugs.freebsd.org/bugzilla/> In-Reply-To: <bug-281800-7788@https.bugs.freebsd.org/bugzilla/> References: <bug-281800-7788@https.bugs.freebsd.org/bugzilla/>
next in thread | previous in thread | raw e-mail | index | archive | help
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D281800 Robert Clausecker <fuz@FreeBSD.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fuz@FreeBSD.org --- Comment #2 from Robert Clausecker <fuz@FreeBSD.org> --- maintainer timeout Here is some feedback on your patch: - we ship zlib in base, no need to make depending on it optional - if you make a dependency optional, make sure we don't actually depend on= it when the option is turned off. This e.g. affects ncurses, on which this port unconditionally depends through USES=3Dncurses even when the option= is turned off. Fix this by adding ncurses to NCURSES_USES instead of USES. - instead of a hand-rolled do-test target, set USES=3D cmake:testing. Thi= s will add the right code to hook up cmake test suites. - I don't see you adding openssl or gnutls to the dependencies anywhere. = Make sure dependencies are added when the corresponding options are enabled. - TLS cannot be enabled as it's an option group. Please test the patch carefully with Poudriere before submitting it. Test = all port options to make sure the dependencies are configured correctly. Many = of these issues would have been caught quickly with proper testing. Please fix your patch and resubmit. --=20 You are receiving this mail because: You are the assignee for the bug.=
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?bug-281800-7788-g3Tj7UiGPR>