From owner-cvs-all@FreeBSD.ORG Fri Aug 4 08:17:38 2006 Return-Path: X-Original-To: cvs-all@FreeBSD.org Delivered-To: cvs-all@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 350E716A4DD; Fri, 4 Aug 2006 08:17:38 +0000 (UTC) (envelope-from stefan@fafoe.narf.at) Received: from viefep16-int.chello.at (viefep13-int.chello.at [213.46.255.16]) by mx1.FreeBSD.org (Postfix) with ESMTP id C2B3C43D76; Fri, 4 Aug 2006 08:17:30 +0000 (GMT) (envelope-from stefan@fafoe.narf.at) Received: from wombat.fafoe.narf.at ([213.47.85.26]) by viefep16-int.chello.at (InterMail vM.6.01.04.04 201-2131-118-104-20050224) with ESMTP id <20060804081728.KUAK14012.viefep16-int.chello.at@wombat.fafoe.narf.at>; Fri, 4 Aug 2006 10:17:28 +0200 Received: by wombat.fafoe.narf.at (Postfix, from userid 1001) id 46598BC7E; Fri, 4 Aug 2006 09:52:31 +0200 (CEST) Date: Fri, 4 Aug 2006 09:52:31 +0200 From: Stefan Farfeleder To: Yar Tikhiy Message-ID: <20060804075230.GD89735@wombat.fafoe.narf.at> References: <200608031905.k73J55D2061870@repoman.freebsd.org> <44D29FB6.9090209@freebsd.org> <20060804012514.GA63379@what-creek.com> <20060804071909.GS97316@comp.chem.msu.su> <20060804072323.GC89735@wombat.fafoe.narf.at> <20060804074657.GT97316@comp.chem.msu.su> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20060804074657.GT97316@comp.chem.msu.su> User-Agent: Mutt/1.5.12-2006-07-14 Cc: cvs-src@FreeBSD.org, Stefan Farfeleder , pdeuskar@FreeBSD.org, cvs-all@FreeBSD.org, src-committers@FreeBSD.org Subject: Re: cvs commit: src/sys/dev/em if_em.c if_em.h X-BeenThere: cvs-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the entire tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 04 Aug 2006 08:17:38 -0000 On Fri, Aug 04, 2006 at 11:46:57AM +0400, Yar Tikhiy wrote: > On Fri, Aug 04, 2006 at 09:23:23AM +0200, Stefan Farfeleder wrote: > > On Fri, Aug 04, 2006 at 11:19:09AM +0400, Yar Tikhiy wrote: > > > > > > As a general remark, it is a very good idea to keep large style(9) > > > sweeps separate from actual code changes even if they are tiny. > > > Changing style(9) shouldn't alter the binary code produced, and > > > this can be 100% verified using cmp(1), diff(1), cksum(1), or md5(1). > > > Of course, changing line numbers will affect debug info, but the > > > latter can be strip(1)'ed. In the case under discussion, I'd compare > > > if_em.o with its former version to make sure no code changed. > > > > It will produce different code if __LINE__ is used. > > Yeah, it's a thing to watch out for. As are __TIME__ and __DATE__. > Fortunately, they are not widely used in src/, AFAIK. Not directly, but through all kinds of assertion macros. Stefan