From owner-freebsd-ports@freebsd.org Wed Apr 6 17:11:24 2016 Return-Path: Delivered-To: freebsd-ports@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id D2824B06BCE for ; Wed, 6 Apr 2016 17:11:24 +0000 (UTC) (envelope-from jim@ohlste.in) Received: from mailman.ysv.freebsd.org (mailman.ysv.freebsd.org [IPv6:2001:1900:2254:206a::50:5]) by mx1.freebsd.org (Postfix) with ESMTP id AD7F610FB for ; Wed, 6 Apr 2016 17:11:24 +0000 (UTC) (envelope-from jim@ohlste.in) Received: by mailman.ysv.freebsd.org (Postfix) id ACD24B06BCD; Wed, 6 Apr 2016 17:11:24 +0000 (UTC) Delivered-To: ports@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id AC7A5B06BCC for ; Wed, 6 Apr 2016 17:11:24 +0000 (UTC) (envelope-from jim@ohlste.in) Received: from mail-qg0-x242.google.com (mail-qg0-x242.google.com [IPv6:2607:f8b0:400d:c04::242]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 781F610F8 for ; Wed, 6 Apr 2016 17:11:24 +0000 (UTC) (envelope-from jim@ohlste.in) Received: by mail-qg0-x242.google.com with SMTP id f105so4857820qge.3 for ; Wed, 06 Apr 2016 10:11:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ohlste-in.20150623.gappssmtp.com; s=20150623; h=subject:to:references:cc:from:message-id:date:user-agent :mime-version:in-reply-to:content-transfer-encoding; bh=+tuRGq6mG1785p6BMPKEGQMGyRM//XqoLSPP99r8vy4=; b=XCemfJJB0xm+kqDdhbYLO6f1qvxeLtTnvyTVCyemVkQh/4931igvpn6yJ1HoqJbz4C aQ9ugFTCTAAxk3/Ja4K+gN15S+uDcP71pby9vIRwtenJTiXjtLr4AHABzRE9oYQsevlA XBouvTzSdYXk/b8gzpXlgk3FbgIuKOB1ZCky80eDGXFL2rDWdyQsN8CQRj6WmaqrfwWN /lFQ1zEGWx1s/Ok7ZYxtpFchBYFSQcI5gNKvORqQKLRvyD3kJO/rU1/BUnw13YX0YqNq QHGMTTz7I8TKdpSLNV1N6zWmO4k4iC29n2AxuPpyjLS7jA/CQlkPj54+IWATF+plur3/ hJmw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:subject:to:references:cc:from:message-id:date :user-agent:mime-version:in-reply-to:content-transfer-encoding; bh=+tuRGq6mG1785p6BMPKEGQMGyRM//XqoLSPP99r8vy4=; b=DrhUd31Z03Sde+O5pqsCwQOzibsg4RqlXlS0MiNtlj6+uJJd8v0LPdGttTfxWQm43M UaDCueM/Huzg+pp54YGhHrYidjRAEoeAfmSeVxBdDjePjQioQYe3OIwgKTS6SYW/HltS cqlpgIfuH+qDu0inX4RvzQ72euPk2NwY/dEWemZqZpqpEaRcGqIfSbSs611cUdXNX+ZQ bFOkH2tZbry/SAqrgEIkITNfT9JIFmXaY9+5x/pD//jJwUZcBaaReGGvNCpv8cqWCjV/ RH1esdf+RXejaHXjbDcPrvLSYquAdcfPpQcPVO0rkT/AKJAwlVr8vE53xM8iIAqut8RU bN1w== X-Gm-Message-State: AD7BkJKkYIOXLtZ3ipBP8jAe5a1tqR29wmNIW70e5GgyakjZeBrrPbjygPhXdJmljIC34g== X-Received: by 10.140.32.203 with SMTP id h69mr26191200qgh.55.1459962683460; Wed, 06 Apr 2016 10:11:23 -0700 (PDT) Received: from ?IPv6:2001:470:7:71f::2? (ohlstein-2-pt.tunnel.tserv13.ash1.ipv6.he.net. [2001:470:7:71f::2]) by smtp.googlemail.com with ESMTPSA id o111sm733657qge.23.2016.04.06.10.11.22 (version=TLSv1/SSLv3 cipher=OTHER); Wed, 06 Apr 2016 10:11:22 -0700 (PDT) Subject: Re: Committer needed for PR 208029 To: Mathieu Arnold References: <498CA3F8-15EF-45BD-880C-241F83CBE3DD@waschbuesch.de> <20160405185159.GK35640@home.opsec.eu> <20160405200835.GM35640@home.opsec.eu> <57042958.5010701@sorbs.net> <20160406044431.GO35640@home.opsec.eu> <570517F1.5020305@ohlste.in> <261A33F8-4884-48B4-9152-4AD9CBC2CE3F@ohlste.in> <0DD478F6916BDE9C42FC4EAA@ogg.in.absolight.net> Cc: Kurt Jaeger , =?UTF-8?Q?Martin_Waschb=c3=bcsch?= , ports@freebsd.org, Michelle Sullivan From: Jim Ohlstein Message-ID: <57054338.2000702@ohlste.in> Date: Wed, 6 Apr 2016 13:11:20 -0400 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.11; rv:38.0) Gecko/20100101 Thunderbird/38.7.1 MIME-Version: 1.0 In-Reply-To: <0DD478F6916BDE9C42FC4EAA@ogg.in.absolight.net> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit X-BeenThere: freebsd-ports@freebsd.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: Porting software to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 06 Apr 2016 17:11:24 -0000 Hello, On 4/6/16 12:39 PM, Mathieu Arnold wrote: > +--On 6 avril 2016 12:00:47 -0400 Jim Ohlstein wrote: > | Hello, > | > |> On Apr 6, 2016, at 11:37 AM, Mathieu Arnold wrote: > |> > |> +--On 6 avril 2016 10:06:41 -0400 Jim Ohlstein wrote: > |> | Hello, > |> | > |> | On 4/6/16 12:44 AM, Kurt Jaeger wrote: > |> |> Hi! > |> |> > |> |>> Actually, I just noticed (when compiling the port), that the Makefile > |> |>> now says: > |> |>> > |> |>> WITH_OPENSSL_PORT=yes > |> |> > |> |> Yes, sorry, my fault. Fixed, and as suggested by mat: It is > |> |> now as IGNORE with a message explaining how to do it for 9.x. > |> |> > |> | > |> | This is much ado about nothing. The "WITH_OPENSSL_PORT" option is there > |> | for just this purpose and is used in many ports. > |> > |> No, the WITH_OPENSSL_PORT knob is a global one, and must not be used in > |> ports makefiles. The fact is, there are ports using it, true, it does > |> not mean it is the right thing to do. > |> > | > | Then there are many ports being committed incorrectly, as well as, no > | doubt, many *official* packages. > | > | I really have no dog in this fight. I use it globally and build all of my > | own packages with poudriere, but either it shouldn't be there at all, or > | it should be ok to use. Having it available as an option to porters and > | then saying it shouldn't be used seems a bit silly. > > Well, it is not available for the porters as it is a global directive, they > use it anyway. > > Anyway, like I said, working on it. > Maybe an edit to portlint is in order. That way they might know. As of now, portlint does not so much as emit a warning. I don't entirely disagree with the premise that all ports that require OpenSSL should be built against the version in ports. As I said, I do it and it also makes port maintenance simpler. However, as long as it is actually an option, as it is now, then it should be availed when desired. Further down the road (but not all that far) I foresee other, perhaps bigger problems if using this strategy. OpenSSL 1.1.0 is in beta and will be released within the next month or two. It is not completely backward compatible. At some point it will become the official ports version and/or two versions will need to be maintained in ports, 1.0.2 (LTS until 2019) and 1.1.x. This will create the problem of some/many ports not building against 1.1.x and some ports or port options _requiring_ 1.1.x. Assuming 1.1.x is the main OpenSSL in ports, there will be ports that would build properly against OpenSSL in base (but cannot be built that way if using the ports version is mandated), and do not compile against OpenSSL 1.1.x. Most can no doubt be patched, but waiting for upstream providers to do so may be problematic, and many porters lack the skills. -- Jim Ohlstein "Never argue with a fool, onlookers may not be able to tell the difference." - Mark Twain