From owner-freebsd-ports@FreeBSD.ORG Thu Aug 18 06:21:21 2011 Return-Path: Delivered-To: ports@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id CD51C106564A; Thu, 18 Aug 2011 06:21:21 +0000 (UTC) (envelope-from utisoft@gmail.com) Received: from mail-yw0-f54.google.com (mail-yw0-f54.google.com [209.85.213.54]) by mx1.freebsd.org (Postfix) with ESMTP id 7ACA48FC0C; Thu, 18 Aug 2011 06:21:21 +0000 (UTC) Received: by ywo32 with SMTP id 32so1468736ywo.13 for ; Wed, 17 Aug 2011 23:21:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc:content-type:content-transfer-encoding; bh=P2L+n1Lj8sxYT8M6JQzTTYPo9MUj/9lvBp6Gres5t50=; b=uVuS+QodRMANU+5xVL01ptD/DLsrVCJNJ95wbMBjLqxRg99xSoVoyoNKuI/wFiZ0S1 3FNMK9bS1IiwkUG8WlIj1Zb0bw6xSgYFyQwwoGZWCctZbK0Eimkls/f6r1+VR4dLEQn4 8vIDyRgYgssw+Ap1XiXebXBdxq5Qw9YWe1kZQ= Received: by 10.42.153.135 with SMTP id m7mr414530icw.348.1313648480194; Wed, 17 Aug 2011 23:21:20 -0700 (PDT) MIME-Version: 1.0 Received: by 10.231.182.77 with HTTP; Wed, 17 Aug 2011 23:20:50 -0700 (PDT) In-Reply-To: <4e4cc750.GqJImeHzdv6k8zld%perryh@pluto.rain.com> References: <201108171436.p7HEaNYQ071778@fire.js.berklix.net> <20110817161554.GA2496@lonesome.com> <4e4cc750.GqJImeHzdv6k8zld%perryh@pluto.rain.com> From: Chris Rees Date: Thu, 18 Aug 2011 07:20:50 +0100 Message-ID: To: perryh@pluto.rain.com Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Cc: ports@freebsd.org, linimon@lonesome.com, phk@phk.freebsd.dk, jhs@berklix.com, ben@freebsd.org Subject: Re: sysutils/diskcheckd needs fixing and a maintainer X-BeenThere: freebsd-ports@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Porting software to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 18 Aug 2011 06:21:22 -0000 On 18 August 2011 09:03, wrote: > Chris Rees wrote: > >> We don't want to provide broken software. > > Mark Linimon wrote: > >> ... it's obsolete, broken, junk ... > > Unless there is more to this than is reported in those two PRs, > I'd call it a considerable exaggeration to describe diskcheckd > as "broken". > > * http://www.freebsd.org/cgi/query-pr.cgi?pr=3Dports/115853 > =A0is shown as "closed", so presumably is no longer a problem. Wow, would it have been too difficult to actually READ the closing message from Jeremy? I suggest you look again -- I've pasted it here so you can see it. "The problem here is that the code does not do what the manpage says (or vice-versa). The 3rd column does not specify frequency of checking, but rather, over what duration of time to spread a single disk scan over. Thus, 7 days would mean "spread the entire disk check at X rate over the course of 7 days". There is still a bug in the code where large disks will cause problems resulting in updateproctitle() never getting called, and so on, but that's unrelated to this PR. I'm closing the PR because trying to fix all of this should really be ben@'s responsibility. (Sorry for sounding harsh.)" How does that indicate it's fixed? It's an 'abandoned' PR. > * http://www.freebsd.org/cgi/query-pr.cgi?pr=3Dports/143566 > =A0says "... diskcheckd runs fine when gmirror is not involved ..." > =A0and then goes on to describe a problem _when diskcheckd is run > =A0on a component of a gmirror_. > > How anyone got from "in some way incompatible with gmirror" to > "broken" escapes me. =A0One could as well claim that gmirror is > "broken" because it is incompatible with diskcheckd >:-> No. It's broken because there's no logical reason -- it will probably break with other things. > I'm currently running diskcheckd on an 8.1 gmirrored system with > config file > > =A0/dev/ad0 * * 8192 > > -- which should be using about 1/6 of that disk's bandwidth -- and > will see what happens when it reaches the end of the disk (sometime > tomorrow). =A0So far I have not seen any issues. Thank you for testing and investigating, this is what the port has needed, and two days of being deprecated has achieved more than 18 months of a PR being open. Chris --=20 Chris Rees =A0 =A0 =A0 =A0 =A0| FreeBSD Developer crees@FreeBSD.org =A0 | http://people.freebsd.org/~crees