From owner-freebsd-net@FreeBSD.ORG  Sat Dec 18 12:34:25 2010
Return-Path: <owner-freebsd-net@FreeBSD.ORG>
Delivered-To: freebsd-net@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id C1FCF1065672
	for <freebsd-net@freebsd.org>; Sat, 18 Dec 2010 12:34:25 +0000 (UTC)
	(envelope-from egrosbein@rdtc.ru)
Received: from eg.sd.rdtc.ru (eg.sd.rdtc.ru [62.231.161.221])
	by mx1.freebsd.org (Postfix) with ESMTP id 29A5B8FC0C
	for <freebsd-net@freebsd.org>; Sat, 18 Dec 2010 12:34:24 +0000 (UTC)
Received: from eg.sd.rdtc.ru (localhost [127.0.0.1])
	by eg.sd.rdtc.ru (8.14.4/8.14.4) with ESMTP id oBICYLEJ089821;
	Sat, 18 Dec 2010 18:34:21 +0600 (NOVT)
	(envelope-from egrosbein@rdtc.ru)
Message-ID: <4D0CAA48.7000901@rdtc.ru>
Date: Sat, 18 Dec 2010 18:34:16 +0600
From: Eugene Grosbein <egrosbein@rdtc.ru>
User-Agent: Mozilla/5.0 (X11; U; FreeBSD i386; ru-RU;
	rv:1.9.1.10) Gecko/20100712 Thunderbird/3.0.5
MIME-Version: 1.0
To: syrinx@freebsd.org
References: <86wrn7gxvd.fsf@kopusha.home.net>	<20101218110358.GY33073@deviant.kiev.zoral.com.ua>
	<AANLkTimBd74+0ycDN9p8A4Lt5myq8po7uXCZua1PGdTS@mail.gmail.com>
In-Reply-To: <AANLkTimBd74+0ycDN9p8A4Lt5myq8po7uXCZua1PGdTS@mail.gmail.com>
Content-Type: text/plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Cc: Kostik Belousov <kostikbel@gmail.com>, freebsd-net@freebsd.org,
	Mikolaj Golub <to.my.trociny@gmail.com>
Subject: Re: bsnmp/snmpmod.h: #include <sys/queue.h> is missed
X-BeenThere: freebsd-net@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: Networking and TCP/IP with FreeBSD <freebsd-net.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-net>,
	<mailto:freebsd-net-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-net>
List-Post: <mailto:freebsd-net@freebsd.org>
List-Help: <mailto:freebsd-net-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-net>,
	<mailto:freebsd-net-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sat, 18 Dec 2010 12:34:25 -0000

On 18.12.2010 18:01, Shteryana Shopova wrote:

>>> bsnmp/snmpmod.h uses SLIST but does not includes <sys/queue.h>. This breaks
>>> net-mgmt/bsnmp-ucd port (ports/153153).
>>>
>>> Could somebody look at the attached patch?
>>
>> <sys/types.h>, as well as <sys/param.h> should be included before
>> other headers.
>>
> 
> And the explicit includes of those files should be removed from the
> sources of the bsnmpd(1) modules, I think. I will put this in SVN
> along with a couple of other patches I have for bsnmp in my queue.
> Sorry for not being able to reply sooner after this problem was
> reported. Also, the bsnmptools port should be marked as obsolete as
> the tools are now in head.

I don't think that a port should be marked obsoled due to changes in head.
People tend to use releases or STABLE. For now, ports tree support RELENG_7
and RELENG_8, so we should keep POLA until bsnmptool backported to branches
and releases with bsnmptool are out.

Eugene Grosbein