From owner-svn-src-all@freebsd.org Fri Aug 25 17:08:12 2017 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id EA37BDDCDC9; Fri, 25 Aug 2017 17:08:12 +0000 (UTC) (envelope-from asomers@gmail.com) Received: from mail-wm0-x235.google.com (mail-wm0-x235.google.com [IPv6:2a00:1450:400c:c09::235]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 7EF80679AA; Fri, 25 Aug 2017 17:08:12 +0000 (UTC) (envelope-from asomers@gmail.com) Received: by mail-wm0-x235.google.com with SMTP id b79so2676809wmb.1; Fri, 25 Aug 2017 10:08:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:sender:in-reply-to:references:from:date:message-id :subject:to:cc; bh=g5c9jkD+5HY9UrIvhuT6iCSs/AKFc+He2zzlreCKDyg=; b=aqOeCEXq/MHhSv4LMeNCnx1Gs0jCzAUI+cuk7WBvj0PBCiasTN/NtKwwYNbJnh9kSK 4LJcZ+++JDr+Ox9vcjzHs8YtY5gIzlBb/isHRGlnd8YpaXOVEMbBiFFl9x5DLdh+9tj2 rA+yfTMsg03qQe2xnXuuyeVo97PpE5Ywv5IHVOjVTcG/GW+cmzAhA7M3OaY9j2fvwBdn /wmK5cnyIEx8cf46jp1KZ5lwA7O1pmjn1v8KRfAob5CR0bye1zcHE+mkwwiASODNqYQk Bt/LhYscUGdsI7m73VMg7ZuO9a1/zO2D8vMTRarWjkj4Zkj/zzbfWg3wg/81tCMG2TH6 pZ6w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:sender:in-reply-to:references:from :date:message-id:subject:to:cc; bh=g5c9jkD+5HY9UrIvhuT6iCSs/AKFc+He2zzlreCKDyg=; b=VSkjy4idFkM4oc58Uiu/dEv3GtKfEvVoFpfftwVkDzL/Rp/RjNDt7E9YEPy/ucQL8m TsVgUCz8TQTTP0xcNvB5XtCW7XwGpQK6l4+RcRvPKXZk+usLEuTgy7NiUGRsyY6pIWYE OdDN2xpVWMai3Dn3D5urFqkEXJOFZYmGOoHNoV3hv/SY1flLd8LDO+M1uQne3wkUTQXB RyH3ZUv6YYl4+EdLHKjYT91TSzezs9fshQWC636BDTp8djDk8jKjcHuBVzAOJ1gGbrVo VJ5RISTXd92Vkq7O6Xd7PKR2Iuw6w+hWpFSKx+zW6EcHGukwOOrLhIfwHOvsb4C9D3S9 /fYQ== X-Gm-Message-State: AHYfb5gGBgmVjkXITer22XlYfmI7pQXCrz9vKqYZB+qZ+b1Ikat8xRCZ DayCeIoy5ceILYUtEvRQ4AMy/KNlyQ== X-Received: by 10.28.5.136 with SMTP id 130mr76294wmf.4.1503680890633; Fri, 25 Aug 2017 10:08:10 -0700 (PDT) MIME-Version: 1.0 Sender: asomers@gmail.com Received: by 10.28.56.194 with HTTP; Fri, 25 Aug 2017 10:08:09 -0700 (PDT) In-Reply-To: References: <201708251531.v7PFVtoZ038242@repo.freebsd.org> From: Alan Somers Date: Fri, 25 Aug 2017 11:08:09 -0600 X-Google-Sender-Auth: _v9iRRzwXzMPNb7t-_-8x4TWcqc Message-ID: Subject: Re: svn commit: r322893 - head/bin/dd To: "Conrad E. Meyer" Cc: src-committers , "svn-src-all@freebsd.org" , "svn-src-head@freebsd.org" Content-Type: text/plain; charset="UTF-8" X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 25 Aug 2017 17:08:13 -0000 Nope. Do you mean negative offsets for the iseek argument? I didn't know you could do that. On Fri, Aug 25, 2017 at 10:59 AM, Conrad Meyer wrote: > Hi Alan, > > By any chance did you test this change with /dev/kmem and kernel > addresses ("negative" off_t values)? > > Thanks, > Conrad > > On Fri, Aug 25, 2017 at 8:31 AM, Alan Somers wrote: >> Author: asomers >> Date: Fri Aug 25 15:31:55 2017 >> New Revision: 322893 >> URL: https://svnweb.freebsd.org/changeset/base/322893 >> >> Log: >> dd(1): Incorrect casting of arguments >> >> dd(1) casts many of its numeric arguments from uintmax_t to intmax_t and >> back again to detect whether or not the original arguments were negative. >> This is not correct, and causes problems with boundary cases, for example >> when count is SSIZE_MAX-1. >> >> PR: 191263 >> Submitted by: will@worrbase.com >> Reviewed by: pi, asomers >> MFC after: 3 weeks