From owner-svn-src-all@freebsd.org Thu Feb 7 10:45:20 2019 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 014EF14D3CE5; Thu, 7 Feb 2019 10:45:20 +0000 (UTC) (envelope-from marius@alchemy.franken.de) Received: from alchemy.franken.de (alchemy.franken.de [194.94.249.214]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "alchemy.franken.de", Issuer "alchemy.franken.de" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id DAB9782BDC; Thu, 7 Feb 2019 10:45:17 +0000 (UTC) (envelope-from marius@alchemy.franken.de) Received: from alchemy.franken.de (localhost [127.0.0.1]) by alchemy.franken.de (8.15.2/8.15.2/ALCHEMY.FRANKEN.DE) with ESMTPS id x17AjFcL000403 (version=TLSv1.2 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NO); Thu, 7 Feb 2019 11:45:15 +0100 (CET) (envelope-from marius@alchemy.franken.de) Received: (from marius@localhost) by alchemy.franken.de (8.15.2/8.15.2/Submit) id x17AjF8m000402; Thu, 7 Feb 2019 11:45:15 +0100 (CET) (envelope-from marius) Date: Thu, 7 Feb 2019 11:45:15 +0100 From: Marius Strobl To: Vincenzo Maffione Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r343772 - head/sys/dev/netmap Message-ID: <20190207104515.GA92760@alchemy.franken.de> References: <201902051210.x15CAnPq052340@repo.freebsd.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <201902051210.x15CAnPq052340@repo.freebsd.org> User-Agent: Mutt/1.9.2 (2017-12-15) X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.6.2 (alchemy.franken.de [0.0.0.0]); Thu, 07 Feb 2019 11:45:15 +0100 (CET) X-Rspamd-Queue-Id: DAB9782BDC X-Spamd-Bar: --- Authentication-Results: mx1.freebsd.org X-Spamd-Result: default: False [-3.57 / 15.00]; ARC_NA(0.00)[]; NEURAL_HAM_MEDIUM(-1.00)[-0.997,0]; FROM_HAS_DN(0.00)[]; RCPT_COUNT_THREE(0.00)[4]; TO_MATCH_ENVRCPT_ALL(0.00)[]; NEURAL_HAM_LONG(-1.00)[-1.000,0]; MIME_GOOD(-0.10)[text/plain]; RCVD_TLS_LAST(0.00)[]; DMARC_NA(0.00)[freebsd.org]; TO_DN_SOME(0.00)[]; AUTH_NA(1.00)[]; RCVD_COUNT_THREE(0.00)[3]; IP_SCORE(-1.85)[ip: (-6.33), ipnet: 194.94.0.0/15(-2.86), asn: 680(-0.07), country: DE(-0.01)]; MX_GOOD(-0.01)[alchemy.franken.de,hub-r.franken.de,rachael.franken.de]; NEURAL_HAM_SHORT(-0.91)[-0.909,0]; R_SPF_NA(0.00)[]; FORGED_SENDER(0.30)[marius@freebsd.org,marius@alchemy.franken.de]; R_DKIM_NA(0.00)[]; MIME_TRACE(0.00)[0:+]; ASN(0.00)[asn:680, ipnet:194.94.0.0/15, country:DE]; FROM_NEQ_ENVFROM(0.00)[marius@freebsd.org,marius@alchemy.franken.de] X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 07 Feb 2019 10:45:20 -0000 On Tue, Feb 05, 2019 at 12:10:49PM +0000, Vincenzo Maffione wrote: > Author: vmaffione > Date: Tue Feb 5 12:10:48 2019 > New Revision: 343772 > URL: https://svnweb.freebsd.org/changeset/base/343772 > > Log: > netmap: refactor logging macros and pipes > > Changelist: > - Replace ND, D and RD macros with nm_prdis, nm_prinf, nm_prerr > and nm_prlim, to avoid possible naming conflicts. > - Add netmap_krings_mode_commit() helper function and use that > to reduce code duplication. > - Refactor pipes control code to export some functions that > can be reused by the veth driver (on Linux) and epair(4). > - Add check to reject API requests with version less than 11. > - Small code refactoring for the null adapter. Hello Vincenzo, this change causes interface attachment output to look somewhat deformed ("000.000395 [3717] netmap_attach_ext" debug info and an extra newline): em0: port 0xe000-0xe01f mem 0xf7d00000-0xf7d1ffff,0xf7d20000-0xf7d23fff irq 17 at device 0.0 on pci3 em0: Using 1024 TX descriptors and 1024 RX descriptors em0: Using 2 RX queues 2 TX queues em0: Using MSI-X interrupts with 3 vectors em0: Ethernet address: 60:a4:4c:24:0b:4c 000.000395 [3717] netmap_attach_ext em0: netmap queues/slots: TX 2/1024, RX 2/1024 pcib5: irq 19 at device 28.7 on pci0 Could we please get this part back to match the pre-r343772 output again? Marius