From owner-dev-commits-src-all@freebsd.org Tue Aug 10 16:13:08 2021 Return-Path: Delivered-To: dev-commits-src-all@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id CAD9766B1A5; Tue, 10 Aug 2021 16:13:08 +0000 (UTC) (envelope-from jhb@FreeBSD.org) Received: from smtp.freebsd.org (smtp.freebsd.org [96.47.72.83]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4GkdKJ5S12z4p00; Tue, 10 Aug 2021 16:13:08 +0000 (UTC) (envelope-from jhb@FreeBSD.org) Received: from John-Baldwins-MacBook-Pro.local (ralph.baldwin.cx [66.234.199.215]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client did not present a certificate) (Authenticated sender: jhb) by smtp.freebsd.org (Postfix) with ESMTPSA id 377102DCEF; Tue, 10 Aug 2021 16:13:08 +0000 (UTC) (envelope-from jhb@FreeBSD.org) Subject: Re: git: e7a13643b17c - main - build.7: Document LOCAL_MODULES and LOCAL_MODULES_DIR To: Mark Johnston , src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org References: <202108101543.17AFhDaI066139@gitrepo.freebsd.org> From: John Baldwin Message-ID: <01cadb96-b1b6-5726-25f3-4adcb060bde1@FreeBSD.org> Date: Tue, 10 Aug 2021 09:13:07 -0700 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.14; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 MIME-Version: 1.0 In-Reply-To: <202108101543.17AFhDaI066139@gitrepo.freebsd.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-BeenThere: dev-commits-src-all@freebsd.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Commit messages for all branches of the src repository List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 10 Aug 2021 16:13:08 -0000 On 8/10/21 8:43 AM, Mark Johnston wrote: > The branch main has been updated by markj: > > URL: https://cgit.FreeBSD.org/src/commit/?id=e7a13643b17c3ec7357b26324986587dab810da5 > > commit e7a13643b17c3ec7357b26324986587dab810da5 > Author: Mark Johnston > AuthorDate: 2021-08-10 15:42:35 +0000 > Commit: Mark Johnston > CommitDate: 2021-08-10 15:43:02 +0000 > > build.7: Document LOCAL_MODULES and LOCAL_MODULES_DIR > > Reviewed by: 0mp, imp > MFC after: 1 week > Sponsored by: The FreeBSD Foundation > Differential Revision: https://reviews.freebsd.org/D31461 > --- > share/man/man7/build.7 | 15 ++++++++++++++- > 1 file changed, 14 insertions(+), 1 deletion(-) > > diff --git a/share/man/man7/build.7 b/share/man/man7/build.7 > index 9d311a2f2f6c..c589fb7e0b9a 100644 > --- a/share/man/man7/build.7 > +++ b/share/man/man7/build.7 > @@ -24,7 +24,7 @@ > .\" > .\" $FreeBSD$ > .\" > -.Dd July 1, 2021 > +.Dd August 10, 2021 > .Dt BUILD 7 > .Os > .Sh NAME > @@ -601,6 +601,19 @@ process. > .Bd -literal -offset indent > make PORTS_MODULES=emulators/virtualbox-ose-kmod kernel > .Ed > +.It Va LOCAL_MODULES > +A list of external kernel modules that should be built and installed > +as part of the > +.Cm buildkernel > +and > +.Cm installkernel > +process. > +.It Va LOCAL_MODULES_DIR > +The directory in which to search for the kernel modules specified by > +.Va LOCAL_MODULES . > +Each kernel module should consist of a directory containing a makefile. > +Defaults to > +.Pa ${LOCALBASE}/sys/modules . Thanks for doing this. The only thing we might want to add is to note that LOCAL_MODULES is automatically set to all the subdirs in LOCAL_MODULES_DIR if it is not explicitly set. -- John Baldwin