From nobody Sun Feb 8 16:22:01 2026 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4f8ClM1RW8z6RQhY; Sun, 08 Feb 2026 16:22:07 +0000 (UTC) (envelope-from tuexen@FreeBSD.org) Received: from smtp.freebsd.org (smtp.freebsd.org [96.47.72.83]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "R12" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4f8ClL72d6z3fRg; Sun, 08 Feb 2026 16:22:06 +0000 (UTC) (envelope-from tuexen@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1770567727; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Q8VCN1I9lyQ/1kcUGYiCayQZyYt+TINc5TTrPPvTlp8=; b=KgAGI4elEeI1Gky04c/BVLDRVCO2jiP6NM1dDtLEwDIg6ScylOpCIsiHA7hl2f670fIOVi XZaL2GhyDIBT6vfwxK77Pqfbbrn6cHhG5PAuHyFO1towmy0n+LvR8QAdJimB1LL3bqA+e4 7Qef0RuZpkmzoisvOFOHZA7k6uU+CRM+hunHyW7yQf2NSuq4eNPOeQ2GW9Gs+l080yq6gm Eim4AQbq89zjsLosoccqlLv7LQa+j3FMR6/Yp/3s7VlthW/fBzhGQ2GEWfIC+BUVuC5bhX stj7SRnr5qH3yXUvGNRVKfNz0qW4l0Z6oBv0bgdMJw0CbOTHRAqsCJoIdLQqHg== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1770567727; a=rsa-sha256; cv=none; b=c/DD1sv3ZkIICFOsZJydsoK5UBP9P0uZ71nfQWAr9XFF3JySP1hljkXEAWRp3iBo5r/nkf zuJCygcH2b7SbAzMH6lgW1k99tlHpiHtNu4eRe1ecMT7TQx6aQQvoyptcAZb0Te9kW/RA1 LAG73ZUV4PAzu+HYtJ0N7EMS/MD4glujDNpZLj/Hxxz5BskvhTM4ViKfuiOQZwJB4ixBNz h/8JU9paN5ab/q1mb4KPpZv4Fafxyhy5IGwyExLi5FVsvVNmsDdy43/lR8oB17V186oL6P aD0wwuo2K5ApBrlx2GI7nRqIjg0HCi28bLPSGZhpXeS0vyk9yHRkVfwov5dxGw== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1770567727; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Q8VCN1I9lyQ/1kcUGYiCayQZyYt+TINc5TTrPPvTlp8=; b=T9JDtYOSNG79P0pMvcEiGpDpFTwFso7uXckdpTeDqAq8jPedg8SQ7JzlGOwUSdE+WCOivv sEmA6cFFo6ZVrUYe3ovhskQNI1EiVbWbBK2AiiEYLa8zcrX0m4TH0YYBHiv3JYJXDQIlPl q5n70JQ0fRvHIKlsqBvDM0q/wQcLFaA1MMjtwHdfAYLQSy2EdLoWmZ+AMkvknLsHrAuwx7 9o1azsmQfVavYPQKo2n7D8oUELHsxTh8xIsTfJ5OjTqPNIQjQw3gi4zy0qGISOdYWw8ksm 8bypRL2HZU+myKdF+XGQFMCnXX0lsCgBy2jKTWZXrEc+xDw7XLU+0wJk/ST+3Q== Received: from smtpclient.apple (unknown [IPv6:2a02:8109:1101:be00:614d:4071:7145:c2c]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) (Authenticated sender: tuexen) by smtp.freebsd.org (Postfix) with ESMTPSA id 4f8ClK6gKFzZ0C; Sun, 08 Feb 2026 16:22:05 +0000 (UTC) (envelope-from tuexen@FreeBSD.org) Content-Type: text/plain; charset=utf-8 List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-main@freebsd.org Sender: owner-dev-commits-src-main@FreeBSD.org Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3864.300.41.1.7\)) Subject: Re: git: 7b6e84c9ac56 - main - ure: improve checksum offloading From: Michael Tuexen In-Reply-To: <98155039-1cb4-4420-a66e-1b6bd94464c8@freebsd.org> Date: Sun, 8 Feb 2026 17:22:01 +0100 Cc: "src-committers@freebsd.org" , "dev-commits-src-all@freebsd.org" , "dev-commits-src-main@freebsd.org" Content-Transfer-Encoding: quoted-printable Message-Id: <2C2AC503-918D-4ACA-8E16-890901C919E2@FreeBSD.org> References: <697ddd34.3ef70.43e05480@gitrepo.freebsd.org> <98155039-1cb4-4420-a66e-1b6bd94464c8@freebsd.org> To: Charlie Li X-Mailer: Apple Mail (2.3864.300.41.1.7) > On 7. Feb 2026, at 16:34, Charlie Li wrote: >=20 > Michael Tuexen wrote: >> The branch main has been updated by tuexen: >> URL: = https://cgit.FreeBSD.org/src/commit/?id=3D7b6e84c9ac5668134ab2d075019ef0b8= 27d90c84 >> commit 7b6e84c9ac5668134ab2d075019ef0b827d90c84 >> Author: Michael Tuexen >> AuthorDate: 2026-01-31 10:42:10 +0000 >> Commit: Michael Tuexen >> CommitDate: 2026-01-31 10:42:10 +0000 >> ure: improve checksum offloading >> This patch fixes three issues: >> (1) Initially, set the hwassist flags correctly when enabling >> transmit checksum offload for TCP/IPv6 and UDP/IPv6. >> (2) Keep the hwassist flags in sync with the capabilities when >> changing txcsum. >> (3) Keep the hwasssit flags in sync with the capabilities when >> changing txcsum6. >> Without this patch, transmit checksum offloading for TCP/IPv6 and >> UDP/IPv6 is never used and transmit checksum offloading for IPv4, >> TCP/IPv4 and UDP/IPv4 is always used, even if disabled via >> ifconfig ue? -txcsum. >> Reviewed by: Timo V=C3=B6lker >> MFC after: 3 days >> Differential Revision: https://reviews.freebsd.org/D54974 >> --- >> sys/dev/usb/net/if_ure.c | 3 +++ >> 1 file changed, 3 insertions(+) >> diff --git a/sys/dev/usb/net/if_ure.c b/sys/dev/usb/net/if_ure.c >> index c3f7b622d687..3dea88eb10f1 100644 >> --- a/sys/dev/usb/net/if_ure.c >> +++ b/sys/dev/usb/net/if_ure.c >> @@ -1015,6 +1015,7 @@ ure_attach_post_sub(struct usb_ether *ue) >> if_sethwassist(ifp, CSUM_IP|CSUM_IP_UDP|CSUM_IP_TCP); >> #ifdef INET6 >> if_setcapabilitiesbit(ifp, IFCAP_HWCSUM_IPV6, 0); >> + if_sethwassistbits(ifp, CSUM_IP6_UDP|CSUM_IP6_TCP, 0); >> #endif >> if_setcapenable(ifp, if_getcapabilities(ifp)); >> @@ -1463,6 +1464,7 @@ ure_ioctl(if_t ifp, u_long cmd, caddr_t data) >> if ((mask & IFCAP_TXCSUM) !=3D 0 && >> (if_getcapabilities(ifp) & IFCAP_TXCSUM) !=3D 0) { >> if_togglecapenable(ifp, IFCAP_TXCSUM); >> + if_togglehwassist(ifp, CSUM_IP|CSUM_IP_UDP|CSUM_IP_TCP); >> } >> if ((mask & IFCAP_RXCSUM) !=3D 0 && >> (if_getcapabilities(ifp) & IFCAP_RXCSUM) !=3D 0) { >> @@ -1471,6 +1473,7 @@ ure_ioctl(if_t ifp, u_long cmd, caddr_t data) >> if ((mask & IFCAP_TXCSUM_IPV6) !=3D 0 && >> (if_getcapabilities(ifp) & IFCAP_TXCSUM_IPV6) !=3D 0) { >> if_togglecapenable(ifp, IFCAP_TXCSUM_IPV6); >> + if_togglehwassist(ifp, CSUM_IP6_UDP|CSUM_IP6_TCP); >> } >> if ((mask & IFCAP_RXCSUM_IPV6) !=3D 0 && >> (if_getcapabilities(ifp) & IFCAP_RXCSUM_IPV6) !=3D 0) { > It seems that with this commit, all network traffic and then some, = excluding ICMP{,v6}, time out. Even `route(8) get default` takes forever = to query. OK, my patch actually enabled transmit checksum offloading. This exposed = a bug in the code performing the checksum offload. Here is a fix: https://reviews.freebsd.org/D55187 Please test are report back. When initially testing my fix, I made a mistake actually only testing = IPv4. Thanks for reporting the issue! Best regards Michael >=20 > --=20 > Charlie Li > ...nope, still don't have an exit line. >=20