From owner-cvs-all Thu Oct 17 18:42:57 2002 Delivered-To: cvs-all@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id AF61D37B401; Thu, 17 Oct 2002 18:42:55 -0700 (PDT) Received: from wantadilla.lemis.com (wantadilla.lemis.com [192.109.197.80]) by mx1.FreeBSD.org (Postfix) with ESMTP id 58F8343E3B; Thu, 17 Oct 2002 18:42:54 -0700 (PDT) (envelope-from grog@lemis.com) Received: by wantadilla.lemis.com (Postfix, from userid 1004) id E387B8148D; Fri, 18 Oct 2002 11:12:51 +0930 (CST) Date: Fri, 18 Oct 2002 11:12:51 +0930 From: Greg 'groggy' Lehey To: Bruce Evans Cc: Mitsuru IWASAKI , cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/i386/isa clock.c Message-ID: <20021018014251.GB13428@wantadilla.lemis.com> References: <200210171355.g9HDtjBt054703@repoman.freebsd.org> <20021018050254.U12092-100000@gamplex.bde.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20021018050254.U12092-100000@gamplex.bde.org> User-Agent: Mutt/1.4i Organization: The FreeBSD Project Phone: +61-8-8388-8286 Fax: +61-8-8388-8725 Mobile: +61-418-838-708 WWW-Home-Page: http://www.FreeBSD.org/ X-PGP-Fingerprint: 9A1B 8202 BCCE B846 F92F 09AC 22E6 F290 507A 4223 Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG On Friday, 18 October 2002 at 5:06:24 +1000, Bruce Evans wrote: > On Thu, 17 Oct 2002, Mitsuru IWASAKI wrote: > >> iwasaki 2002/10/17 06:55:44 PDT >> >> Modified files: >> sys/i386/isa clock.c >> Log: >> 1. Fix a comment. Locking _is_ needed (but not done). >> 2. Update a comment. We now restore much more than RTC updates and >> interrupts. >> 3. Order change. Stop interrupts by writing to RTC_STATUSB, >> ... >> 4. Don't stop the clock (RTCB_HALT). We only program some control bits >> and don't want to stop the clock. >> 5. (Not really related.) Add caveats to the comment about timer_restore(). >> The update is non-atomic since locking is not done. >> >> On locking: >> 6. rtcin() and writertc() are locked() adequately by splhigh() in RELENG_4, >> but this locking is null in -current. >> 7. Doing things in the correct order in (3) combined with (6) is probably >> enough locking for rtcrestore() in RELENG_4. In -current, the >> writertc()'s race with rtcintr() unless the BIOS disables RTC interrupts. >> >> Submitted by: bde (including commit message) >> MFC after: 1 week > > Thanks. > > The commit message is a bit too verbose. Please summarize it and adjust > the comments for the MFC (most of the locking problems are only in > -current). And here's me thinking what a good example this was of a good commit message. Greg -- See complete headers for address and phone numbers To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message