From owner-cvs-src@FreeBSD.ORG Mon Sep 18 22:50:17 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 62DB716A403; Mon, 18 Sep 2006 22:50:17 +0000 (UTC) (envelope-from ru@rambler-co.ru) Received: from relay0.rambler.ru (relay0.rambler.ru [81.19.66.187]) by mx1.FreeBSD.org (Postfix) with ESMTP id A849C43D45; Mon, 18 Sep 2006 22:50:16 +0000 (GMT) (envelope-from ru@rambler-co.ru) Received: from relay0.rambler.ru (localhost [127.0.0.1]) by relay0.rambler.ru (Postfix) with ESMTP id AD1495E11; Tue, 19 Sep 2006 02:50:15 +0400 (MSD) Received: from edoofus.park.rambler.ru (unknown [81.19.65.108]) by relay0.rambler.ru (Postfix) with ESMTP id 890FB5C60; Tue, 19 Sep 2006 02:50:15 +0400 (MSD) Received: (from ru@localhost) by edoofus.park.rambler.ru (8.13.8/8.13.8) id k8IMoFxq020853; Tue, 19 Sep 2006 02:50:15 +0400 (MSD) (envelope-from ru) Date: Tue, 19 Sep 2006 02:50:15 +0400 From: Ruslan Ermilov To: "Christian S.J. Peron" Message-ID: <20060918225015.GC20647@rambler-co.ru> References: <200609182218.k8IMIMUT059300@repoman.freebsd.org> <450F1EC1.4060106@FreeBSD.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="PuGuTyElPB9bOcsM" Content-Disposition: inline In-Reply-To: <450F1EC1.4060106@FreeBSD.org> User-Agent: Mutt/1.5.13 (2006-08-11) X-Virus-Scanned: No virus found Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, cvs-all@FreeBSD.org, Jung-uk Kim Subject: Re: cvs commit: src/sys/dev/bge if_bge.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 18 Sep 2006 22:50:17 -0000 --PuGuTyElPB9bOcsM Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Sep 18, 2006 at 05:33:37PM -0500, Christian S.J. Peron wrote: > Jung-uk Kim wrote: > >jkim 2006-09-18 22:18:22 UTC > > > > FreeBSD src repository > > > > Modified files: > > sys/dev/bge if_bge.c=20 > > Log: > > Do not strip VLAN tag in promiscuous mode. > > =20 > > Revision Changes Path > > 1.148 +28 -15 src/sys/dev/bge/if_bge.c > > > > > > =20 > I don't think this is right. An interface does not have to be in=20 > promiscuous mode in order to have BPF peers attached to it. If this is=20 > being done to ensure that vlan info is preserved for things like=20 > tcpdump, the correct fix is to use bpf_peers_present() instead. >=20 > This issue has been discussed between myself, jhb, and andre for a=20 > couple of days now. The correct fix is to teach bpf to look at the mbuf= =20 > and re-construct and insert the vlan tags before passing it through=20 > bpf_filter (and on to any peers), assuming the hardware is handling=20 > stripping and inserting vlan tags. I have agreed to work on this, time=20 > permitting. >=20 I have a patch that does this, but it's far away from me on a powered off computer. Cheers, --=20 Ruslan Ermilov ru@FreeBSD.org FreeBSD committer --PuGuTyElPB9bOcsM Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.5 (FreeBSD) iD8DBQFFDyKnqRfpzJluFF4RArdsAJ4r0+EiaQwbaWdcpCGUxhJPmOhj9wCePeBu bcZojLkfsg6Fowo2k/o9v+Q= =APpH -----END PGP SIGNATURE----- --PuGuTyElPB9bOcsM--