From nobody Mon Aug 3 14:30:43 2026 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4hDJxc2sq0z6nV3y for ; Mon, 03 Aug 2026 14:30:44 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "YR1" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 4hDJxc1FVNz3stT for ; Mon, 03 Aug 2026 14:30:44 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1785767444; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=29aqGHizv5hMP+It6XgXb70oXRsSoWGCGOTbDOVwKf4=; b=MKQCU8JFJzDApaa+spLd8vEwA7/T/mNVebzP9cXroYr0cL8mC1Wu5cA13ejBirK9d5okK1 vYnieYzTyguQgWMl05A3uwxEauD4+2SkDzc17uzYqGBo54StLKmO4h8XljWuacoQlNbuHI 3wiSw1R6PsLGjpARqWC4va/PYS45pW3VjeBbeq1erO36KHHePiGi1WyKa9jS+8gmKtfaWq j1oZTtCOu4WJleqhIc+bc9lmzExRx/sCU33pC29pFRou0KCbov/LGqPF7bwCpt00rHF9Q0 +4KIXtPGwg7EoD+T3VR3VbgUJ8lUflz62YQv86OtYyPgATBLHro+uvp20K7YGA== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1785767444; a=rsa-sha256; cv=none; b=K88sOsV7exWJ/pW69V1TLYJZn8tgWN0eAU3/6Sme57radmvRbXlLrTHibGGs7LdkjDuGMo +Q4kVwbLuSarG3U4zPLRoHqGyk1yIwq/8gbYhqZW7lw4mvgwxQZCAWBRh5tW4iELuoQo5g LtgMFVZJ50qaU4YmQhJgQ0/eJ0gntG3fjA3r2WyQBM8FafXJXYhSPw1CicL/vwjHPr+e92 NqamSgFUVcD0QiexZfErV9mgE/LUL6OPm2DVpDk1am9m3X4+z0c1U3CXRVjHVNUYn6WYO7 kIKKIRxMA69eWnTkfOnnbMqraN6ZP27HwmKTgyRXxFau28L53a3Cl2piPSRwdQ== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1785767444; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=29aqGHizv5hMP+It6XgXb70oXRsSoWGCGOTbDOVwKf4=; b=T1Gnp1QQfBFIcU932vJVDob0KZGhzsC4t4vvrDlQnwpPxF2MhdHKy4s7Xf+BWzPYFzst4V W2l3NM4cjdr3cced/zss5zAitHi02KhZd+g1kEDZo6qDUyCME/TO3Vw0/X1vAHsOZSdrCY Pzd2ZvYfimJKvdOZkbDX8RIytHzdsgHRkjftlP4UCcngr3ovb3yQUIge6Ivmf5xkCjSfPb P7D9YXNjFC9ibPtokG1oFadNgYNwZdXWszziDTdxptGJg+ypcwblot8drwSuO/Z4wHRGyd lWVGFTxl1gymGGFFQ6SNETPPCvU9FUpCpBi7HoG8eagE586dUw+yfcqyxwFbsA== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) by mxrelay.nyi.freebsd.org (Postfix) with ESMTP id 4hDJxc0187z149L for ; Mon, 03 Aug 2026 14:30:44 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from git (uid 1279) (envelope-from git@FreeBSD.org) id 37031 by gitrepo.freebsd.org (DragonFly Mail Agent v0.13+ on gitrepo.freebsd.org); Mon, 03 Aug 2026 14:30:43 +0000 To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Lexi Winter Subject: git: 78f842dda35b - main - sort: Const correctness for C23 List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-main@freebsd.org Sender: owner-dev-commits-src-main@FreeBSD.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: ivy X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: 78f842dda35b7280e8682f90506ff05b591c6b3a Auto-Submitted: auto-generated Date: Mon, 03 Aug 2026 14:30:43 +0000 Message-Id: <6a70a613.37031.76e4a9da@gitrepo.freebsd.org> The branch main has been updated by ivy: URL: https://cgit.FreeBSD.org/src/commit/?id=78f842dda35b7280e8682f90506ff05b591c6b3a commit 78f842dda35b7280e8682f90506ff05b591c6b3a Author: Lexi Winter AuthorDate: 2026-08-03 14:06:18 +0000 Commit: Lexi Winter CommitDate: 2026-08-03 14:06:18 +0000 sort: Const correctness for C23 On some platforms, e.g. Linux Clang 22.1.8 / glibc 2.43, strchr() now implements the C23 behaviour where passing a const pointer to strchr() also returns a const pointer. This breaks sort during the bootstrap build, since it assumes the return value is always a mutable pointer. As the returned pointer is never used to modify the value, fix this by making the temporary variable const. MFC after: 1 week Reviewed by: markj Sponsored by: The FreeBSD Foundation Differential Revision: https://reviews.freebsd.org/D58491 --- usr.bin/sort/sort.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/usr.bin/sort/sort.c b/usr.bin/sort/sort.c index 6e4023c43063..422884573ae9 100644 --- a/usr.bin/sort/sort.c +++ b/usr.bin/sort/sort.c @@ -735,7 +735,7 @@ parse_k(const char *s, struct key_specs *ks) { false, false, false, false, false, false }; if (s && *s) { - char *sptr; + const char *sptr; sptr = strchr(s, ','); if (sptr) {