From nobody Sat May 10 01:37:47 2025 X-Original-To: net@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4ZvT5X1yLzz5vg3C for ; Sat, 10 May 2025 01:37:52 +0000 (UTC) (envelope-from bz@FreeBSD.org) Received: from smtp.freebsd.org (smtp.freebsd.org [96.47.72.83]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "R11" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4ZvT5X1KMCz3cDD for ; Sat, 10 May 2025 01:37:52 +0000 (UTC) (envelope-from bz@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1746841072; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type; bh=SLoDu/Zg/ngnE52J7ZVXmg7GCKyIZwMr6wAGGtnk3Mk=; b=KHOQirMLqpjI5oCl4Wb6HpySUvWMBNyKcees1FiA8SUIS7r1JssvyvvrNgzpeW1/VnEbCk kbKupbSqbkT9iqDFhdVJz7z7PghUn1ROsnAWe2vZAFkwKNOrlc/pLXFWCzK0f2C3oFR7zf 1DXksSaDje3/RxKyM1EtZHRP4QEcM0ENvXKDcPtPxKiVwfq4RiORiWIOek1OkY3v7zmXbg J/MwItkgld182cu5CpaB9URu2OuWaDeF2uZ66h5wPViK0td3m5NCCq31azQ630RkCAhz9W P4pbfbn6AfrdMTvkE2F1V65KXiROmlEovxc5uqedsPunHi97L5L+XfZs9ZVytw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1746841072; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type; bh=SLoDu/Zg/ngnE52J7ZVXmg7GCKyIZwMr6wAGGtnk3Mk=; b=vOMI++TsU/Va98Z07+3+4keCgtgpVxxza2lD1lqWkAbq7QWkaAzPfAKcuHANpA+iA1U6/A thWVN0o8u6FWKgvFRAz5e1y4znsPb5Y7NxSDmNxs9AKbeaodwkdOCfX8cn0nW2uJ3GEHMm evfkVSnbF18NKwUHhJ/JTS/ed5lSlNK2xByT4S/UQM9rCVMOknN0XVWKYU+i96kZlgeOf2 /MVH3laqH050D8hf5IazW3p6bsvIlHIquK3EoFe3IWgrSn3DrNT4rD+MgreyIr52sz6OZh jRiGEkng9W/UmxPQQkdeNu7EEAh7tIEyHHj1aACy0BcQpBYqsZMXO0HRMm1N1w== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1746841072; a=rsa-sha256; cv=none; b=WvGwJb6E1aAolfJwveycaFzN6P1vdKv9RmjWdVMGgXFQLYJDcBRvgf+GzNrruAieNsS/bO tIV+8hLMelIefzWzYH7cqzcR5jIQkq3zthsG3T7JA3H6k4GzQo4IueKBjPkjeT0BIiCUY2 zgSgFCDSAZP/0UOiCjbJcfbz1kWmGZK0oDRBnxN7sqFA9BwylXNj9MWDPcMlRLzl7K7yI1 FTf7+Hg2LQgr/GQ0vmHE7zHufdi2Owm9Ac7Htkk8+VajQrNXTS6ZadWedDbEH+cEiaxu+U jXpN+EpmOIdctz1Bt3kELiPMvVD0BlDEzqZBYfIQ+kVsNnujtv33NsIhUASRMg== ARC-Authentication-Results: i=1; mx1.freebsd.org; none Received: from mx-01.divo.sbone.de (mx-01.divo.sbone.de [IPv6:2003:a:140a:2200:6:594:fffe:19]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature ECDSA (prime256v1) client-digest SHA256) (Client CN "mx-01.divo.sbone.de", Issuer "E5" (verified OK)) (Authenticated sender: bz/mail) by smtp.freebsd.org (Postfix) with ESMTPSA id 4ZvT5W6vnvzRZ3 for ; Sat, 10 May 2025 01:37:51 +0000 (UTC) (envelope-from bz@FreeBSD.org) Received: from mail.sbone.de (mail.sbone.de [IPv6:fde9:577b:c1a9:4902:0:7404:2:1025]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by mx-01.divo.sbone.de (Postfix) with ESMTPS id 5452AA64805 for ; Sat, 10 May 2025 01:37:48 +0000 (UTC) Received: from content-filter.t4-02.sbone.de (content-filter.t4-02.sbone.de [IPv6:fde9:577b:c1a9:4902:0:7404:2:2742]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mail.sbone.de (Postfix) with ESMTPS id EF72D2D029E0 for ; Sat, 10 May 2025 01:37:49 +0000 (UTC) X-Virus-Scanned: amavisd-new at sbone.de Received: from mail.sbone.de ([IPv6:fde9:577b:c1a9:4902:0:7404:2:1025]) by content-filter.t4-02.sbone.de (content-filter.t4-02.sbone.de [IPv6:fde9:577b:c1a9:4902:0:7404:2:2742]) (amavisd-new, port 10024) with ESMTP id DAaUylYGtsEW for ; Sat, 10 May 2025 01:37:48 +0000 (UTC) Received: from strong-rtwn0.sbone.de (strong-rtwn0.sbone.de [IPv6:fde9:577b:c1a9:4902:3e64:cfff:fe55:bc80]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mail.sbone.de (Postfix) with ESMTPSA id E7A352D029D8 for ; Sat, 10 May 2025 01:37:48 +0000 (UTC) Date: Sat, 10 May 2025 01:37:47 +0000 (UTC) From: "Bjoern A. Zeeb" To: net@freebsd.org Subject: Can we remove IFCAP_RXCSUM_IPV6? Message-ID: <0np2s799-446r-n801-2os5-oqon276851r2@SerrOFQ.bet> X-OpenPGP-Key-Id: 0x14003F198FEFA3E77207EE8D2B58B8F83CCF1842 List-Id: Networking and TCP/IP with FreeBSD List-Archive: https://lists.freebsd.org/archives/freebsd-net List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-net@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; format=flowed; charset=US-ASCII Hi, in 356ab07e2dba0 IFCAP_RXCSUM_IPV6 was introduced along with duplicating all the other bits to not break hardware offload for IPv4. Almost 13 years later I wonder if for any interface (apart from the loopback interface maybe) IFCAP_RXCSUM_IPV6 ever made any difference? A driver would know what RX offload features it can do and one flag should fit all of them. People might say or have said 'but if it is broken for IPv6' we can no longer disable it. Well, yes we can, in the driver as it doesn't make sense for an admin of some hardware having to toggle off a broken feature manually. So I wonder if (temporary, say for 15) we can define IFCAP_RXCSUM_IPV6 to IFCAP_RXCSUM as well, get the bit back as "reserved" during 15 and then be done with it again? I haven't done the full due diligens but a quick grep resulted in a lot of "same code". What am I missing (apart from the painful to do patch)? /bz -- Bjoern A. Zeeb r15:7