From owner-freebsd-current@FreeBSD.ORG Wed Aug 25 18:30:03 2004 Return-Path: Delivered-To: freebsd-current@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 9983016A4CE; Wed, 25 Aug 2004 18:30:03 +0000 (GMT) Received: from TRANG.nuxi.com (trang.nuxi.com [66.93.134.19]) by mx1.FreeBSD.org (Postfix) with ESMTP id 61D0C43D55; Wed, 25 Aug 2004 18:30:03 +0000 (GMT) (envelope-from obrien@NUXI.com) Received: from dragon.nuxi.com (obrien@localhost [127.0.0.1]) by TRANG.nuxi.com (8.13.1/8.12.11) with ESMTP id i7PIU2Kb000522; Wed, 25 Aug 2004 11:30:03 -0700 (PDT) (envelope-from obrien@dragon.nuxi.com) Received: (from obrien@localhost) by dragon.nuxi.com (8.13.1/8.13.1/Submit) id i7PIU2MB000485; Wed, 25 Aug 2004 11:30:02 -0700 (PDT) (envelope-from obrien) Date: Wed, 25 Aug 2004 11:30:02 -0700 From: "David O'Brien" To: Ruslan Ermilov Message-ID: <20040825183002.GK53710@dragon.nuxi.com> Mail-Followup-To: David O'Brien , Ruslan Ermilov , current@FreeBSD.org References: <1093402508.488.8.camel@home> <20040825134842.M553@beagle.kn.op.dlr.de> <20040825134722.GD5872@ip.net.ua> <20040825173707.GH53710@dragon.nuxi.com> <20040825174908.GA97530@ip.net.ua> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20040825174908.GA97530@ip.net.ua> User-Agent: Mutt/1.4.1i X-Operating-System: FreeBSD 6.0-CURRENT Organization: The NUXI BSD Group X-Pgp-Rsa-Fingerprint: B7 4D 3E E9 11 39 5F A3 90 76 5D 69 58 D9 98 7A X-Pgp-Rsa-Keyid: 1024/34F9F9D5 cc: current@FreeBSD.org Subject: Re: BETA1 5.3 make world DESTDIR failure X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list Reply-To: obrien@FreeBSD.org List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 25 Aug 2004 18:30:03 -0000 On Wed, Aug 25, 2004 at 08:49:09PM +0300, Ruslan Ermilov wrote: > On Wed, Aug 25, 2004 at 10:37:07AM -0700, David O'Brien wrote: > > On Wed, Aug 25, 2004 at 04:47:22PM +0300, Ruslan Ermilov wrote: > > > as IMAKEENV (from Makefile.inc1) doesn't utilize DESTDIR. I think I > > > know how to fix "make world DESTDIR=/foo" to make it work again -- we > > > need to convert all DESTDIR uses in Makefile.inc1 to be command-line > > > variables. I'm currently testing this patch, and it looks promising: > > > > Please also test 'make world' without DESTDIR in /etc/make.conf, but with > > 1. "HISTORICAL_MAKE_WORLD=yes" in /etc/make.conf > > 2. env HISTORICAL_MAKE_WORLD=yes make world > > before committing. > > > That's pointless for this change. If HISTORICAL_MAKE_WORLD is defined > and DESTDIR is not (irrelevant where), "make world" is just equivalent > to "make buildworld" followed by "make installworld". Clearly, "make > buildworld" without DESTDIR works with and without this change. I saw some references of "DESTDIR" in your patch and wasn't 100% sure it wouldn't be a problem. I don't understand the resistance to extra testing. :-) -- -- David (obrien@FreeBSD.org)