Date: Wed, 25 Aug 2004 11:30:02 -0700 From: "David O'Brien" <obrien@FreeBSD.org> To: Ruslan Ermilov <ru@FreeBSD.org> Cc: current@FreeBSD.org Subject: Re: BETA1 5.3 make world DESTDIR failure Message-ID: <20040825183002.GK53710@dragon.nuxi.com> In-Reply-To: <20040825174908.GA97530@ip.net.ua> References: <1093402508.488.8.camel@home> <20040825134842.M553@beagle.kn.op.dlr.de> <20040825134722.GD5872@ip.net.ua> <20040825173707.GH53710@dragon.nuxi.com> <20040825174908.GA97530@ip.net.ua>
next in thread | previous in thread | raw e-mail | index | archive | help
On Wed, Aug 25, 2004 at 08:49:09PM +0300, Ruslan Ermilov wrote: > On Wed, Aug 25, 2004 at 10:37:07AM -0700, David O'Brien wrote: > > On Wed, Aug 25, 2004 at 04:47:22PM +0300, Ruslan Ermilov wrote: > > > as IMAKEENV (from Makefile.inc1) doesn't utilize DESTDIR. I think I > > > know how to fix "make world DESTDIR=/foo" to make it work again -- we > > > need to convert all DESTDIR uses in Makefile.inc1 to be command-line > > > variables. I'm currently testing this patch, and it looks promising: > > > > Please also test 'make world' without DESTDIR in /etc/make.conf, but with > > 1. "HISTORICAL_MAKE_WORLD=yes" in /etc/make.conf > > 2. env HISTORICAL_MAKE_WORLD=yes make world > > before committing. > > > That's pointless for this change. If HISTORICAL_MAKE_WORLD is defined > and DESTDIR is not (irrelevant where), "make world" is just equivalent > to "make buildworld" followed by "make installworld". Clearly, "make > buildworld" without DESTDIR works with and without this change. I saw some references of "DESTDIR" in your patch and wasn't 100% sure it wouldn't be a problem. I don't understand the resistance to extra testing. :-) -- -- David (obrien@FreeBSD.org)
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20040825183002.GK53710>