From nobody Mon Dec 1 15:31:19 2025 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4dKntf2Hdyz6JksM; Mon, 01 Dec 2025 15:31:22 +0000 (UTC) (envelope-from fuz@fuz.su) Received: from fuz.su (fuz.su [IPv6:2001:41d0:8:e508::1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "fuz.su", Issuer "fuz.su" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 4dKntd6KyTz3S8S; Mon, 01 Dec 2025 15:31:21 +0000 (UTC) (envelope-from fuz@fuz.su) Authentication-Results: mx1.freebsd.org; none Received: from fuz.su (localhost [127.0.0.1]) by fuz.su (8.18.1/8.18.1) with ESMTPS id 5B1FVJZV009787 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NO); Mon, 1 Dec 2025 16:31:20 +0100 (CET) (envelope-from fuz@fuz.su) Received: (from fuz@localhost) by fuz.su (8.18.1/8.18.1/Submit) id 5B1FVJEj009786; Mon, 1 Dec 2025 16:31:19 +0100 (CET) (envelope-from fuz) Date: Mon, 1 Dec 2025 16:31:19 +0100 From: Robert Clausecker To: Jessica Clarke Cc: Kristof Provost , Robert Clausecker , "src-committers@freebsd.org" , "dev-commits-src-all@freebsd.org" , "dev-commits-src-main@freebsd.org" Subject: Re: git: 2fb8cbc6ef1b - main - libc/tests: add stdbit test framework and unit tests Message-ID: References: <692c9966.26e27.70621b5b@gitrepo.freebsd.org> <3E139664-C0CE-4BB9-9225-66D7D44D644E@FreeBSD.org> <6903AA87-20BC-4060-A199-4100FC7CD8EB@freebsd.org> List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-main@freebsd.org Sender: owner-dev-commits-src-main@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <6903AA87-20BC-4060-A199-4100FC7CD8EB@freebsd.org> X-Spamd-Bar: ---- X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[]; ASN(0.00)[asn:16276, ipnet:2001:41d0::/32, country:FR] X-Rspamd-Pre-Result: action=no action; module=replies; Message is reply to one we originated X-Rspamd-Queue-Id: 4dKntd6KyTz3S8S Hi Jessica, Am Mon, Dec 01, 2025 at 02:04:22PM +0000 schrieb Jessica Clarke: > On 1 Dec 2025, at 13:56, Kristof Provost wrote: > > > > On 30 Nov 2025, at 20:22, Robert Clausecker wrote: > > The branch main has been updated by fuz: > > URL: https://cgit.FreeBSD.org/src/commit/?id=2fb8cbc6ef1b3cc6cd60e5db07f8305623f9b044 > > commit 2fb8cbc6ef1b3cc6cd60e5db07f8305623f9b044 > > Author: Robert Clausecker fuz@FreeBSD.org > > AuthorDate: 2025-11-18 17:33:12 +0000 > > Commit: Robert Clausecker fuz@FreeBSD.org > > CommitDate: 2025-11-30 19:21:52 +0000 > > libc/tests: add stdbit test framework and unit tests > > > > This adds unit tests for all 70 functions in . > > > > I'm sorry for the test framework, but it makes it so I don't > > have to write 70 unit tests by hand. > > > > Reviewed by: adrian, des > > Approved by: markj (mentor) > > MFC after: 1 month > > Differential Revision: https://reviews.freebsd.org/D53660 > > > > I’m having issues running the tests now. > > I get this kyua error doing kyua list in /usr/tests/lib: > > kyua: E: Load of 'Kyuafile' failed: Failed to load Lua file 'Kyuafile': Kyuafile:48: Load of 'libc/Kyuafile' failed: Failed to load Lua file 'libc/Kyuafile': libc/Kyuafile:19: Load of 'libc/stdbit/Kyuafile' failed: File 'libc/stdbit/Kyuafile' not found. > > > > That’s presumably because there’s no Kyuafile (or indeed anything at all) in /usr/tests/lib/libc/stdbit. > > It’s not immediately obvious to me what went wrong to cause that, but I’m relatively confident it’s related to this commit. > > Best regards, > > Kristof > > Because TESTSDIR is /usr/tests/lib/libc/tests/stdbit thanks to the > location of libc’s tests in the src tree. That’s meant to be overridden > for every subdirectory, whether by including ../Makefile.netbsd-tests, > in the case of all the NetBSD-imported ones, or by manually overriding > it, such as in lib/libc/tests/iconv/Makefile. > > It would've been nice to test these tests prior to commit. Was that not > done? I ran "make check" in lib/libc/tests/stdbit and it seems to have passed. I was not aware that this is insufficient. I will develop a fix and add it. A guide on how to add a new directory to the test suite would also be nice. Yours, Robert Clausecker -- () ascii ribbon campaign - for an encoding-agnostic world /\ - against html email - against proprietary attachments