From owner-p4-projects@FreeBSD.ORG  Sat Jul 21 08:17:16 2007
Return-Path: <owner-p4-projects@FreeBSD.ORG>
Delivered-To: p4-projects@freebsd.org
Received: by hub.freebsd.org (Postfix, from userid 32767)
	id 4F21F16A41F; Sat, 21 Jul 2007 08:17:16 +0000 (UTC)
Delivered-To: perforce@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 0D40716A41A
	for <perforce@freebsd.org>; Sat, 21 Jul 2007 08:17:16 +0000 (UTC)
	(envelope-from andrew@freebsd.org)
Received: from repoman.freebsd.org (repoman.freebsd.org
	[IPv6:2001:4f8:fff6::29])
	by mx1.freebsd.org (Postfix) with ESMTP id F15D713C459
	for <perforce@freebsd.org>; Sat, 21 Jul 2007 08:17:15 +0000 (UTC)
	(envelope-from andrew@freebsd.org)
Received: from repoman.freebsd.org (localhost [127.0.0.1])
	by repoman.freebsd.org (8.14.1/8.14.1) with ESMTP id l6L8HFd0031560
	for <perforce@freebsd.org>; Sat, 21 Jul 2007 08:17:15 GMT
	(envelope-from andrew@freebsd.org)
Received: (from perforce@localhost)
	by repoman.freebsd.org (8.14.1/8.14.1/Submit) id l6L8HF1c031557
	for perforce@freebsd.org; Sat, 21 Jul 2007 08:17:15 GMT
	(envelope-from andrew@freebsd.org)
Date: Sat, 21 Jul 2007 08:17:15 GMT
Message-Id: <200707210817.l6L8HF1c031557@repoman.freebsd.org>
X-Authentication-Warning: repoman.freebsd.org: perforce set sender to
	andrew@freebsd.org using -f
From: Andrew Turner <andrew@FreeBSD.org>
To: Perforce Change Reviews <perforce@freebsd.org>
Cc: 
Subject: PERFORCE change 123834 for review
X-BeenThere: p4-projects@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: p4 projects tree changes <p4-projects.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/p4-projects>,
	<mailto:p4-projects-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/p4-projects>
List-Post: <mailto:p4-projects@freebsd.org>
List-Help: <mailto:p4-projects-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/p4-projects>,
	<mailto:p4-projects-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sat, 21 Jul 2007 08:17:16 -0000

http://perforce.freebsd.org/chv.cgi?CH=123834

Change 123834 by andrew@andrew_hermies on 2007/07/21 08:17:03

	In a facuns array only free obj_array_count items. Without this valgrind complains about invalid reads as the last item may not be NULL;

Affected files ...

.. //depot/projects/soc2007/andrew-update/lib/facund_object.c#8 edit

Differences ...

==== //depot/projects/soc2007/andrew-update/lib/facund_object.c#8 (text+ko) ====

@@ -338,7 +338,7 @@
 	if (obj->obj_array != NULL) {
 		unsigned int i;
 
-		for (i = 0; obj->obj_array[i] != NULL; i++) {
+		for (i = 0; i < obj->obj_array_count; i++) {
 			facund_object_free(obj->obj_array[i]);
 		}
 		free(obj->obj_array);