From nobody Sat Jan 3 02:57:26 2026 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4djlbV6mq0z6Ml0n for ; Sat, 03 Jan 2026 02:57:26 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R13" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4djlbV4Q66z3wMx for ; Sat, 03 Jan 2026 02:57:26 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1767409046; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=fAbFGC9sIGT4UIZH+ex0ovy51MRr2mT3FxEK6AGkevU=; b=ZtZXCNtoF/inx+S1wFwXQpEWG5Y/9Uw2duMyR3r5QZdbp8DLNlQ+FzN7JtWRE1oIyeaCsl GdePgZ0lFenObFI0gF5ihoX3xpyKP1ucfAMQHGf3D8wmaHZ4glT9QzSfk1sVkcoC3esHAh 3Z2kw3jamtGZVS36Rv8ch+UDR/BBw8QMDwB1tGzgB7EqBRGvhhF71ao8YuQsnu6Q+eqlwQ ifzwOWNV+WsU1A42XpazLPTu8Wq+vbcaVnMRtwGYRUEsGLqQYLGn47+StELbCkSzjniMvl nNSwLE/prF3Jto0AbPBzwIpKWf1Cl29NFITB319JGTxc2WreDGUF5XtQ5ukqNg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1767409046; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=fAbFGC9sIGT4UIZH+ex0ovy51MRr2mT3FxEK6AGkevU=; b=rUPPbZogeDTjc7wT+pWw65tyFGswNHyj/g7zPcO8JVOeHbjv6xPy/ij8kWq9Q2Kqdlz/rO xsHN3wOglTg8WLkaSWt8noG8DIC3kvp7DRlfGh9ou0AJ1KJVpj5FPTiNdGrtqNAYrGi85G M4o/PHUWWkQS1ZwfIof9xd9xo2d+MWvyCOY6d3VfO3M+mU9xHmukTCIzDg4HtPglVrsOMs asoJT4PpXaEI93Mow2vGdmZeQCKyreshMQUYxnhYfccDoeMyU88EM52bwS34VhVLdOmKi9 0Em55WKCMWPtsaJCrHbpzLHxePuI1dbMIqWGlp2qeqyDSqMirSAieShwwTwN7Q== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1767409046; a=rsa-sha256; cv=none; b=c5xbH1GOUhxlyhR8+5NoPKubht+fk0VHZfU+C41PDVghP++fFvVqSjfn+orlCDjIdLjb5u 5SFjF4trGM8XmFwexJ9r55NS79H3PGG82Pp4P0gVB5kp4/4gVcT3RcDrMzIaTTmNqhVNTS wePn2T17sQ5YNE/Tgw61krMafCgBSLR455X8kNzgm/4yAP3YI4ueITh/rMWPcEDlgFKkdU 7PSHhxNgJlJHgKklU4zBoB2nPewrUNO8a8qa1UaRaXWl90obpbvKn3SgpFB9eUAYognlLG VCDFezarAGo+DS/rPWZT9x/6AkBdSTv2GBrOB2CzKYEg3UQWF3IaXpSnaZzAjA== ARC-Authentication-Results: i=1; mx1.freebsd.org; none Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) by mxrelay.nyi.freebsd.org (Postfix) with ESMTP id 4djlbV3NnczmZR for ; Sat, 03 Jan 2026 02:57:26 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from git (uid 1279) (envelope-from git@FreeBSD.org) id 46e51 by gitrepo.freebsd.org (DragonFly Mail Agent v0.13+ on gitrepo.freebsd.org); Sat, 03 Jan 2026 02:57:26 +0000 To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Lexi Winter Subject: git: 2e92aeede85c - main - bridge: Allow BRDGSIFVLANSET without IFBRF_VLANFILTER List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: ivy X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: 2e92aeede85c8986bd6f4dde65d2ac2449eccf51 Auto-Submitted: auto-generated Date: Sat, 03 Jan 2026 02:57:26 +0000 Message-Id: <69588596.46e51.576d9e8f@gitrepo.freebsd.org> The branch main has been updated by ivy: URL: https://cgit.FreeBSD.org/src/commit/?id=2e92aeede85c8986bd6f4dde65d2ac2449eccf51 commit 2e92aeede85c8986bd6f4dde65d2ac2449eccf51 Author: Lexi Winter AuthorDate: 2026-01-03 01:13:22 +0000 Commit: Lexi Winter CommitDate: 2026-01-03 02:57:16 +0000 bridge: Allow BRDGSIFVLANSET without IFBRF_VLANFILTER Currently, we disallow BRDGSIFVLANSET when IFBRF_VLANFILTER is disabled. There's no particular reason to do this, and it causes some undesirable behaviour such as not being able to remove the tagged config on a member after disabling vlanfilter on the bridge. Remove the restriction so BRDGSIFVLANSET is always accepted. PR: 292019 MFC after: 1 week Reviewed by: zlei, p.mousavizadeh_protonmail.com Sponsored by: https://www.patreon.com/bsdivy Differential Revision: https://reviews.freebsd.org/D54435 --- sys/net/if_bridge.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/sys/net/if_bridge.c b/sys/net/if_bridge.c index 9a468a8eb462..5bdd8613245e 100644 --- a/sys/net/if_bridge.c +++ b/sys/net/if_bridge.c @@ -1990,9 +1990,6 @@ bridge_ioctl_sifvlanset(struct bridge_softc *sc, void *arg) struct ifbif_vlan_req *req = arg; struct bridge_iflist *bif; - if ((sc->sc_flags & IFBRF_VLANFILTER) == 0) - return (EXTERROR(EINVAL, "VLAN filtering not enabled")); - bif = bridge_lookup_member(sc, req->bv_ifname); if (bif == NULL) return (EXTERROR(ENOENT, "Interface is not a bridge member"));