From owner-cvs-all Sat Aug 24 15:51:10 2002 Delivered-To: cvs-all@freebsd.org Received: from mx1.FreeBSD.org (mx1.FreeBSD.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 3991837B400; Sat, 24 Aug 2002 15:51:03 -0700 (PDT) Received: from fledge.watson.org (fledge.watson.org [204.156.12.50]) by mx1.FreeBSD.org (Postfix) with ESMTP id 70DAF43E72; Sat, 24 Aug 2002 15:51:02 -0700 (PDT) (envelope-from arr@watson.org) Received: from fledge.watson.org (localhost [127.0.0.1]) by fledge.watson.org (8.12.4/8.12.4) with ESMTP id g7OMokOn026325; Sat, 24 Aug 2002 18:50:46 -0400 (EDT) (envelope-from arr@watson.org) Received: from localhost (arr@localhost) by fledge.watson.org (8.12.5/8.12.5/Submit) with SMTP id g7OMojSA026322; Sat, 24 Aug 2002 18:50:45 -0400 (EDT) X-Authentication-Warning: fledge.watson.org: arr owned process doing -bs Date: Sat, 24 Aug 2002 18:50:44 -0400 (EDT) From: "Andrew R. Reiter" To: Alfred Perlstein Cc: cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/kern sysv_sem.c In-Reply-To: <200208130847.g7D8lKKQ036126@freefall.freebsd.org> Message-ID: MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG On Tue, 13 Aug 2002, Alfred Perlstein wrote: :alfred 2002/08/13 01:47:17 PDT : : Modified files: : sys/kern sysv_sem.c : Log: : Make SYSVSEM mpsafe. Each semaphore set gets its own lock, however : there is a global lock over the undo structures because of the way : they are managed. : : Switch to using SLIST instead of rolling our own linked list. : : Fix several races where a permission check was done before a : copyin/copyout, if the copy happened to fault it may have been : possible to race for access to a semaphore set that one shouldn't : have access to. : : Requested by: rwatson : Tested by: NetBSD regression suite. Damn, I go away for 2 weeks away from net access ... do the same code... *darn* :) Good stuff! Thanks for the effort! Cheers, -- Andrew R. Reiter arr@watson.org arr@FreeBSD.org To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message