From owner-svn-src-head@freebsd.org Sat Dec 14 19:54:53 2019 Return-Path: Delivered-To: svn-src-head@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id DE4391D5B3E; Sat, 14 Dec 2019 19:54:53 +0000 (UTC) (envelope-from cse.cem@gmail.com) Received: from mail-ot1-f45.google.com (mail-ot1-f45.google.com [209.85.210.45]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 47ZytN6MMPz3Cd0; Sat, 14 Dec 2019 19:54:52 +0000 (UTC) (envelope-from cse.cem@gmail.com) Received: by mail-ot1-f45.google.com with SMTP id 77so3589271oty.6; Sat, 14 Dec 2019 11:54:52 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:reply-to :from:date:message-id:subject:to:cc; bh=D0qrYWLZYApIePW8o7nuHNGo9VqVIjOjCixj0Ty+9AA=; b=F1HszFRq/5ml2Oee2WTWoyz/Sv8AnIHFAKP2Sn4JZD1iIfPifD5jpZUNi6/vyl5JiK rxObsdhJbligaViPza7WCZp7oTzwNJTgoNUDlfNiPuQE/MDQMfWmm6gSrV2DhE5JgUEK 1SIngwM62VhsOAjijzuUkcJk94PvKRxusykH8COFmRSqBaAfTrNd/XnCJAAM7tSnNo6E vyHBF+n8Z3FPWBVCGvsRzSR1Ub+gZ82dSBp7svUpKaMK3I4Z1h0GRvtEh60E7XRhejyW Y+aIF3/lNQMuyWxnCqcxan5Jdne7wKhqduMsYm7Uru6+d7nkyDlZ61g0CI37dWAqAnvI iBjw== X-Gm-Message-State: APjAAAVDf87y+CE0zuXbaX/nPRabBnpqKrGSmUQ0JSJwsouwwK3Y8Lso j5LnEJDz8TQO66WQU3rCKjc6k2lY X-Google-Smtp-Source: APXvYqy6nQnuOOk26udqq7HixJGtGboD2oAzUzAt9/xy6gWS0CaptRLCyRrMRr75Agz2Wxo3yYnNuA== X-Received: by 2002:a9d:70d2:: with SMTP id w18mr23547955otj.48.1576353291473; Sat, 14 Dec 2019 11:54:51 -0800 (PST) Received: from mail-ot1-f42.google.com (mail-ot1-f42.google.com. [209.85.210.42]) by smtp.gmail.com with ESMTPSA id s9sm4757977oic.15.2019.12.14.11.54.51 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 14 Dec 2019 11:54:51 -0800 (PST) Received: by mail-ot1-f42.google.com with SMTP id x3so3554191oto.11; Sat, 14 Dec 2019 11:54:51 -0800 (PST) X-Received: by 2002:a9d:7593:: with SMTP id s19mr21114124otk.219.1576353290946; Sat, 14 Dec 2019 11:54:50 -0800 (PST) MIME-Version: 1.0 References: <201912140828.xBE8SAXq027656@repo.freebsd.org> <7d4c68ec-97e9-8b29-ac70-f8167f31de37@FreeBSD.org> In-Reply-To: Reply-To: cem@freebsd.org From: Conrad Meyer Date: Sat, 14 Dec 2019 11:54:40 -0800 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: svn commit: r355747 - in head: . include lib/libc/stdlib lib/libxo To: Warner Losh Cc: Pedro Giffuni , Ryan Libby , src-committers , svn-src-all , svn-src-head X-Rspamd-Queue-Id: 47ZytN6MMPz3Cd0 X-Spamd-Bar: -- Authentication-Results: mx1.freebsd.org; dkim=none; dmarc=none; spf=pass (mx1.freebsd.org: domain of csecem@gmail.com designates 209.85.210.45 as permitted sender) smtp.mailfrom=csecem@gmail.com X-Spamd-Result: default: False [-2.10 / 15.00]; RCVD_VIA_SMTP_AUTH(0.00)[]; HAS_REPLYTO(0.00)[cem@freebsd.org]; RWL_MAILSPIKE_GOOD(0.00)[45.210.85.209.rep.mailspike.net : 127.0.0.18]; R_SPF_ALLOW(-0.20)[+ip4:209.85.128.0/17]; REPLYTO_ADDR_EQ_FROM(0.00)[]; URI_COUNT_ODD(1.00)[3]; RCPT_COUNT_FIVE(0.00)[6]; RCVD_COUNT_THREE(0.00)[4]; TO_DN_ALL(0.00)[]; FORGED_SENDER(0.30)[cem@freebsd.org,csecem@gmail.com]; MIME_TRACE(0.00)[0:+,1:+,2:~]; R_DKIM_NA(0.00)[]; FREEMAIL_ENVFROM(0.00)[gmail.com]; ASN(0.00)[asn:15169, ipnet:209.85.128.0/17, country:US]; TAGGED_FROM(0.00)[]; ARC_NA(0.00)[]; NEURAL_HAM_MEDIUM(-1.00)[-0.996,0]; FROM_NEQ_ENVFROM(0.00)[cem@freebsd.org,csecem@gmail.com]; FROM_HAS_DN(0.00)[]; NEURAL_HAM_LONG(-0.99)[-0.988,0]; MIME_GOOD(-0.10)[multipart/alternative,text/plain]; DMARC_NA(0.00)[freebsd.org]; TO_MATCH_ENVRCPT_SOME(0.00)[]; RCVD_IN_DNSWL_NONE(0.00)[45.210.85.209.list.dnswl.org : 127.0.5.0]; IP_SCORE(-1.12)[ip: (-0.50), ipnet: 209.85.128.0/17(-3.13), asn: 15169(-1.91), country: US(-0.05)]; RCVD_TLS_ALL(0.00)[] Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Content-Filtered-By: Mailman/MimeDel 2.1.29 X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 14 Dec 2019 19:54:53 -0000 I agree, a cdefs.h definition would be pleasant even if gcc4 isn=E2=80=99t = a factor (and it=E2=80=99s not in about two weeks). I=E2=80=99ll go ahead and do tha= t. On Sat, Dec 14, 2019 at 11:28 Warner Losh wrote: > > > On Sat, Dec 14, 2019 at 12:22 PM Pedro Giffuni wrote: > >> >> On 14/12/2019 13:20, Ryan Libby wrote: >> > On Sat, Dec 14, 2019 at 12:28 AM Conrad Meyer wrote: >> >> Author: cem >> >> Date: Sat Dec 14 08:28:10 2019 >> >> New Revision: 355747 >> >> URL: https://svnweb.freebsd.org/changeset/base/355747 >> >> >> >> Log: >> >> Deprecate sranddev(3) API >> >> >> >> It serves no useful purpose and wasn't as popular as its equally >> meritless >> >> cousin, srandomdev(3). >> >> >> >> .. (cut unrelated code) >> >> >> >> Modified: head/include/stdlib.h >> >> >> =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D >> >> --- head/include/stdlib.h Sat Dec 14 05:21:56 2019 >> (r355746) >> >> +++ head/include/stdlib.h Sat Dec 14 08:28:10 2019 >> (r355747) >> >> @@ -309,12 +309,17 @@ int rpmatch(const char *); >> >> void setprogname(const char *); >> >> int sradixsort(const unsigned char **, int, const unsigned char >> *, >> >> unsigned); >> >> -void sranddev(void); >> >> void srandomdev(void); >> >> long long >> >> strtonum(const char *, long long, long long, const char **); >> >> >> >> /* Deprecated interfaces, to be removed. */ >> >> +static inline void >> >> +__attribute__((__deprecated__("sranddev to be removed in FreeBSD >> 13"))) >> >> +sranddev(void) >> >> +{ >> >> +} >> >> + >> > This broke some gcc builds in ci. It looks like older versions of gcc >> > don't like having an argument to deprecated. >> >> FWIW, the msg argument for __deprecated__ appeared in GCC 4.5. >> > > Maybe sys/cdefs.h should define a __DEPRECATED for such differences? It's > not like __attribute__ is a standard thing anyway... > > Warner >