From owner-freebsd-wireless@FreeBSD.ORG Sat Jun 21 15:55:26 2014 Return-Path: Delivered-To: freebsd-wireless@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 4AA7AEC7 for ; Sat, 21 Jun 2014 15:55:26 +0000 (UTC) Received: from mail.ignoranthack.me (ignoranthack.me [199.102.79.106]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 2BFBE2D90 for ; Sat, 21 Jun 2014 15:55:25 +0000 (UTC) Received: from [192.168.200.204] (c-50-131-5-126.hsd1.ca.comcast.net [50.131.5.126]) (using SSLv3 with cipher DHE-RSA-AES128-SHA (128/128 bits)) (No client certificate requested) (Authenticated sender: sbruno@ignoranthack.me) by mail.ignoranthack.me (Postfix) with ESMTPSA id 07FE61936DE for ; Sat, 21 Jun 2014 15:55:23 +0000 (UTC) Subject: wireless mcast updates, ic->ic_update_mcast From: Sean Bruno Reply-To: sbruno@freebsd.org To: freebsd-wireless@freebsd.org Content-Type: text/plain; charset="us-ascii" Date: Sat, 21 Jun 2014 08:55:23 -0700 Message-ID: <1403366123.39384.10.camel@bruno> Mime-Version: 1.0 X-Mailer: Evolution 2.32.1 FreeBSD GNOME Team Port Content-Transfer-Encoding: 7bit X-BeenThere: freebsd-wireless@freebsd.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: "Discussions of 802.11 stack, tools device driver development." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 21 Jun 2014 15:55:26 -0000 My T61 has a wpi(4) card in it. I noted that the console message "needs muticast update" is emitted as it doesn't implement the required function in its code and uses the default of the net80211 stack. I haven't noted any issues, but I took a journey through some of the wireless drivers to see what the status of implementation was. It seems most of the drivers stub out the required function to get rid of the warning. I perceive that with 6 exceptions, most of our wireless adapters don't have an implementation, or worse, they implement a stub to squash the warning. Shouldn't these stub functions be removed? Perhaps wrapp the net80211 default behavior in bootverbose? -- implemented ic_update_mcast() ath/if_ath.c -- implemented and working usb/wlan/if_zyd.c -- implemented and working usb/wlan/if_wi.c -- implemented and working -- sets a flag to default o/s behvavior? mwl/if_mlw.c -- function coded out, most code if 0'd out usb/wlan/if_upgt.c -- looks to default to whatever the o/s can do. usr/wlan/if_run.c -- looks to default to whatever the o/s can do -- stubbed out function to squash warning (bug?) iwn/if_iwn.c -- stubbed out in if_iwn to remove default error usb/wlan/if_rum.c -- stubbed out to remove default error usb/wlan/if_urtwn.c -- stubbed out to remove default error usb/wlan/if_urtw.c -- stubbed out to remove default error usr/wlan/if_uath.c -- stubbed out to remove default error usb/wlan/if_rsu.c -- stubbed out to remove default error wtap/if_wtap.c -- stubbed out to remove default error -- undefined, emits error correctly wpi/if_wpi.c bwi/if_bwi.c bwn/if_bwn.c ipw/if_ipw.c malo/if_malo.c ral/rt2560.c ral/rt2860.c ral/rt2661.c wi/if_wi.c usb/wlan/if_ural.c