From owner-svn-src-head@FreeBSD.ORG  Thu Jan 22 09:16:25 2015
Return-Path: <owner-svn-src-head@FreeBSD.ORG>
Delivered-To: svn-src-head@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by hub.freebsd.org (Postfix) with ESMTPS id CB88C844;
 Thu, 22 Jan 2015 09:16:25 +0000 (UTC)
Received: from kib.kiev.ua (kib.kiev.ua [IPv6:2001:470:d5e7:1::1])
 (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits))
 (Client did not present a certificate)
 by mx1.freebsd.org (Postfix) with ESMTPS id 579D4262;
 Thu, 22 Jan 2015 09:16:25 +0000 (UTC)
Received: from tom.home (kostik@localhost [127.0.0.1])
 by kib.kiev.ua (8.14.9/8.14.9) with ESMTP id t0M9GKwp071888
 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO);
 Thu, 22 Jan 2015 11:16:20 +0200 (EET)
 (envelope-from kostikbel@gmail.com)
DKIM-Filter: OpenDKIM Filter v2.9.2 kib.kiev.ua t0M9GKwp071888
Received: (from kostik@localhost)
 by tom.home (8.14.9/8.14.9/Submit) id t0M9GKmF071887;
 Thu, 22 Jan 2015 11:16:20 +0200 (EET)
 (envelope-from kostikbel@gmail.com)
X-Authentication-Warning: tom.home: kostik set sender to kostikbel@gmail.com
 using -f
Date: Thu, 22 Jan 2015 11:16:20 +0200
From: Konstantin Belousov <kostikbel@gmail.com>
To: Gleb Smirnoff <glebius@FreeBSD.org>
Subject: Re: svn commit: r277489 - head/sys/kern
Message-ID: <20150122091620.GX42409@kib.kiev.ua>
References: <201501211632.t0LGWtOR098070@svn.freebsd.org>
 <20150121182444.GG15484@FreeBSD.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20150121182444.GG15484@FreeBSD.org>
User-Agent: Mutt/1.5.23 (2014-03-12)
X-Spam-Status: No, score=-2.0 required=5.0 tests=ALL_TRUSTED,BAYES_00,
 DKIM_ADSP_CUSTOM_MED,FREEMAIL_FROM,NML_ADSP_CUSTOM_MED autolearn=no
 autolearn_force=no version=3.4.0
X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on tom.home
Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org,
 src-committers@freebsd.org
X-BeenThere: svn-src-head@freebsd.org
X-Mailman-Version: 2.1.18-1
Precedence: list
List-Id: SVN commit messages for the src tree for head/-current
 <svn-src-head.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/svn-src-head>,
 <mailto:svn-src-head-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-head/>
List-Post: <mailto:svn-src-head@freebsd.org>
List-Help: <mailto:svn-src-head-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-head>,
 <mailto:svn-src-head-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Thu, 22 Jan 2015 09:16:25 -0000

On Wed, Jan 21, 2015 at 09:24:44PM +0300, Gleb Smirnoff wrote:
> On Wed, Jan 21, 2015 at 04:32:55PM +0000, Konstantin Belousov wrote:
> K> Author: kib
> K> Date: Wed Jan 21 16:32:54 2015
> K> New Revision: 277489
> K> URL: https://svnweb.freebsd.org/changeset/base/277489
> K> 
> K> Log:
> K>   Do not assert that the new pipepair mutex is not initialized.  The
> K>   backing memory contains garbage and might trigger the assertion.
> 
> I have touched dozen of places in kernel where I do explicit M_ZERO on
> allocation just to satisfy later assertion in the mtx_init. Is the
> correct fix to use MTX_NEW?

I think MTX_NEW is better.  Note that this flag is just a month old, it
was added by dchagin in r275751.