From owner-freebsd-amd64@FreeBSD.ORG Thu Nov 11 18:40:41 2004 Return-Path: Delivered-To: freebsd-amd64@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id E07BC16A4CE for ; Thu, 11 Nov 2004 18:40:41 +0000 (GMT) Received: from mail2.speakeasy.net (mail2.speakeasy.net [216.254.0.202]) by mx1.FreeBSD.org (Postfix) with ESMTP id 9754943D39 for ; Thu, 11 Nov 2004 18:40:41 +0000 (GMT) (envelope-from jmg@hydrogen.funkthat.com) Received: (qmail 12661 invoked from network); 11 Nov 2004 18:40:41 -0000 Received: from gate.funkthat.com (HELO hydrogen.funkthat.com) ([69.17.45.168]) (envelope-sender ) by mail2.speakeasy.net (qmail-ldap-1.03) with SMTP for ; 11 Nov 2004 18:40:41 -0000 Received: from hydrogen.funkthat.com (uhupcr@localhost.funkthat.com [127.0.0.1])iABIeeB6044229; Thu, 11 Nov 2004 10:40:40 -0800 (PST) (envelope-from jmg@hydrogen.funkthat.com) Received: (from jmg@localhost) by hydrogen.funkthat.com (8.12.10/8.12.10/Submit) id iABIeeKm044228; Thu, 11 Nov 2004 10:40:40 -0800 (PST) Date: Thu, 11 Nov 2004 10:40:40 -0800 From: John-Mark Gurney To: Astrodog Message-ID: <20041111184040.GF54817@funkthat.com> Mail-Followup-To: Astrodog , Brooks Davis , freebsd-current@freebsd.org, freebsd-amd64@freebsd.org References: <2fd864e04111105557032a7c3@mail.gmail.com> <20041111153114.GA2533@odin.ac.hmc.edu> <2fd864e04111107487254fc10@mail.gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <2fd864e04111107487254fc10@mail.gmail.com> User-Agent: Mutt/1.4.1i X-Operating-System: FreeBSD 4.2-RELEASE i386 X-PGP-Fingerprint: B7 EC EF F8 AE ED A7 31 96 7A 22 B3 D8 56 36 F4 X-Files: The truth is out there X-URL: http://resnet.uoregon.edu/~gurney_j/ X-Resume: http://resnet.uoregon.edu/~gurney_j/resume.html cc: freebsd-current@freebsd.org cc: freebsd-amd64@freebsd.org Subject: Re: Commitable R3000Z Patch! X-BeenThere: freebsd-amd64@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list Reply-To: John-Mark Gurney List-Id: Porting FreeBSD to the AMD64 platform List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 11 Nov 2004 18:40:42 -0000 Astrodog wrote this message on Thu, Nov 11, 2004 at 09:48 -0600: > Any hint will do, honestly. Just altering the patch to reflect the > change will work. I'd like to automate it by detecting the mobile > nforce3 chipsets, but I don't even know where to start with that yet. > Any suggestions? Why don't you fix the real problem, which is that atkbdc_configure is called from atkbd_configure even when the device is disabled? Why not fix atkbd_configure to just bail out if the reousrce is disabled? > On Thu, 11 Nov 2004 07:31:14 -0800, Brooks Davis > wrote: > > On Thu, Nov 11, 2004 at 05:55:20AM -0800, Astrodog wrote: > > > > > > > The patch is located at > > > http://evogaming.il.us.tveps.net/~astrodog/atkbdc.patch testing was > > > quite limited, but essentally, if you set hint.atkbd.0.disabled to 1, > > > it disables the test. I suppose it could be renamed to any number of > > > things, the code is a whole 2 lines, and is quite obvious. I'm gonna > > > wait to see if it makes -CURRENT in the next day or so, so I don't end > > > up with people grabbing ISOs from me if I don't have to (Snapshots > > > servers are your freind). Automatic detection code to follow in the > > > next day or so. This was tested on a Compaq 3004US, and it solved the > > > reboot problem. I also tested on a dual opteron 240 machine, and when > > > the hint is not set, it has no effect. I'm going to double-post to > > > freebsd-current in hopes of getting it committed sooner, so all of us > > > 3000Z-base laptop owners can have our fun with FreeBSD. > > > > Do you really have to use this hint? You're changing the meaning of > > only one disabled flag which we're trying to make consistant. If that's > > all you can use at that point, we'll live, but it seems ugly. -- John-Mark Gurney Voice: +1 415 225 5579 "All that I will do, has been done, All that I have, has not."