From owner-freebsd-arch@FreeBSD.ORG Tue Feb 16 19:58:12 2010 Return-Path: Delivered-To: arch@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 12F23106566C for ; Tue, 16 Feb 2010 19:58:12 +0000 (UTC) (envelope-from asmrookie@gmail.com) Received: from mail-yx0-f172.google.com (mail-yx0-f172.google.com [209.85.210.172]) by mx1.freebsd.org (Postfix) with ESMTP id C154D8FC19 for ; Tue, 16 Feb 2010 19:58:11 +0000 (UTC) Received: by yxe2 with SMTP id 2so6606564yxe.7 for ; Tue, 16 Feb 2010 11:58:11 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:mime-version:sender:received:in-reply-to :references:date:x-google-sender-auth:message-id:subject:from:to:cc :content-type; bh=uyHLOsYK05KaDlhB0Mb5id+kzaytBJ6yY/K4bblN9tA=; b=cwPXAG0eS4jSyX3VLmdlso50fB8EoVgmv+wErbJN1bOOwHbrNm3+I0e+pmFNxG2iVX mrM9v1Cef8HIK2xXs2/iRFit1sdiIdDT8dHdfj3cS+265UwZIEOFu2U9nG4zzegWEJzF hP2/XbdrI7taQNM7ku66Guh5QbA+rRaulf1hs= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:sender:in-reply-to:references:date :x-google-sender-auth:message-id:subject:from:to:cc:content-type; b=wrPiTDMY3BVTsFDMXVVS+6ef6tN38faBoCiV2aN8n+cfopb/TkvBLWzEROAADoLGko uzTzJ1sIftHCfG/ggKEuphvPp8KesuiIWRJflPHxfrCq9VMVDmXFqTUlbvzp00HG42bx MrZuVFrmuv92EMdegiCfbcYnrXJuLDuLiMFUc= MIME-Version: 1.0 Sender: asmrookie@gmail.com Received: by 10.231.153.205 with SMTP id l13mr281188ibw.64.1266350286689; Tue, 16 Feb 2010 11:58:06 -0800 (PST) In-Reply-To: <20100216195440.GF50403@deviant.kiev.zoral.com.ua> References: <3bbf2fe11002151610l41526f55r5e60b5e46ce42b64@mail.gmail.com> <20100216195440.GF50403@deviant.kiev.zoral.com.ua> Date: Tue, 16 Feb 2010 20:58:06 +0100 X-Google-Sender-Auth: da83fa64bee7a984 Message-ID: <3bbf2fe11002161158k79c09e91w1b459ab16e14b7b1@mail.gmail.com> From: Attilio Rao To: Kostik Belousov Content-Type: text/plain; charset=UTF-8 Cc: FreeBSD Arch , Ed Maste Subject: Re: [PATCH] Adding shared code support for ia32 and amd64 -- x86 sub-branch X-BeenThere: freebsd-arch@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Discussion related to FreeBSD architecture List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 16 Feb 2010 19:58:12 -0000 2010/2/16 Kostik Belousov : > On Tue, Feb 16, 2010 at 01:10:37AM +0100, Attilio Rao wrote: >> The following patch: >> http://www.freebsd.org/~attilio/x86.diff >> >> starts the effort for having a shared sub-tree between amd64 and ia32. >> In this initial pass I putted the low-hanging fruits (bios/cpufreq) >> and what my customer was more interested in (isa/*) in order to >> kick-off the effort and, in the future, move gradually the code there. >> With the machine/isa/* cleanup about 10 files are trimmed and I'm sure >> more can be achieved easilly. >> There are few things to discuss. One, that I had not necessity to dig >> about still, is about how to organize headers (include/). Maybe some >> replication ala pc98 may be good. >> >> The patch is big but it is mostly added and removed files (look at the >> files.X in order to understand better how files movements happened). >> >> Hope to see comments and reviews. > > IMO the diff is unreadable. I suggest to do actual svn cp (not svn mv) > operation now, without a review, and post a diff that should be applied > to x86/ directory, as well as to build glue. I'm not sure what you mean here. I also thought svn mv was keeping the file history (the old cvsup repocopy) and handling directly the svn del. > The small proposition I have is to #define read_eflags() read_rflags() > for amd64. I thought about having an unified read_flags() but to do that pass later. Attilio -- Peace can only be achieved by understanding - A. Einstein