From owner-freebsd-testing@FreeBSD.ORG Thu Jan 23 21:34:22 2014 Return-Path: Delivered-To: freebsd-testing@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id E15ED21D; Thu, 23 Jan 2014 21:34:21 +0000 (UTC) Received: from mail-pb0-x22a.google.com (mail-pb0-x22a.google.com [IPv6:2607:f8b0:400e:c01::22a]) (using TLSv1 with cipher ECDHE-RSA-RC4-SHA (128/128 bits)) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id 9D50D1E51; Thu, 23 Jan 2014 21:34:21 +0000 (UTC) Received: by mail-pb0-f42.google.com with SMTP id jt11so2366769pbb.15 for ; Thu, 23 Jan 2014 13:34:21 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=content-type:mime-version:subject:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to; bh=cvD0W8Gp3rwCQL/fICLqKH3ZgKvowj78zIiA0KrUNFY=; b=cRY13uZLzrLPBd9nufRikwQ6AfJBzLcjyFeLZTn5Yiolo/hrqOWU1cZNxMmPW6no58 WuSRJzV54Hid0UPK4kEVLaKKELt+R3eqs69dmHMeTGqCnUpr11duutQJW+veeKCvHtom n0sfrKQbqIqRCUoeQMYY4CHogrR5jpeIe4/FtVQA/kzd2w8vvkdQFebrllOGNE3OALr/ QapyhMM5VIWV2ViDDEAbvoUAv41ox7UtEv5TPdWCw0GPRQ62Z3LT1uPubpQL/eJQc3q0 o1W4qt0ZYIvThOfiD7LC70ZVvqXlF3JbLPeCP96YMJI7D8aaLu3uWyP4UqUb2CYa8tqU XsRA== X-Received: by 10.66.232.7 with SMTP id tk7mr10325881pac.94.1390512861243; Thu, 23 Jan 2014 13:34:21 -0800 (PST) Received: from fuji.zcorp.zonarsystems.com ([64.14.143.130]) by mx.google.com with ESMTPSA id dq3sm41316658pbc.35.2014.01.23.13.34.20 for (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Thu, 23 Jan 2014 13:34:20 -0800 (PST) Content-Type: text/plain; charset=windows-1252 Mime-Version: 1.0 (Mac OS X Mail 7.1 \(1827\)) Subject: Re: Makefile.inc1.patch From: Garrett Cooper In-Reply-To: Date: Thu, 23 Jan 2014 13:34:19 -0800 Content-Transfer-Encoding: quoted-printable Message-Id: <321F5F80-8195-4D06-8C43-3CC696C7BA01@gmail.com> References: <4A3E3984-73D3-4441-97A7-D58679EFF978@gmail.com> <9775878D-91AB-4BE4-ADFA-32D8DB582AA6@gmail.com> <4DB8E40F-6D7B-41A9-A0FA-B2E241E9A180@gmail.com> To: Alan Somers X-Mailer: Apple Mail (2.1827) Cc: "freebsd-testing@freebsd.org" , Brooks Davis , "Simon J. Gerraty" X-BeenThere: freebsd-testing@freebsd.org X-Mailman-Version: 2.1.17 Precedence: list List-Id: Testing on FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 23 Jan 2014 21:34:22 -0000 Ugh. Backwards logic (sorry)... On Jan 23, 2014, at 1:32 PM, Garrett Cooper = wrote: > On Jan 23, 2014, at 1:29 PM, Alan Somers wrote: >=20 >> On Thu, Jan 23, 2014 at 2:23 PM, Garrett Cooper = wrote: >>> On Jan 23, 2014, at 1:11 PM, Alan Somers = wrote: >>>=20 >>>> In that case, I'm missing something. I can't find any makefiles = that >>>> reference MK_ATF or a related variable. What is the effect of = setting >>>> WITH_ATF ? >>>>=20 >>>> -Alan >>>=20 >>> NO_TESTS forces WITHOUT_TESTS to be set. So, if I set NO_TESTS = in the various build steps it will force ATF to not be built. For that = reason (and that reason alone) I reintroduced WITH_ATF just for = Makefile.inc1 (but you could replace it with something else like = WITH_ATF_LIBS, etc, if the naming is too confusing). >>> Thanks! >>> -Garrett >>=20 >> I get that much, but what I don't understand is what direct affect >> WITH_ATF has. Did you forget to reintroduce a ".if defined(MK_ATF)" >> in some other file? >=20 > No, the purpose of WITH_ATF is to override NO_TESTS, so building the = ATF libs now has two conditions: >=20 > build_atf_libs =3D (is WITH_ATF defined?) && (is WITHOUT_TESTS = defined?) build_atf_libs =3D (is WITH_ATF defined?) && (is WITH_TESTS defined?) > versus one: >=20 > build_atf_libs =3D (is WITHOUT_TESTS defined?) build_atf_libs =3D (is WITH_TESTS defined?) > This allows us pepper NO_TESTS around and thus not build tests in the = build process unless they=92re _really_ needed (e.g. in make = everything).