From owner-freebsd-hackers@freebsd.org Fri Jun 1 14:41:05 2018 Return-Path: Delivered-To: freebsd-hackers@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id D71B4EF9106 for ; Fri, 1 Jun 2018 14:41:04 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: from mail-io0-x231.google.com (mail-io0-x231.google.com [IPv6:2607:f8b0:4001:c06::231]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 690257F44C for ; Fri, 1 Jun 2018 14:41:04 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: by mail-io0-x231.google.com with SMTP id l25-v6so7490385ioh.12 for ; Fri, 01 Jun 2018 07:41:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bsdimp-com.20150623.gappssmtp.com; s=20150623; h=mime-version:sender:in-reply-to:references:from:date:message-id :subject:to:cc; bh=8mAXWPjOGkuxFiOn2T4p1n3PRHVNrk3Pku96TWhTs5o=; b=mwXgUo42wEiquzUNkKRmloLMuNkbabHoYSI7F3iGao5Ky81xNhviWiCfzk/g/yqYp+ vmPbEPQqrk1D5K5BEL5fsGOT3Gjyy13Xou7zlQlvmwTaGwSnPDQe1H+k25vwEFgjG4xR SGg/X9YoJk5ltEZrbUYBejYMan2oo8gR2udeo1UyxyIezqpx+YnIm6dFfysTLLQaeuL8 t3QKHKcAvsVcpIEx7c1YbZNoRK/nFrvGc23rBxmFgdELs6eetOpsN/oAEfrf0SrEJFEJ sqn9Ni60BVdFCMLMfK1FKRetU1gHrvLndLPvgilKWm9JKSbuInTnz+bIa0mHm1PLm6QO 3m/g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:sender:in-reply-to:references:from :date:message-id:subject:to:cc; bh=8mAXWPjOGkuxFiOn2T4p1n3PRHVNrk3Pku96TWhTs5o=; b=PzCIgLNpamcd8tXcatMnqOlsEsB7VmfQNm013lneBvyUrXBRNJlFQFf6esRHUKQMVz 7pkGf3TuWC5Agd0HDVR/t2JkycJgklGi6VDYxl5wgZu3vb2taeA0UjP5LPQrwrLOcf3L znOF1f6mPg5e4y+Ik/CjjHL3Q/SMFXufyOYd9Jk1BOKBYPQxsrqNDbLESuBPSpoBoYtO 1uOf71DeqMCGTqexrVwY/UxWQzCviAt/Ps/0Mlygnq3WYWeGmqU4Dzy3CxSa2Y+5i15I 6VjYK4lt3NFlZrO3hCGNjJVU0Fl+178ZXLTvegtXuuQf87+aciWRKajJjUqYUS4Jj1ql GbdA== X-Gm-Message-State: ALKqPwcilgWcMiPqjTBHy+CK+wjhqg8hFLe7Fj9t+x6ZQ/UBwZ4jjR8y h3aXdChqzekB1Fg/dtxB7shbUqnuEnNgIdxC6Q/6ug== X-Google-Smtp-Source: ADUXVKLV6oieZon/2lm4u3pbbkknLndnT75EiVULW2nswuZ8niF2OLqWRZQu9OpKI/uac21yRGgSwj6sDK4fRfnxTBQ= X-Received: by 2002:a6b:284b:: with SMTP id o72-v6mr10757393ioo.168.1527864063489; Fri, 01 Jun 2018 07:41:03 -0700 (PDT) MIME-Version: 1.0 Sender: wlosh@bsdimp.com Received: by 2002:a4f:d028:0:0:0:0:0 with HTTP; Fri, 1 Jun 2018 07:41:02 -0700 (PDT) X-Originating-IP: [2603:300b:6:5100:1052:acc7:f9de:2b6d] In-Reply-To: References: <1407.1527801278@critter.freebsd.dk> From: Warner Losh Date: Fri, 1 Jun 2018 08:41:02 -0600 X-Google-Sender-Auth: eTBAlDljbpV68Rv9PanYsgtjVyc Message-ID: Subject: Re: PRs are being closed for bogus reasons :-( To: Bob Bishop Cc: Poul-Henning Kamp , "freebsd-hackers@freebsd.org" , Dieter BSD Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.26 X-BeenThere: freebsd-hackers@freebsd.org X-Mailman-Version: 2.1.26 Precedence: list List-Id: Technical Discussions relating to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 01 Jun 2018 14:41:05 -0000 On Fri, Jun 1, 2018 at 8:10 AM, Bob Bishop wrote: > Hi, > > > On 31 May 2018, at 22:14, Poul-Henning Kamp wrote: > > > > -------- > > In message mail.gmail.com> > > , Warner Losh writes: > > > >> There's a problem with the PR database: there's too many bugs. > > > > And despite the valiant efforts of a number of people over the > > lifetime of the project, it has always had so many bugs that > > everybody just threw their hands in the air and walked away. > > > > The way to improve the situation is to fix PR's, not to complain > > about PRs. > > Indeed. But look at the number of PRs with patches that are stuck in that > state. Not pretty. > Over the years I've committed dozens of PRs that had patches in them. The sad truth is that only about 10-15% of them have comitable patches in them when submitted. And that number decays over time as things age in bugzilla. I have approached things with enthusiasm 3 or 4 times over the years, only to be disappointed in how many I could actually commit, and how much work it took me to find those to commit. There's maybe another 30% that could be committed with less than an hour or two worth of work on them. Regardless of how good you think a fix is, there's the matter of regressions from these fixes. While people can point to really good patches stuck in PRs for a long time, I can point to lots of really bad ones. Separating out the wheat from the chaff is tedious, time consuming and not at all fun. The situation is a lot better these days since we have at least the start of a good regression suite we can use to proof changes (eg, did this tweak to awk break it, or fix it, or as I've discovered too many times, both... but we don't have a good regression suite for awk yet). Warner