Skip site navigation (1)Skip section navigation (2)
Date:      Fri, 28 May 2004 04:38:30 -0400 (EDT)
From:      Daniel Eischen <eischen@vigrid.com>
To:        Mike Makonnen <mtm@identd.net>
Cc:        cvs-all@FreeBSD.org
Subject:   Re: cvs commit: src/sys/sparc64/include atomic.h
Message-ID:  <Pine.GSO.4.10.10405280430560.14569-100000@pcnet5.pcnet.com>
In-Reply-To: <20040528082228.GA997@rogue.acs-et.com>

next in thread | previous in thread | raw e-mail | index | archive | help
On Fri, 28 May 2004, Mike Makonnen wrote:

> On Sat, May 22, 2004 at 02:58:06AM +0200, Marius Strobl wrote:
> > On Fri, May 21, 2004 at 05:52:16PM -0700, Marius Strobl wrote:
> > > marius      2004/05/21 17:52:16 PDT
> > > 
> > >   FreeBSD src repository
> > > 
> > >   Modified files:
> > >     sys/sparc64/include  atomic.h 
> > >   Log:
> > >   Use unsigned types for the arguments of the atomic(9) operations,
> > >   like described in the man page and done on all other architectures.
> > >   
> > 
> > This fixes the current build problems of libthr on sparc64 but the
> > libthr code shouldn't rely on the integer-type of enums.
> 
> Thanks. I'll change those enums to integers soon (others have suggested it
> as well). It's just that I find them so convenient when debugging.

And the use of atomic_cmpset_foo() isn't going to work on
80386 since it doesn't have cmpxchgl.  <machine/atomic.h>
will try to use cli instead.

-- 
Dan Eischen



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?Pine.GSO.4.10.10405280430560.14569-100000>