Date: Mon, 14 Apr 2014 15:49:37 -0700 (PDT) From: JMV <banshee@abattoir.com> To: FreeBSD-gnats-submit@freebsd.org Subject: ports/188635: port security/sshguard doesn't start without explicit pidfile Message-ID: <201404142249.s3EMnbxI017181@gabriella.abattoir.com> Resent-Message-ID: <201404142310.s3ENA0U0064202@freefall.freebsd.org>
next in thread | raw e-mail | index | archive | help
>Number: 188635
>Category: ports
>Synopsis: port security/sshguard doesn't start without explicit pidfile
>Confidential: no
>Severity: serious
>Priority: medium
>Responsible: freebsd-ports-bugs
>State: open
>Quarter:
>Keywords:
>Date-Required:
>Class: sw-bug
>Submitter-Id: current-users
>Arrival-Date: Mon Apr 14 23:10:00 UTC 2014
>Closed-Date:
>Last-Modified:
>Originator: JMV
>Release: FreeBSD 9.2-RELEASE-p4 amd64
>Organization:
just-another-unix-hacker
>Environment:
System: FreeBSD gabriella.abattoir.com 9.2-RELEASE-p4 FreeBSD 9.2-RELEASE-p4 #0: Tue Apr 8 18:08:22 UTC 2014 root@amd64-builder.daemonology.net:/usr/obj/usr/src/sys/GENERIC amd64
>Description:
/usr/local/etc/rc.d/sshguard silently fails to start if sshguard_pidfile is not defined in /etc/rc.conf because the start script refers to the wrong variable.
>How-To-Repeat:
Install security/sshguard
Ensure rc.conf contains sshguard_enable="YES"
Ensure rc.conf does not contain sshguard_pidfile
$ service sshguard start
Silently fails to start.
>Fix:
command_args="-cf ${actual_command} -b ${sshguard_blacklist} ${sshguard_watch_params} -a ${sshguard_safety_thresh} -p ${sshguard_pardon_min_interval} -s ${sshguard_prescribe_interval} -w ${sshguard_whitelistfile} -i ${sshguard_pidfile}"
should be
command_args="-cf ${actual_command} -b ${sshguard_blacklist} ${sshguard_watch_params} -a ${sshguard_safety_thresh} -p ${sshguard_pardon_min_interval} -s ${sshguard_prescribe_interval} -w ${sshguard_whitelistfile} -i ${pidfile}"
>Release-Note:
>Audit-Trail:
>Unformatted:
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201404142249.s3EMnbxI017181>