From owner-freebsd-hackers@FreeBSD.ORG Tue Nov 12 01:15:29 2013 Return-Path: Delivered-To: hackers@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 4D7B45B5; Tue, 12 Nov 2013 01:15:29 +0000 (UTC) Received: from land.berklix.org (land.berklix.org [144.76.10.75]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id CE4BB2EDF; Tue, 12 Nov 2013 01:07:27 +0000 (UTC) Received: from mart.js.berklix.net (p5DCBD0AE.dip0.t-ipconnect.de [93.203.208.174]) (authenticated bits=128) by land.berklix.org (8.14.5/8.14.5) with ESMTP id rAC17HOA040103; Tue, 12 Nov 2013 01:07:18 GMT (envelope-from jhs@berklix.com) Received: from fire.js.berklix.net (fire.js.berklix.net [192.168.91.41]) by mart.js.berklix.net (8.14.3/8.14.3) with ESMTP id rAC1760Z035250; Tue, 12 Nov 2013 02:07:06 +0100 (CET) (envelope-from jhs@berklix.com) Received: from fire.js.berklix.net (localhost.js.berklix.net [127.0.0.1]) by fire.js.berklix.net (8.14.4/8.14.4) with ESMTP id rAC16hUx066645; Tue, 12 Nov 2013 02:06:48 +0100 (CET) (envelope-from jhs@fire.js.berklix.net) Received: (from jhs@localhost) by fire.js.berklix.net (8.14.4/8.14.3/Submit) id rAC16BNC066644; Tue, 12 Nov 2013 02:06:11 +0100 (CET) (envelope-from jhs) Date: Tue, 12 Nov 2013 02:06:11 +0100 (CET) Message-Id: <201311120106.rAC16BNC066644@fire.js.berklix.net> To: FreeBSD-gnats-submit@freebsd.org, hackers@freebsd.org Subject: patch for /usr/src/usr.bin/fmt/ (not 8 bit clean) for German & French From: "Julian H. Stacey" In-reply-to: Your message "patch for /usr/src/usr.bin/fmt/ (not 8 bit clean) for German & French" Cc: "Bernhard Riedel \(Work\)" , Astrid Jekat , Christian Weisgerber X-BeenThere: freebsd-hackers@freebsd.org X-Mailman-Version: 2.1.16 Precedence: list Reply-To: "Julian H. Stacey" List-Id: Technical Discussions relating to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 12 Nov 2013 01:15:29 -0000 X-send-pr-version: 3.113 X-GNATS-Notify: >Submitter-Id: current-users >Originator: Julian H. Stacey >Organization: http://berklix.com BSD Linux Unix Consultancy, Munich/Muenchen. >Confidential: no >Synopsis: patch for /usr/src/usr.bin/fmt/ (not 8 bit clean) for German & French >Severity: non-critical >Priority: low >Category: bin >Class: change-request >Release: FreeBSD 10.0-BETA3 amd64 >Environment: System: FreeBSD fire.js.berklix.net 8.2-RELEASE FreeBSD 8.2-RELEASE #0: Mon Aug 20 18:20:09 CEST 2012 jhs@fire.js.berklix.net:/usr/src/sys/amd64/compile/FIRE64.small amd64 >Description: 2003 I looked at fmt.c to make it 8 bit clean for 4.8-RELEASE, I was conservative & my patches did just a subset, I recall. http://www.berklix.com/~jhs/src/bsd/fixes/FreeBSD/src/gen/usr.bin/fmt/ I maintained patches since. 2010 I posted to hackers@ Tue May 25 11:29:20 UTC 2010 http://lists.freebsd.org/pipermail/freebsd-hackers/2010-May/031901.html & got 1 comment: Christian's from Wed May 26 18:05:53 UTC 2010, http://lists.freebsd.org/pipermail/freebsd-hackers/2010-May/031927.html I'm still using & maintaining patches through to current & 10.0-BETA3, Tonight 2 BSD people (cc'd) asked I'd sent patches, so this also a send-pr. WRT Christian's comment from Wed May 26 18:05:53 UTC 2010, I don't know about ISO 8859-1 and UTF-8, (I dislike & avoid national char set stuff as much as possible), but I want to be able to edit files that simultaneously contain eg all of English German & French etc, so setting some var to eg just German would be inappropriate. 8 bit clean would be ideal, next best would be my patches I suppose. We no longer use 7 bit teletypes, & no longer need parity, so fmt.c could be made pretty much 8 bit clean, (apart from eg Null etc which'd doubtless be too much hastle). - Or it can be tweaked to allow some chars as I recall I did, Options presumably are still the 4 from Tue May 25 11:29:20 UTC 2010 http://lists.freebsd.org/pipermail/freebsd-hackers/2010-May/031901.html I assume either adopting Solution 1 (Discard "& 0x7f" ) or Solution 2 (my patches) would not disrupt locale users, but would stop fmt failing on some 8 bit text. >How-To-Repeat: Read the code >Fix: Look at my posting http://lists.freebsd.org/pipermail/freebsd-hackers/2010-May/031901.html & my patches http://www.berklix.com/~jhs/src/bsd/fixes/FreeBSD/src/gen/usr.bin/fmt/