From owner-freebsd-acpi@FreeBSD.ORG  Fri Jan 25 08:36:55 2013
Return-Path: <owner-freebsd-acpi@FreeBSD.ORG>
Delivered-To: freebsd-acpi@FreeBSD.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 by hub.freebsd.org (Postfix) with ESMTP id 4B927C48;
 Fri, 25 Jan 2013 08:36:55 +0000 (UTC) (envelope-from avg@FreeBSD.org)
Received: from citadel.icyb.net.ua (citadel.icyb.net.ua [212.40.38.140])
 by mx1.freebsd.org (Postfix) with ESMTP id 5EF1972D;
 Fri, 25 Jan 2013 08:36:53 +0000 (UTC)
Received: from porto.starpoint.kiev.ua (porto-e.starpoint.kiev.ua
 [212.40.38.100])
 by citadel.icyb.net.ua (8.8.8p3/ICyb-2.3exp) with ESMTP id KAA29603;
 Fri, 25 Jan 2013 10:36:52 +0200 (EET) (envelope-from avg@FreeBSD.org)
Received: from localhost ([127.0.0.1])
 by porto.starpoint.kiev.ua with esmtp (Exim 4.34 (FreeBSD))
 id 1TyemK-000F5q-G1; Fri, 25 Jan 2013 10:36:52 +0200
Message-ID: <51024423.5020306@FreeBSD.org>
Date: Fri, 25 Jan 2013 10:36:51 +0200
From: Andriy Gapon <avg@FreeBSD.org>
User-Agent: Mozilla/5.0 (X11; FreeBSD amd64;
 rv:17.0) Gecko/20130121 Thunderbird/17.0.2
MIME-Version: 1.0
To: Jung-uk Kim <jkim@FreeBSD.org>
Subject: Re: uma for acpi object cache
References: <20130122175629.GA1714@garage.freebsd.pl>
 <51008661.4060006@FreeBSD.org> <510101B4.4030409@FreeBSD.org>
 <51017D79.6060202@FreeBSD.org> <51018223.4030702@FreeBSD.org>
 <51019AAE.10501@FreeBSD.org>
In-Reply-To: <51019AAE.10501@FreeBSD.org>
X-Enigmail-Version: 1.4.6
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Cc: freebsd-acpi@FreeBSD.org
X-BeenThere: freebsd-acpi@freebsd.org
X-Mailman-Version: 2.1.14
Precedence: list
List-Id: ACPI and power management development <freebsd-acpi.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/freebsd-acpi>,
 <mailto:freebsd-acpi-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-acpi>
List-Post: <mailto:freebsd-acpi@freebsd.org>
List-Help: <mailto:freebsd-acpi-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-acpi>,
 <mailto:freebsd-acpi-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Fri, 25 Jan 2013 08:36:55 -0000

on 24/01/2013 22:33 Jung-uk Kim said the following:
> On 2013-01-24 13:49:07 -0500, Andriy Gapon wrote:
>> on 24/01/2013 20:29 Jung-uk Kim said the following:
>>> BTW, I tried something like that long ago.  In fact, the first
>>> attempt goes all the way back to this patch (warning: it's naive,
>>> broken, and overly complicated):
>>>
>>> http://people.freebsd.org/~jkim/acpica/OsdCache.diff
>>>
>>> I have more up-to-date and correct patch to use UMA but I'm still
>>> not 100% convinced whether we want to do it or not.
> 
>> Hmm, your patch looks a bit more complicated than mine. What is all
>> that extra stuff that you have there?
> 
> The main issue was AcpiOsPurgeCache().  For example, we didn't have
> anything like Linux's kmem_cache_shrink() at the time:
> 
> http://www.kernel.org/doc/htmldocs/kernel-api/API-kmem-cache-shrink.html
> 
> It seems you implemented that with zone_drain() but it wasn't
> available until this commit:
> 
> http://svnweb.freebsd.org/base?view=revision&revision=166213
> 
> Also, I had to make sure the cache is empty before we do
> uma_zdestroy(), so on and so forth.

OK, I see.  I don't think that any of that is really needed (now).
If you don't object I'll commit my variant in 1-2 weeks from now.

-- 
Andriy Gapon