Date: Wed, 23 Sep 2015 09:44:04 -0700 From: Conrad Meyer <cem@FreeBSD.org> To: Andriy Gapon <avg@freebsd.org> Cc: FreeBSD Current <freebsd-current@freebsd.org>, freebsd-rc@freebsd.org Subject: Re: dumpdev in loader.conf vs rc.d/dumpon Message-ID: <CAG6CVpXfBj_-cLj-8EMuAzgk6Ktmh_46e6zBBkZHMBxYW7=Cqg@mail.gmail.com> In-Reply-To: <5602CDBC.7080906@FreeBSD.org> References: <5602B922.20703@FreeBSD.org> <CAG6CVpVvStV1pUi8WEBS0T5PaHxFk_HxGi8ch-LXU_DiheyTGw@mail.gmail.com> <5602CDBC.7080906@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Wed, Sep 23, 2015 at 9:05 AM, Andriy Gapon <avg@freebsd.org> wrote: > On 23/09/2015 18:59, Conrad Meyer wrote: >> On Wed, Sep 23, 2015 at 7:37 AM, Andriy Gapon <avg@freebsd.org> wrote: > Because that's how I read the code in sys/geom/geom_dev.c. Especially > init_dumpdev() - I believe that devtoname() returns a device name without '/dev/'. I don't think that's the primary use of the variable. >> I don't see etc/rc.d/dumpon prepending /dev to anything. > > Right, that's why I posted my message (bug report). I think the use of the variable "dumpdev" in GEOM probably could/should be dropped. Alternatively (perhaps it is a mechanism for collecting crash dumps before init / /etc/rc start?) the GEOM dumpdev code could skip over a "/dev/" prefix when comparing against devname(), so that the GEOM use of the variable matches the etc/rc.d/dumpon use of the variable. Best, Conrad
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAG6CVpXfBj_-cLj-8EMuAzgk6Ktmh_46e6zBBkZHMBxYW7=Cqg>