From owner-freebsd-hackers Tue May 22 4:48:48 2001 Delivered-To: freebsd-hackers@freebsd.org Received: from meow.osd.bsdi.com (meow.osd.bsdi.com [204.216.28.88]) by hub.freebsd.org (Postfix) with ESMTP id 7788537B422; Tue, 22 May 2001 04:48:46 -0700 (PDT) (envelope-from jhb@FreeBSD.org) Received: from laptop.baldwin.cx (john@jhb-laptop.osd.bsdi.com [204.216.28.241]) by meow.osd.bsdi.com (8.11.2/8.11.2) with ESMTP id f4MBmeG58573; Tue, 22 May 2001 04:48:40 -0700 (PDT) (envelope-from jhb@FreeBSD.org) Message-ID: X-Mailer: XFMail 1.4.0 on FreeBSD X-Priority: 3 (Normal) Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 8bit MIME-Version: 1.0 In-Reply-To: <200105220501.f4M517P12040@earth.backplane.com> Date: Tue, 22 May 2001 04:48:39 -0700 (PDT) From: John Baldwin To: Matt Dillon Subject: Re: RE: vmspace leak (+ tentative fix) Cc: hackers@FreeBSD.org, "Brian F. Feldman" Sender: owner-freebsd-hackers@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG On 22-May-01 Matt Dillon wrote: >:Ok, then why not let the current shmexit() stay in exit1() as a hack to help >:free memory, but add in a check in vmspace_free() as well to catch any race >:conditions that may fall through the cracks? As long as we clear the shm >:pointer in struct vmspace when we free it then we won't be double free'ing, >:and >:will always free it eventually. That is also a much simpler change. :) >:Additionally, adding to the comment in exit1() clarifying that this is an >:attempt to free resources as soon as possible and that the race condition is >:known and that vmspace_free() is a catch-all might be nice as well. >: >:-- >: >:John Baldwin -- http://www.FreeBSD.org/~jhb/ >:PGP Key: http://www.baldwin.cx/~john/pgpkey.asc > > It's not really good programming practice. Someone might trip over > it later on. Then the vmspace free()ing is also bad programming practice? It's the same exact algorithm used for the vmspace. > -Matt -- John Baldwin -- http://www.FreeBSD.org/~jhb/ PGP Key: http://www.baldwin.cx/~john/pgpkey.asc "Power Users Use the Power to Serve!" - http://www.FreeBSD.org/ To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-hackers" in the body of the message