From owner-p4-projects@FreeBSD.ORG Fri Feb 1 04:46:51 2008 Return-Path: Delivered-To: p4-projects@freebsd.org Received: by hub.freebsd.org (Postfix, from userid 32767) id 6A03516A419; Fri, 1 Feb 2008 04:46:51 +0000 (UTC) Delivered-To: perforce@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 177AF16A417 for ; Fri, 1 Feb 2008 04:46:51 +0000 (UTC) (envelope-from imp@freebsd.org) Received: from repoman.freebsd.org (repoman.freebsd.org [IPv6:2001:4f8:fff6::29]) by mx1.freebsd.org (Postfix) with ESMTP id 0CC3A13C461 for ; Fri, 1 Feb 2008 04:46:51 +0000 (UTC) (envelope-from imp@freebsd.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.14.1/8.14.1) with ESMTP id m114ko4h056295 for ; Fri, 1 Feb 2008 04:46:50 GMT (envelope-from imp@freebsd.org) Received: (from perforce@localhost) by repoman.freebsd.org (8.14.1/8.14.1/Submit) id m114koOO056292 for perforce@freebsd.org; Fri, 1 Feb 2008 04:46:50 GMT (envelope-from imp@freebsd.org) Date: Fri, 1 Feb 2008 04:46:50 GMT Message-Id: <200802010446.m114koOO056292@repoman.freebsd.org> X-Authentication-Warning: repoman.freebsd.org: perforce set sender to imp@freebsd.org using -f From: Warner Losh To: Perforce Change Reviews Cc: Subject: PERFORCE change 134580 for review X-BeenThere: p4-projects@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: p4 projects tree changes List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 01 Feb 2008 04:46:51 -0000 http://perforce.freebsd.org/chv.cgi?CH=134580 Change 134580 by imp@imp_lighthouse on 2008/02/01 04:46:06 No need to bzero .bss. The boot loader already does this. There is a need to parse the boot loader's info that was inadvertantly removed from a prior version. Affected files ... .. //depot/projects/mips2-jnpr/src/sys/mips/mips32/octeon32/octeon_machdep.c#6 edit Differences ... ==== //depot/projects/mips2-jnpr/src/sys/mips/mips32/octeon32/octeon_machdep.c#6 (text+ko) ==== @@ -1024,9 +1024,8 @@ } -void mips_boot_params_init(void); - -void mips_boot_params_init (void) +static void +mips_boot_params_init(void) { int descriptor_not_parsed = 1; @@ -1249,17 +1248,16 @@ mips_platform_init(); - /* clear the BSS and SBSS segments */ + /* The boot loader clears the BSS and SBSS segments */ kernend = round_page((vm_offset_t)&end); - memset(&edata, 0, kernend - (vm_offset_t)(&edata)); - tick_early_init(OCTEON_CLOCK_DEFAULT); /* Quick Default. To avoid divide-by-0 * Later we will get it from * Bootloader/Rom-Mon */ cninit(); - printf(" Initialized memory: 0x%p to 0x%lX\n", &edata, ((long) &edata) + ((long)kernend - (long)(&edata))); + mips_boot_params_init(); + printf(" Initialized memory: 0x%p to 0x%lX\n", &edata, ((long) &edata) + ((long)kernend - (long)(&edata))); mips_init(); uint64_t platform_counter_freq = OCTEON_CLOCK_DEFAULT;