Date: Thu, 13 Sep 2012 22:11:58 +0200 From: Olli Hauer <ohauer@FreeBSD.org> To: "Philip M. Gollucci" <pgollucci@p6m7g8.com> Cc: Chris Rees <crees@FreeBSD.org>, Olli Hauer <ohauer@freebsd.org>, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org, ports-committers@freebsd.org Subject: Re: svn commit: r303982 - head/www/apache22 Message-ID: <50523E0E.1090402@FreeBSD.org> In-Reply-To: <CADLo83_W90DBGs7OXkdwXGX1zT1J365%2Bq2CQCNEYw2nQomEW3w@mail.gmail.com> References: <201209091701.q89H1UNl009740@svn.freebsd.org> <CACM2dAbyDNgqVxHSV7G=FCv6Egay9F8hM2km67g7OE4RUke4Og@mail.gmail.com> <CADLo83_W90DBGs7OXkdwXGX1zT1J365%2Bq2CQCNEYw2nQomEW3w@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On 2012-09-13 21:23, Chris Rees wrote:
> On 13 September 2012 02:46, Philip M. Gollucci <pgollucci@p6m7g8.com> wrote:
>> I don't know about this one. Why should apache ports specifically point you
>> at the wiki. The port system as a whole should do this, or every port
>> should (that would be a waste)
>> Please think about this some more.
>
> Normally I agree, and I think that general solutions are better.
> However, in this case, it's one of those very rare occasions that the
> WITH_ variables don't work correctly.
>
> The compatibility layer is good, but with something as complex as the
> Apache ports it apparently hasn't passed Olli's tests.
>
Funny, I miss the original mail ...
There is a regression with the command line parameters which works as follows.
In bsd.apache.mk we have to check if an option is set with this snippet
# OPTIONS handling
.for module in ${AVAILABLE_MODULES}
. if ${PORT_OPTIONS:M${module}}
_APACHE_MODULES+= ${module}
. else
WITHOUT_MODULES+= ${module}
. endif
.endfor
There is no place where we check for WITH/WITHOUT parameters.
If we replace this snippet wit a WITH/WITHOUT check then we fix the
options framework to not remove the line you read with the command
$> tail -n 15 /usr/ports/Mk/bsd.options.mk
After getting a lot of questions from users how the new options framework
is working and answering for two evenings only this questions I decide
to give all others a starting point so I can work maybe on the 24 port.
--
Regards,
olli
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?50523E0E.1090402>