Date: Sat, 20 May 2023 22:35:42 +0000 From: bugzilla-noreply@freebsd.org To: ports-bugs@FreeBSD.org Subject: [Bug 269566] New port: lang/mlkit Message-ID: <bug-269566-7788-pgM8D7W9Dd@https.bugs.freebsd.org/bugzilla/> In-Reply-To: <bug-269566-7788@https.bugs.freebsd.org/bugzilla/> References: <bug-269566-7788@https.bugs.freebsd.org/bugzilla/>
next in thread | previous in thread | raw e-mail | index | archive | help
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D269566 Daniel Engberg <diizzy@FreeBSD.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |diizzy@FreeBSD.org --- Comment #7 from Daniel Engberg <diizzy@FreeBSD.org> --- Hi, Looks good overall, you don't need to wrap TEST_TARGET and as Robert mentio= ned if "make test" doesn't "need" any functionality from the framework you don't need to make it an option. While cosmetic you possibly want to push version data to the build, prefera= bly so it's reproducable looking at https://github.com/melsman/mlkit/blob/master/configure.ac#L48 . These varia= bles might also be used to generate version data in the binaries. In general we don't want to depend on git for building. While I guess it's preference USES=3D shebangfix uses full path so I think = it's fine for consistency however it should use LOCALBASE and not PREFIX. Best regards, Daniel --=20 You are receiving this mail because: You are the assignee for the bug.=
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?bug-269566-7788-pgM8D7W9Dd>