From owner-freebsd-hackers@FreeBSD.ORG Wed Apr 23 12:03:49 2008 Return-Path: Delivered-To: hackers@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id D2199106564A for ; Wed, 23 Apr 2008 12:03:49 +0000 (UTC) (envelope-from kostikbel@gmail.com) Received: from relay01.kiev.sovam.com (relay01.kiev.sovam.com [62.64.120.200]) by mx1.freebsd.org (Postfix) with ESMTP id 591478FC14 for ; Wed, 23 Apr 2008 12:03:49 +0000 (UTC) (envelope-from kostikbel@gmail.com) Received: from [212.82.216.226] (helo=skuns.kiev.zoral.com.ua) by relay01.kiev.sovam.com with esmtps (TLSv1:AES256-SHA:256) (Exim 4.67) (envelope-from ) id 1JocrG-000CC4-1i for hackers@freebsd.org; Wed, 23 Apr 2008 14:09:50 +0300 Received: from deviant.kiev.zoral.com.ua (root@deviant.kiev.zoral.com.ua [10.1.1.148]) by skuns.kiev.zoral.com.ua (8.14.2/8.14.2) with ESMTP id m3NB9nbX022639 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Wed, 23 Apr 2008 14:09:49 +0300 (EEST) (envelope-from kostikbel@gmail.com) Received: from deviant.kiev.zoral.com.ua (kostik@localhost [127.0.0.1]) by deviant.kiev.zoral.com.ua (8.14.2/8.14.2) with ESMTP id m3NB9hj8060988; Wed, 23 Apr 2008 14:09:43 +0300 (EEST) (envelope-from kostikbel@gmail.com) Received: (from kostik@localhost) by deviant.kiev.zoral.com.ua (8.14.2/8.14.2/Submit) id m3NB9gWA060978; Wed, 23 Apr 2008 14:09:42 +0300 (EEST) (envelope-from kostikbel@gmail.com) X-Authentication-Warning: deviant.kiev.zoral.com.ua: kostik set sender to kostikbel@gmail.com using -f Date: Wed, 23 Apr 2008 14:09:42 +0300 From: Kostik Belousov To: Garrett Cooper Message-ID: <20080423110942.GU18958@deviant.kiev.zoral.com.ua> References: <7d6fde3d0804222240j6b42b77yd86d8accb5a959fa@mail.gmail.com> <20080423025048.6b51a580@bhuda.mired.org> <5F412E73-29FC-4876-A6F0-9BC269876192@bitpowder.com> <7d6fde3d0804230219x209bd707u30150581abc74802@mail.gmail.com> <7d6fde3d0804230219q13d204f2wda4a5f271b9a0e66@mail.gmail.com> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="dicp5grlxus9uUnk" Content-Disposition: inline In-Reply-To: <7d6fde3d0804230219q13d204f2wda4a5f271b9a0e66@mail.gmail.com> User-Agent: Mutt/1.4.2.3i X-Virus-Scanned: ClamAV version 0.91.2, clamav-milter version 0.91.2 on skuns.kiev.zoral.com.ua X-Virus-Status: Clean X-Spam-Status: No, score=-4.4 required=5.0 tests=ALL_TRUSTED,AWL,BAYES_00 autolearn=ham version=3.2.4 X-Spam-Checker-Version: SpamAssassin 3.2.4 (2008-01-01) on skuns.kiev.zoral.com.ua X-Scanner-Signature: 0a40947aa5a9674afbdd30b0de777e4b X-DrWeb-checked: yes X-SpamTest-Envelope-From: kostikbel@gmail.com X-SpamTest-Group-ID: 00000000 X-SpamTest-Header: Not Detected X-SpamTest-Info: Profiles 2695 [Apr 23 2008] X-SpamTest-Info: helo_type=3 X-SpamTest-Method: none X-SpamTest-Rate: 0 X-SpamTest-Status: Not detected X-SpamTest-Status-Extended: not_detected X-SpamTest-Version: SMTP-Filter Version 3.0.0 [0278], KAS30/Release Cc: hackers@freebsd.org Subject: Re: Fwd: strdup(NULL) supposed to create SIGSEGV? X-BeenThere: freebsd-hackers@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Technical Discussions relating to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 23 Apr 2008 12:03:49 -0000 --dicp5grlxus9uUnk Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, Apr 23, 2008 at 02:19:53AM -0700, Garrett Cooper wrote: > On Wed, Apr 23, 2008 at 1:30 AM, Bernard van Gastel > wrote: >=20 > > > > Op 23 apr 2008, om 08:50 heeft Mike Meyer het volgende geschreven: > > > > > On Tue, 22 Apr 2008 22:40:21 -0700 > > > "Garrett Cooper" wrote: > > > > > > Hi all, > > > > I made an oops in a program, which uncovered "feature" in strdup= (2) > > > > that I wasn't aware of before. So I was wondering, is strdup(pointe= r =3D > > > > NULL) > > > > supposed to segfault should this just return NULL and set errno? > > > > > > > > > > Yes, it's supposed to segfault. Check out what, say, strcpy does if > > > you ask it to copy a NULL pointer. And this is an improvement from the > > > bad old days, when they would happily walk through memory starting at > > > 0..... > > > > > > > I don't like it this way. I would like: > > > > strdup(NULL) =3D NULL > > strdup(string) =3D copy of string > > > > strcpy(NULL, NULL) =3D NULL > > strcpy(s1, NULL) =3D ERROR > > strcpy(NULL, s2) =3D NULL (with s2 unchanged) > > strcpy(s1, s2) =3D normal > > > > But I am not sure of the implications. Maybe in some situation it is > > bad... Anyone? > > > > > > > Besides, errno is used to signal errors from system calls. strdup > > > isn't a system call, it's a library function (says so at the top of > > > the man page). > > > > > > > But strdup uses malloc, which is a system call (from the strdup manual:= If > > insufficient memory is available, NULL is returned and errno is set to > > ENOMEM.) > > > > Regards, > > Bernard > > > > > I was more concerned about the fact that there wasn't any documentation t= hat > said something -- either implicitly or explicitly -- that strdup(NULL) > causes a segfault. >=20 > Of course I did some more research after you guys gave me some replies and > realized I'm not the first person to bumble across this fact, but I haven= 't > found FreeBSD or Linux documentation supporting that errata. It was harml= ess > in my tiny program, but I would hate to be someone adding that assumption= to > a larger project with multiple threads and a fair number of lines... >=20 > *shrugs*. >=20 > -Garrett >=20 > PS I'm as much against POLA changes as the next guy. I just don't like > shooting myself in the foot too terribly much :). =46rom the ISO/IEC 9899:1999 (E), 7.1.4, clause 1 Each of the following statements applies unless explicitly stated otherwise in the detailed descriptions that follow: If an argument to a function has an invalid value (such as a value outside the domain of the function, or a pointer outside the address space of the program, or a null pointer, or a pointer to non-modifiable storage when the corresponding parameter is not const-qualified) or a type (after promotion) not expected by a function with variable number of arguments, the behavior is undefined. --dicp5grlxus9uUnk Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.8 (FreeBSD) iEYEARECAAYFAkgPGPYACgkQC3+MBN1Mb4jiQgCg209XplMxDf7aeX+OluO/u3WA M6IAn3aRbycSlXZMNMuSh0LiC9TS2M1D =F942 -----END PGP SIGNATURE----- --dicp5grlxus9uUnk--