From owner-freebsd-bugs@freebsd.org Thu Mar 8 04:27:02 2018 Return-Path: Delivered-To: freebsd-bugs@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id A78DEF2FA50 for ; Thu, 8 Mar 2018 04:27:02 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.ysv.freebsd.org (mxrelay.ysv.freebsd.org [IPv6:2001:1900:2254:206a::19:3]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "mxrelay.ysv.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 45E8483620 for ; Thu, 8 Mar 2018 04:27:02 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2001:1900:2254:206a::16:76]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mxrelay.ysv.freebsd.org (Postfix) with ESMTPS id 8BB991DFAE for ; Thu, 8 Mar 2018 04:27:01 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.118]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id w284R14X058301 for ; Thu, 8 Mar 2018 04:27:01 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from www@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id w284R1wR058300 for freebsd-bugs@FreeBSD.org; Thu, 8 Mar 2018 04:27:01 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: www set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: freebsd-bugs@FreeBSD.org Subject: [Bug 226429] ipfw table add & hostname parsing Date: Thu, 08 Mar 2018 04:27:01 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: kern X-Bugzilla-Version: 11.1-RELEASE X-Bugzilla-Keywords: X-Bugzilla-Severity: Affects Only Me X-Bugzilla-Who: cem@freebsd.org X-Bugzilla-Status: New X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: freebsd-bugs@FreeBSD.org X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: freebsd-bugs@freebsd.org X-Mailman-Version: 2.1.25 Precedence: list List-Id: Bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 08 Mar 2018 04:27:02 -0000 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D226429 --- Comment #2 from Conrad Meyer --- I suggest this untested patch to correct the issue (and a similar issue with legacy table values): --- sbin/ipfw/tables.c (revision 330627) +++ sbin/ipfw/tables.c (working copy) @@ -1471,6 +1471,7 @@ uint32_t i; int dval; char *comma, *e, *etype, *n, *p; + struct in_addr ipaddr; v =3D &tent->v.value; @@ -1487,8 +1488,8 @@ return; } /* Try hostname */ - if (lookup_host(arg, (struct in_addr *)&val) =3D=3D 0) { - set_legacy_value(val, v); + if (lookup_host(arg, &ipaddr) =3D=3D 0) { + set_legacy_value(ntohl(ipaddr.s_addr), v); return; } errx(EX_OSERR, "Unable to parse value %s", arg); @@ -1557,8 +1558,10 @@ v->nh4 =3D ntohl(a4); break; } - if (lookup_host(n, (struct in_addr *)&v->nh4) =3D= =3D 0) + if (lookup_host(n, &ipaddr) =3D=3D 0) { + v->nh4 =3D ntohl(ipaddr.s_addr); break; + } etype =3D "ipv4"; break; case IPFW_VTYPE_DSCP: Maybe you can try it out? --=20 You are receiving this mail because: You are the assignee for the bug.=