Date: Wed, 8 Dec 2021 18:48:42 +0100 From: Stefan Esser <se@freebsd.org> To: John Baldwin <jhb@FreeBSD.org> Cc: jbtakk@iherebuywisely.com, Tomoaki AOKI <junchoon@dec.sakura.ne.jp>, freebsd-current@freebsd.org Subject: Re: Make etcupdate bootstrap requirement due to previous mergemaster usage more clear in handbook Message-ID: <3acc005b-12c2-b847-0f35-b95ee9b7e98a@freebsd.org> In-Reply-To: <98af77aa-628d-5fce-7618-36b1edaa405b@FreeBSD.org> References: <56a60a9b-3d7f-b29e-6074-71078f4b0fe6@quip.cz> <E1mt91J-0002Cl-Sx@rmmprod07.runbox> <20211204110942.11553b693b165364f3ab31c0@dec.sakura.ne.jp> <98af77aa-628d-5fce-7618-36b1edaa405b@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --------------0WHj4RgK0ykHdptbyV7JH0O0 Content-Type: multipart/mixed; boundary="------------uTJVBp0DbvLjAv026g8xP7Oy"; protected-headers="v1" From: Stefan Esser <se@freebsd.org> To: John Baldwin <jhb@FreeBSD.org> Cc: jbtakk@iherebuywisely.com, Tomoaki AOKI <junchoon@dec.sakura.ne.jp>, freebsd-current@freebsd.org Message-ID: <3acc005b-12c2-b847-0f35-b95ee9b7e98a@freebsd.org> Subject: Re: Make etcupdate bootstrap requirement due to previous mergemaster usage more clear in handbook References: <56a60a9b-3d7f-b29e-6074-71078f4b0fe6@quip.cz> <E1mt91J-0002Cl-Sx@rmmprod07.runbox> <20211204110942.11553b693b165364f3ab31c0@dec.sakura.ne.jp> <98af77aa-628d-5fce-7618-36b1edaa405b@FreeBSD.org> In-Reply-To: <98af77aa-628d-5fce-7618-36b1edaa405b@FreeBSD.org> --------------uTJVBp0DbvLjAv026g8xP7Oy Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Am 08.12.21 um 18:11 schrieb John Baldwin: > So the new changes always build a temporary tree (vs trying to build > /var/db/etupdate/current in place).=C2=A0 For -n it should be that it j= ust > doesn't change /var/db/etcupdate/current at the end, but if it did the > move anyway that would explain the bug you are seeing.=C2=A0 That does = indeed > look broken.=C2=A0 Please file a PR as a reminder for me to fix it. If you work on this then please have a look at PR 247519, too: https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D247519 This problem lead to my complete customized /etc getting lost when I invoked etcupdate with WITH_DIRDEPS_BUILD defined in /etc/src-env.conf. But I can imagine other reasons that let the make commands in build_tree(= ) fail without error exit, leading to an empty etcupdate/current tree and subsequent deletion of files in /etc. Regards, STefan --------------uTJVBp0DbvLjAv026g8xP7Oy-- --------------0WHj4RgK0ykHdptbyV7JH0O0 Content-Type: application/pgp-signature; name="OpenPGP_signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="OpenPGP_signature" -----BEGIN PGP SIGNATURE----- wsB5BAABCAAjFiEEo3HqZZwL7MgrcVMTR+u171r99UQFAmGw7/oFAwAAAAAACgkQR+u171r99UQA 9wf/U/ZcnQ+apX6zJXiaqLfOVjiAgNf/R1oYngXILar609q1F/N1Ps/tShQnK1lwNyGjZgPd2pCQ bkUrbeyv1/CPWQTfaiCBzoIo4FWyuVqADrgH7+OX2PjXlctzsoH4sFylwXtDirU2LVPD8YQuXefL 64I14rMM4OxZ38G0S50L2kk4UOcwdqrfIve7KCYGZKbOAb/JAUpUHPGAnStT2kScUXnsXiu9T3bV WEv1eA7tds0koeqfMDujK1RFzMPQQtwtoxPgIfqcsKlyowWnKaw21N8MMXV+If4MXv9E0dWT3ksF 0I5RhnGK1Va53t7LrF77TuOBzutY+wKRdBkf6FVb3w== =cdEP -----END PGP SIGNATURE----- --------------0WHj4RgK0ykHdptbyV7JH0O0--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?3acc005b-12c2-b847-0f35-b95ee9b7e98a>