From owner-freebsd-bugs@FreeBSD.ORG  Sat May 11 13:20:00 2013
Return-Path: <owner-freebsd-bugs@FreeBSD.ORG>
Delivered-To: freebsd-bugs@smarthost.ysv.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 by hub.freebsd.org (Postfix) with ESMTP id B659AE93
 for <freebsd-bugs@smarthost.ysv.freebsd.org>;
 Sat, 11 May 2013 13:20:00 +0000 (UTC)
 (envelope-from gnats@FreeBSD.org)
Received: from freefall.freebsd.org (freefall.freebsd.org
 [IPv6:2001:1900:2254:206c::16:87])
 by mx1.freebsd.org (Postfix) with ESMTP id 8315983A
 for <freebsd-bugs@smarthost.ysv.freebsd.org>;
 Sat, 11 May 2013 13:20:00 +0000 (UTC)
Received: from freefall.freebsd.org (localhost [127.0.0.1])
 by freefall.freebsd.org (8.14.7/8.14.7) with ESMTP id r4BDK0Rn012590
 for <freebsd-bugs@freefall.freebsd.org>; Sat, 11 May 2013 13:20:00 GMT
 (envelope-from gnats@freefall.freebsd.org)
Received: (from gnats@localhost)
 by freefall.freebsd.org (8.14.7/8.14.7/Submit) id r4BDK0G8012589;
 Sat, 11 May 2013 13:20:00 GMT (envelope-from gnats)
Resent-Date: Sat, 11 May 2013 13:20:00 GMT
Resent-Message-Id: <201305111320.r4BDK0G8012589@freefall.freebsd.org>
Resent-From: FreeBSD-gnats-submit@FreeBSD.org (GNATS Filer)
Resent-To: freebsd-bugs@FreeBSD.org
Resent-Reply-To: FreeBSD-gnats-submit@FreeBSD.org,
 Gordon Shumway <freeserif@yahoo.com>
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 by hub.freebsd.org (Postfix) with ESMTP id E0EFEBA0
 for <freebsd-gnats-submit@FreeBSD.org>; Sat, 11 May 2013 13:11:06 +0000 (UTC)
 (envelope-from nobody@FreeBSD.org)
Received: from oldred.FreeBSD.org (oldred.freebsd.org [8.8.178.121])
 by mx1.freebsd.org (Postfix) with ESMTP id D24AD80B
 for <freebsd-gnats-submit@FreeBSD.org>; Sat, 11 May 2013 13:11:06 +0000 (UTC)
Received: from oldred.FreeBSD.org ([127.0.1.6])
 by oldred.FreeBSD.org (8.14.5/8.14.5) with ESMTP id r4BDB6Pe020153
 for <freebsd-gnats-submit@FreeBSD.org>; Sat, 11 May 2013 13:11:06 GMT
 (envelope-from nobody@oldred.FreeBSD.org)
Received: (from nobody@localhost)
 by oldred.FreeBSD.org (8.14.5/8.14.5/Submit) id r4BDB6DA020152;
 Sat, 11 May 2013 13:11:06 GMT (envelope-from nobody)
Message-Id: <201305111311.r4BDB6DA020152@oldred.FreeBSD.org>
Date: Sat, 11 May 2013 13:11:06 GMT
From: Gordon Shumway <freeserif@yahoo.com>
To: freebsd-gnats-submit@FreeBSD.org
X-Send-Pr-Version: www-3.1
Subject: misc/178507: Comment bug in src/lib/libradius/radlib.h
X-BeenThere: freebsd-bugs@freebsd.org
X-Mailman-Version: 2.1.14
Precedence: list
List-Id: Bug reports <freebsd-bugs.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/freebsd-bugs>,
 <mailto:freebsd-bugs-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-bugs>
List-Post: <mailto:freebsd-bugs@freebsd.org>
List-Help: <mailto:freebsd-bugs-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-bugs>,
 <mailto:freebsd-bugs-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sat, 11 May 2013 13:20:00 -0000


>Number:         178507
>Category:       misc
>Synopsis:       Comment bug in src/lib/libradius/radlib.h
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    freebsd-bugs
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Sat May 11 13:20:00 UTC 2013
>Closed-Date:
>Last-Modified:
>Originator:     Gordon Shumway
>Release:        9.1
>Organization:
>Environment:
FreeBSD localhost.localdomain 9.1-RELEASE-p3 FreeBSD 9.1-RELEASE-p3 #11 r250120: Wed May  1 00:17:23 CEST 2013     root@localhost.localdomain:/usr/obj/usr/src/sys/DTRACE  amd64
>Description:
$ grep NAS_IDENTIFIER lib/libradius/radlib.h 
#define RAD_NAS_IDENTIFIER              32      /* Integer */


According to http://www.dialogic.com/webhelp/BorderNet2020/1.1.0/WebHelp/radatt_nasidentifier.htm and other sources, NAS-Identifier is a string.
>How-To-Repeat:
n/a
>Fix:
sed -i '' '/NAS_IDENTIFIER/s/Integer/String/' lib/libradius/radlib.h

>Release-Note:
>Audit-Trail:
>Unformatted: