From owner-svn-src-all@FreeBSD.ORG Fri Oct 17 01:53:47 2014 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 39277A76; Fri, 17 Oct 2014 01:53:47 +0000 (UTC) Received: from mail-lb0-x22e.google.com (mail-lb0-x22e.google.com [IPv6:2a00:1450:4010:c04::22e]) (using TLSv1 with cipher ECDHE-RSA-RC4-SHA (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 30CD9E73; Fri, 17 Oct 2014 01:53:46 +0000 (UTC) Received: by mail-lb0-f174.google.com with SMTP id p9so3751831lbv.5 for ; Thu, 16 Oct 2014 18:53:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:sender:in-reply-to:references:date:message-id:subject :from:to:cc:content-type:content-transfer-encoding; bh=cXNhX9lwELXbo+s+ytq8yQZ4urMjGMR/UckoReRdp/c=; b=EmOedhMdo2tUtzmCrQd1uQ1/Y7nAnOMZoUV1VP716WT7fAMEbUYKgHyGaA0tWmO9Nh VH/x8jZj7c04bq2qmIUsYSSRHlpdv6T0Q61YNb/iqFHYPHdItus22MRg5strsuaQdz3x As6jpkzanmXQPHMiRjdlWN4CFMf5J8VbPdLqTjn0cr84P8E1C/yw8nxo5XTg04QhbLKZ OaptliJq9XZZSYQziK+NF3S7OFkje8z6jvNyj5Wa6gYLUlEU7NwvhZYBr/cSFxprr/lV UTahJKV+oxJc+SN7TmqrogA6v7KhAu+r9XovpfxfALG4ouVqyILZQV4KpqnnxIMChU7B Duiw== MIME-Version: 1.0 X-Received: by 10.153.11.133 with SMTP id ei5mr5292917lad.75.1413510824163; Thu, 16 Oct 2014 18:53:44 -0700 (PDT) Sender: davide.italiano@gmail.com Received: by 10.25.170.4 with HTTP; Thu, 16 Oct 2014 18:53:44 -0700 (PDT) In-Reply-To: References: <201410161804.s9GI4hed091471@svn.freebsd.org> Date: Thu, 16 Oct 2014 18:53:44 -0700 X-Google-Sender-Auth: Qv-ZWvx3mNZwfZZMYLGWQ0BS314 Message-ID: Subject: Re: svn commit: r273174 - in head/sys: amd64/amd64 amd64/vmm arm/arm cam/ata cddl/contrib/opensolaris/uts/common/dtrace dev/acpica dev/asmc dev/cfi dev/drm2 dev/hatm dev/mii dev/nfe dev/patm dev/pci de... From: Davide Italiano To: "Bjoern A. Zeeb" Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Cc: "svn-src-head@freebsd.org" , "svn-src-all@freebsd.org" , "src-committers@freebsd.org" X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 17 Oct 2014 01:53:47 -0000 On Thu, Oct 16, 2014 at 4:44 PM, Bjoern A. Zeeb wrote: > > On 16 Oct 2014, at 18:04 , Davide Italiano wrote: > >> Author: davide >> Date: Thu Oct 16 18:04:43 2014 >> New Revision: 273174 >> URL: https://svnweb.freebsd.org/changeset/base/273174 >> >> Log: >> Follow up to r225617. In order to maximize the re-usability of kernel c= ode >> in userland rename in-kernel getenv()/setenv() to kern_setenv()/kern_ge= tenv(). >> This fixes a namespace collision with libc symbols. >> >> Submitted by: kmacy >> Tested by: make universe > > Hmm I still see a lot of mips kernels broken with > > /scratch/tmp/bz/head.svn/sys/mips/rmi/xlr_machdep.c: In function 'platfor= m_start': > /scratch/tmp/bz/head.svn/sys/mips/rmi/xlr_machdep.c:461: warning: implici= t declaration of function 'setenv' > /scratch/tmp/bz/head.svn/sys/mips/rmi/xlr_machdep.c:461: warning: nested = extern declaration of =E2=80=98setenv=E2=80=99 [-Wnested-externs] > > on my incremental builds. > > =E2=80=94 > Bjoern A. Zeeb "Come on. Learn, goddamn it.", WarGames, 1983 > Hi, I think you're right and I apologize for the breakage (apparently I didn't look at all the log files properly). Can you tell me if this fixes for you: https://people.freebsd.org/~davide/patches/kernsetenv_fixup.diff ? If yes, I'll commit. BTW, it would be cool if universe will put logs of successful builds and logs of failed builds in different directories for easier inspection. If there's already something like this and you can point me to that, it would be appreciated. --=20 Davide "There are no solved problems; there are only problems that are more or less solved" -- Henri Poincare