Date: Sun, 14 Jan 2018 16:45:51 +0000 From: Alexey Dokuchaev <danfe@FreeBSD.org> To: Muhammad Moinur Rahman <bofh@FreeBSD.org> Cc: ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Subject: Re: svn commit: r458926 - head/java/java-checkstyle Message-ID: <20180114164551.GA85642@FreeBSD.org> In-Reply-To: <201801131125.w0DBPeqW003703@repo.freebsd.org> References: <201801131125.w0DBPeqW003703@repo.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Sat, Jan 13, 2018 at 11:25:40AM +0000, Muhammad Moinur Rahman wrote: > New Revision: 458926 > URL: https://svnweb.freebsd.org/changeset/ports/458926 > > Log: > java/java-checkstyle: Update version 7.6=>8.7 > > - Pet PORTLINT > > Added: > head/java/java-checkstyle/pkg-plist (contents, props changed) > > Modified: head/java/java-checkstyle/Makefile > ... > @@ -21,8 +21,6 @@ WRKSRC= ${WRKDIR}/${PORTNAME}-${PORTVERSION} > > JAR_FILE= ${PORTNAME}-${PORTVERSION}-all.jar > > -PLIST_FILES= bin/${PORTNAME} \ > - %%JAVAJARDIR%%/${PORTNAME}.jar > > Added: head/java/java-checkstyle/pkg-plist > ... > @@ -0,0 +1,2 @@ > +bin/checkstyle > +%%JAVAJARDIR%%/checkstyle.jar I don't get it: we typically use PLIST_FILES for short PLISTs, why not simply fix (expand) %%JAVAJARDIR%% and retain PLIST_FILES instead of creating two-line pkg-plist? ./danfe
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20180114164551.GA85642>