From owner-cvs-all@FreeBSD.ORG  Sat Apr 15 16:06:35 2006
Return-Path: <owner-cvs-all@FreeBSD.ORG>
X-Original-To: cvs-all@FreeBSD.org
Delivered-To: cvs-all@FreeBSD.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id DEAD616A405;
	Sat, 15 Apr 2006 16:06:35 +0000 (UTC)
	(envelope-from scottl@samsco.org)
Received: from pooker.samsco.org (pooker.samsco.org [168.103.85.57])
	by mx1.FreeBSD.org (Postfix) with ESMTP id 14E8943D77;
	Sat, 15 Apr 2006 16:06:26 +0000 (GMT)
	(envelope-from scottl@samsco.org)
Received: from [192.168.254.11] (junior.samsco.home [192.168.254.11])
	(authenticated bits=0)
	by pooker.samsco.org (8.13.4/8.13.4) with ESMTP id k3FG6OX7077490;
	Sat, 15 Apr 2006 10:06:24 -0600 (MDT)
	(envelope-from scottl@samsco.org)
Message-ID: <44411A01.1030305@samsco.org>
Date: Sat, 15 Apr 2006 10:06:25 -0600
From: Scott Long <scottl@samsco.org>
User-Agent: Mozilla/5.0 (X11; U; FreeBSD i386; en-US; rv:1.7.12) Gecko/20051230
X-Accept-Language: en-us, en
MIME-Version: 1.0
To: Oleg Bulyzhin <oleg@FreeBSD.org>
References: <200604150813.k3F8D8Uo014854@repoman.freebsd.org>
	<20060415102742.GA69882@lath.rinet.ru>
In-Reply-To: <20060415102742.GA69882@lath.rinet.ru>
Content-Type: text/plain; charset=us-ascii; format=flowed
Content-Transfer-Encoding: 7bit
X-Spam-Status: No, score=-1.4 required=3.8 tests=ALL_TRUSTED autolearn=failed 
	version=3.1.1
X-Spam-Checker-Version: SpamAssassin 3.1.1 (2006-03-10) on pooker.samsco.org
Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org,
	Scott Long <scottl@FreeBSD.org>, cvs-all@FreeBSD.org
Subject: Re: cvs commit: src/sys/dev/bge if_bge.c
X-BeenThere: cvs-all@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: CVS commit messages for the entire tree <cvs-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-all>,
	<mailto:cvs-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/cvs-all>
List-Post: <mailto:cvs-all@freebsd.org>
List-Help: <mailto:cvs-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-all>,
	<mailto:cvs-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sat, 15 Apr 2006 16:06:36 -0000

Oleg Bulyzhin wrote:
> On Sat, Apr 15, 2006 at 08:13:07AM +0000, Scott Long wrote:
> 
>>scottl      2006-04-15 08:13:07 UTC
>>
>>  FreeBSD src repository
>>
>>  Modified files:
>>    sys/dev/bge          if_bge.c 
>>  Log:
>>  Fix the interrupt handler to do the mandatory PCI flush before looking at
>>  DMA memory.  The could contribute towards missed link state changes under
>>  heavy bus load.
>>  
>>  Revision  Changes    Path
>>  1.126     +10 -14    src/sys/dev/bge/if_bge.c
> 
> 
> Should not we do the same for polling case?
> 

No, because there is no race with the interrupt signal when you're
polling.  The data is in host memory or it isn't, and doing a bus
flush on every loop would be highly counter productive.

Scott