From owner-svn-src-all@FreeBSD.ORG Thu Aug 7 21:56:33 2014 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 2BD27906 for ; Thu, 7 Aug 2014 21:56:33 +0000 (UTC) Received: from svn.freebsd.org (svn.freebsd.org [IPv6:2001:1900:2254:2068::e6a:0]) (using TLSv1 with cipher ECDHE-RSA-AES256-SHA (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 0217C2C87 for ; Thu, 7 Aug 2014 21:56:33 +0000 (UTC) Received: from imp (uid 547) (envelope-from imp@FreeBSD.org) id 2904 by svn.freebsd.org (DragonFly Mail Agent v0.9+); Thu, 07 Aug 2014 21:56:32 +0000 From: Warner Losh Date: Thu, 7 Aug 2014 21:56:32 +0000 (UTC) To: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: svn commit: r269690 - head/sys/dev/esp X-SVN-Group: head MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Message-Id: <53e3f610.2904.4c46763e@svn.freebsd.org> X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 07 Aug 2014 21:56:33 -0000 Author: imp Date: Thu Aug 7 21:56:32 2014 New Revision: 269690 URL: http://svnweb.freebsd.org/changeset/base/269690 Log: target is unsigned, so don't compare it < 0 for range test. Modified: head/sys/dev/esp/ncr53c9x.c Modified: head/sys/dev/esp/ncr53c9x.c ============================================================================== --- head/sys/dev/esp/ncr53c9x.c Thu Aug 7 21:37:31 2014 (r269689) +++ head/sys/dev/esp/ncr53c9x.c Thu Aug 7 21:56:32 2014 (r269690) @@ -1082,8 +1082,7 @@ ncr53c9x_action(struct cam_sim *sim, uni case XPT_RESET_DEV: case XPT_SCSI_IO: - if (ccb->ccb_h.target_id < 0 || - ccb->ccb_h.target_id >= sc->sc_ntarg) { + if (ccb->ccb_h.target_id >= sc->sc_ntarg) { ccb->ccb_h.status = CAM_PATH_INVALID; goto done; }