From owner-svn-src-all@freebsd.org Wed Dec 20 03:56:52 2017 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id B3220E90F28 for ; Wed, 20 Dec 2017 03:56:52 +0000 (UTC) (envelope-from pfg@FreeBSD.org) Received: from sonic314-29.consmr.mail.bf2.yahoo.com (sonic314-29.consmr.mail.bf2.yahoo.com [74.6.132.203]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 793D77AC94 for ; Wed, 20 Dec 2017 03:56:52 +0000 (UTC) (envelope-from pfg@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1513742210; bh=9WBH47vNxhEII4c/3qzShS34UxWiIcDW6QlbDFuOds4=; h=Subject:To:Cc:References:From:Date:In-Reply-To:From:Subject; b=fAeMhWfE1e/EvSxELlYn/8K5xqk7fbUi10wYElJuN8Bs+VQ6+wkS+G7i21XnaDi+THFks0KTzQK8TJRhpjqmxkpS0WPqf0IkwH4jmeYTEWU0fhjU0E9JuUE9+FHLTrr6dxyVl7A1ro+0UulLH1hqxQNAQKw1L99yI2XTrbBOkBGEePmhcJvZ8Jij6I1JovoGWxseTP0HPEMOntKr8TczA/LukyCpYn1+PDh9xR1TIReZnXNM0D7ecDw1bGS4A0sidqYwUQ5JdTPMsw1TxvICrl9QFpTag3uA1dJhoV/mZfJo/12nCY8UwxNv5LqS7a4oXqNPmD1B3RBbJ+Fg/6KDEQ== X-YMail-OSG: 4RIqwxsVM1mMvB2.OH.PQ41h0JCn0nzpWEl0bkaSDlM5xU8Z6bmxSVd9Foeb53X f_cm3Geeoxd827jHLLx6u5bw2nupDbLzcjvyaO03lHBSUYWq8_LUxyr1wYDTVwtS0xzYwH2Pc771 DbJrb0.AiKKB3fk4iMLETqw0xBrPZTWQEK2jCGeebMc401uIlrtFKDDycIUSo6p70WCkvFVRJ__w pmIAGcmYcExVXImARkRXChydcV88f9qRvZavq2vHOrp8E1CBSRw4_IG6wTIHxqe4evuOz._iDgKq 6y1KMwy3WnMChd3s8ZwGoleeJLCPmh25v8CeCpHrYM65beBiOUa963Mp5so5rW1IO.JNv.t6QXSb kXVk4OjGbcJX6paf_FJ0P_EZ2YzSPaRgwpveP.XYKoF_t55YCpoe2m1kTC5Za0yOxx00gyuqrU0F 5sbQi6fxJ5z.Fa2wkD1GDpFnMUh3h2hZr36yQwLrBGntM8.PCThSVfNX.vc62lyVR5SJRjVAi Received: from sonic.gate.mail.ne1.yahoo.com by sonic314.consmr.mail.bf2.yahoo.com with HTTP; Wed, 20 Dec 2017 03:56:50 +0000 Received: from smtp103.rhel.mail.bf1.yahoo.com (EHLO [192.168.0.6]) ([98.139.230.213]) by smtp412.mail.bf1.yahoo.com (JAMES SMTP Server ) with ESMTPA ID 261d837199018cfff8d03688076b2df8; Wed, 20 Dec 2017 03:54:21 +0000 (UTC) Subject: Re: svn commit: r327005 - in head: sbin/ipfw sys/sys usr.sbin/watch To: rgrimes@freebsd.org Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org References: <201712200255.vBK2tWT0023724@pdx.rh.CN85.dnsmgr.net> From: Pedro Giffuni Organization: FreeBSD Project Message-ID: <6bfed45b-df20-adf8-fc8c-0ca543cb4340@FreeBSD.org> Date: Tue, 19 Dec 2017 22:54:19 -0500 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.5.0 MIME-Version: 1.0 In-Reply-To: <201712200255.vBK2tWT0023724@pdx.rh.CN85.dnsmgr.net> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-US X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.25 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 20 Dec 2017 03:56:52 -0000 On 19/12/2017 21:55, Rodney W. Grimes wrote: >> >>> On Dec 19, 2017, at 19:15, Rodney W. Grimes wrote: >>> >>>> Author: pfg >>>> Date: Tue Dec 19 22:40:16 2017 >>>> New Revision: 327005 >>>> URL: https://svnweb.freebsd.org/changeset/base/327005 >>>> >>>> Log: >>>> SPDX: These are fundamentally BSD-2-Clause. >>>> >>>> They just omit the introductory line and numbering. >>> I again must assert that it would be better to not apply an SPDX than to >>> apply one that is not an exact match for the license. >>> >>> >> Not being a lawyer, I would normally agree, however: > This isnt about any legal issue. Only legal issues matter. If there is even a hint of a legal basis to revert the change, I won't object. >> 1) SPDX IDs are only advisory: we always keep the exact license text, which is what has legal value. > And we should do our best to provide the most accurate advisory we can, > and we know that this is not a direct copy of the BSD 2 clause, so making > advice that it is, IMHO, would be poor advice. > >> 2) The license is detected by license scanners as BSD and it has two clauses so the description fits. > And a human reading it sees it reads like a 2 clause but does not match a 2 clause exactly so > how do I trust any of this SPDX stuff as being done with some ration of sanity. > >> FWIW, according to SPDX lawyers, the numbering is not relevant and it would appear to me that the phrase: >> "Redistribution and use in source and binary forms, with or without modification, are permitted provided that the following conditions are met:? doesn?t add any information to the two clauses, which read: > Again, not a legal issue, an issue of this is not an exact BSD-2-Clause so I > do not believe that we should tag it as such. Basically if we are doing this > "close enough" thing it means the SPDX tags are actually pretty useless for > anyone trying to do a legal evaluation cause they are just going have to > completly redo what was done in adding the SPDX tags, and if that is the > case we should seriously consider just what value do these have in the > tree? I see it the other way around: If the text matches exactly the common license text, then the tag is redundant (which is not necessarily wrong but doesn't imply much value). Yes, there is some amount of judgement being done on my part: it would certainly be wrong from to tag some file as BSD-2-Clause when it is an MIT license under the reasoning that they are "basically" the same thing but I think I am being sufficiently reasonable by setting the best possible match. As I said the SPDX guys do consider non-substantial differences are OK. What I will do .. just to be safe, is to check with the SPDX guys to see what they think. Thanks, Pedro. >> Redistributions of source code must ? >> Redistributions in binary form must ... >> >> Pedro. >> >> >> >>>> Modified: >>>> head/sbin/ipfw/altq.c >>>> head/sbin/ipfw/dummynet.c >>>> head/sbin/ipfw/ipfw2.c >>>> head/sbin/ipfw/ipfw2.h >>>> head/sbin/ipfw/ipv6.c >>>> head/sbin/ipfw/main.c >>>> head/sbin/ipfw/nat.c >>>> head/sys/sys/msg.h >>>> head/sys/sys/snoop.h >>>> head/usr.sbin/watch/watch.c >>> ... >>> >>> -- >>> Rod Grimes rgrimes@freebsd.org