From owner-svn-src-all@freebsd.org Thu Feb 7 10:54:46 2019 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id CB5D514D45CF; Thu, 7 Feb 2019 10:54:45 +0000 (UTC) (envelope-from v.maffione@gmail.com) Received: from mail-qt1-x82d.google.com (mail-qt1-x82d.google.com [IPv6:2607:f8b0:4864:20::82d]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 68E948344A; Thu, 7 Feb 2019 10:54:45 +0000 (UTC) (envelope-from v.maffione@gmail.com) Received: by mail-qt1-x82d.google.com with SMTP id 2so11374359qtb.5; Thu, 07 Feb 2019 02:54:45 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=g3eyAm6PmZjFjJWFseFsfL+5wz92zr5K61TtkPzCWA4=; b=HFFEj6PyPIH8zn2pSNe/063x4k1GkETTUK5vSZBQCbIUwx1psvgFsc/DGsyQGSXgv1 J0AA7qjDVh+H0D8iVfYaA+UXfgwtnivl0Cb4Pn5UNLVEJckU8hgIe0TlZKThpafslSmQ NX7+e3QhFj0Qu7hv/XM2UQaC/Kgd0scfx7MhrSFrLxPo5u9ByItF8tEpH3Li/l99lC3Y x9GeDe9KvEp350+4Iau3YPEVFjjowa+wb+6gWjk6iLM6pM/BjXQpyzgbRVbUKjS+r+xU RJJLJotDXfXPRJzDbd5S9+9wssjSKe56YDXp3MwjmUJCrb9Mu2K2YBw8G4NaH0x/vgT4 dOTA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=g3eyAm6PmZjFjJWFseFsfL+5wz92zr5K61TtkPzCWA4=; b=PvBjThulY82ZctvSGmpC2blWhRvjCeiv8MUGP1tEeV8YoXCIBmGGeGPf4R1pe3U6nS neZagrF6lk/vVg7INVbsd+aWDqL70fkb/9YgHcga5f2U8poTQeHWEcT6VqAxePS7NU8u ZPg3knJmQAWZEvcPccAWysuAPj8KGj0qn6DLDr308LM7mRQCA516lwubKcvWzLLIEROk yFwwsgWqL8m6zAzT1qTiEDDzjN7RPt0RcSk7RVdqz1ZO5FuzirZYHD4EBWjXuJNumYTU OvCdMI+52XofKGLwl2Ra+CAasgXERGFUSRqKnwgGJ4Ppr7EQNFE/sTbn+IyD/XU0P12q iRHw== X-Gm-Message-State: AHQUAuZR/8GA6eXMulep8xhXhc+3ClL0pBiBmCPVYx6UJfT3RlnIllJB K6H5l6u4RHCOTdIcCBh14Kjw1hTERHfwEQ/AAEEBTA== X-Google-Smtp-Source: AHgI3IaeCyd3soXkHPjPRZaOauYlZY/gOLRHzFE+1leYcJLRHhU0HmItnePpnXtmcP65waRDQ84KlRPPpCzKdGam/Dg= X-Received: by 2002:aed:34e6:: with SMTP id x93mr11633939qtd.156.1549536884550; Thu, 07 Feb 2019 02:54:44 -0800 (PST) MIME-Version: 1.0 References: <201902051210.x15CAnPq052340@repo.freebsd.org> <20190207104515.GA92760@alchemy.franken.de> In-Reply-To: <20190207104515.GA92760@alchemy.franken.de> From: Vincenzo Maffione Date: Thu, 7 Feb 2019 11:54:32 +0100 Message-ID: Subject: Re: svn commit: r343772 - head/sys/dev/netmap To: Marius Strobl Cc: src-committers , svn-src-all@freebsd.org, svn-src-head@freebsd.org X-Rspamd-Queue-Id: 68E948344A X-Spamd-Bar: ------ Authentication-Results: mx1.freebsd.org X-Spamd-Result: default: False [-6.90 / 15.00]; NEURAL_HAM_MEDIUM(-1.00)[-1.000,0]; NEURAL_HAM_SHORT(-0.90)[-0.898,0]; REPLY(-4.00)[]; TAGGED_FROM(0.00)[]; NEURAL_HAM_LONG(-1.00)[-1.000,0] Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.29 X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 07 Feb 2019 10:54:46 -0000 Il giorno gio 7 feb 2019 alle ore 11:45 Marius Strobl ha scritto: > On Tue, Feb 05, 2019 at 12:10:49PM +0000, Vincenzo Maffione wrote: > > Author: vmaffione > > Date: Tue Feb 5 12:10:48 2019 > > New Revision: 343772 > > URL: https://svnweb.freebsd.org/changeset/base/343772 > > > > Log: > > netmap: refactor logging macros and pipes > > > > Changelist: > > - Replace ND, D and RD macros with nm_prdis, nm_prinf, nm_prerr > > and nm_prlim, to avoid possible naming conflicts. > > - Add netmap_krings_mode_commit() helper function and use that > > to reduce code duplication. > > - Refactor pipes control code to export some functions that > > can be reused by the veth driver (on Linux) and epair(4). > > - Add check to reject API requests with version less than 11. > > - Small code refactoring for the null adapter. > > Hello Vincenzo, > > this change causes interface attachment output to look somewhat > deformed ("000.000395 [3717] netmap_attach_ext" debug info and > an extra newline): > em0: port 0xe000-0xe01f mem > 0xf7d00000-0xf7d1ffff,0xf7d20000-0xf7d23fff irq 17 at device 0.0 on pci3 > em0: Using 1024 TX descriptors and 1024 RX descriptors > em0: Using 2 RX queues 2 TX queues > em0: Using MSI-X interrupts with 3 vectors > em0: Ethernet address: 60:a4:4c:24:0b:4c > 000.000395 [3717] netmap_attach_ext em0: netmap queues/slots: TX > 2/1024, RX 2/1024 > > pcib5: irq 19 at device 28.7 on pci0 > > Could we please get this part back to match the pre-r343772 > output again? > The additional newline slipped through, sorry for that. I was trying to make logging macros uniform across netmap, that's why I did that change (that's the only place in netmap where if_printf() is used). But I understand this is inconvenient for users, so I will revert this specific log line. Cheers, Vincenzo > > Marius > > -- Vincenzo