From owner-freebsd-wireless@FreeBSD.ORG Sat Jun 21 19:47:38 2014 Return-Path: Delivered-To: freebsd-wireless@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 04ACF84D; Sat, 21 Jun 2014 19:47:38 +0000 (UTC) Received: from mail-qg0-x22e.google.com (mail-qg0-x22e.google.com [IPv6:2607:f8b0:400d:c04::22e]) (using TLSv1 with cipher ECDHE-RSA-RC4-SHA (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id ABA582DCA; Sat, 21 Jun 2014 19:47:37 +0000 (UTC) Received: by mail-qg0-f46.google.com with SMTP id q107so4524996qgd.5 for ; Sat, 21 Jun 2014 12:47:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:sender:in-reply-to:references:date:message-id:subject :from:to:cc:content-type; bh=HPQkUP7KpEh1p5PRsqZGmBsJDo22qlH4P4WlywsKolc=; b=q7E1WJNTXt0PMy2Fx87ahk3bN7a1je1RC5jWIE2FyXrh6XaF7p5HwiYxy0d/0hOPTO OP/TPos4GVf3s8l97s6hzVc5LF7XdZsPy0NUCwkTROXm2MG3SilmPJfnO+kYQyLdZTRs falux7AKMCN6KENHASBnmp/SGuZsbH/qq7ASteLVbaWPfieSzFeqlVP1lIhppPA0ny3o gq3v70G3HBxxJII0k4dNdRKpwSjhWF55f/aXkt0T5PCdJOYOPZGx7OUoewS64P/UPpGV IjLwI9SrI00aRMfc4nuwqTCjSzBXDnDxK+q0XKKsj516x6hHSJWP7gYBuxwtr4nMC+++ pY9Q== MIME-Version: 1.0 X-Received: by 10.140.35.212 with SMTP id n78mr16356606qgn.87.1403380056836; Sat, 21 Jun 2014 12:47:36 -0700 (PDT) Sender: adrian.chadd@gmail.com Received: by 10.224.43.134 with HTTP; Sat, 21 Jun 2014 12:47:36 -0700 (PDT) In-Reply-To: <1403366123.39384.10.camel@bruno> References: <1403366123.39384.10.camel@bruno> Date: Sat, 21 Jun 2014 12:47:36 -0700 X-Google-Sender-Auth: r763KbE8TbTHelf03p-oCNbaOuw Message-ID: Subject: Re: wireless mcast updates, ic->ic_update_mcast From: Adrian Chadd To: Sean Bruno Content-Type: text/plain; charset=UTF-8 Cc: "freebsd-wireless@freebsd.org" X-BeenThere: freebsd-wireless@freebsd.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: "Discussions of 802.11 stack, tools device driver development." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 21 Jun 2014 19:47:38 -0000 Well, it depends on what the hardware may want or desire to function correctly. I've no idea what theose chips require for multicast behaviour. -a On 21 June 2014 08:55, Sean Bruno wrote: > My T61 has a wpi(4) card in it. I noted that the console message "needs > muticast update" is emitted as it doesn't implement the required > function in its code and uses the default of the net80211 stack. I > haven't noted any issues, but I took a journey through some of the > wireless drivers to see what the status of implementation was. It seems > most of the drivers stub out the required function to get rid of the > warning. > > I perceive that with 6 exceptions, most of our wireless adapters don't > have an implementation, or worse, they implement a stub to squash the > warning. Shouldn't these stub functions be removed? Perhaps wrapp the > net80211 default behavior in bootverbose? > > -- implemented ic_update_mcast() > ath/if_ath.c -- implemented and working > usb/wlan/if_zyd.c -- implemented and working > usb/wlan/if_wi.c -- implemented and working > > -- sets a flag to default o/s behvavior? > mwl/if_mlw.c -- function coded out, most code if 0'd out > usb/wlan/if_upgt.c -- looks to default to whatever the o/s can do. > usr/wlan/if_run.c -- looks to default to whatever the o/s can do > > -- stubbed out function to squash warning (bug?) > iwn/if_iwn.c -- stubbed out in if_iwn to remove default error > usb/wlan/if_rum.c -- stubbed out to remove default error > usb/wlan/if_urtwn.c -- stubbed out to remove default error > usb/wlan/if_urtw.c -- stubbed out to remove default error > usr/wlan/if_uath.c -- stubbed out to remove default error > usb/wlan/if_rsu.c -- stubbed out to remove default error > wtap/if_wtap.c -- stubbed out to remove default error > > -- undefined, emits error correctly > wpi/if_wpi.c > bwi/if_bwi.c > bwn/if_bwn.c > ipw/if_ipw.c > malo/if_malo.c > ral/rt2560.c > ral/rt2860.c > ral/rt2661.c > wi/if_wi.c > usb/wlan/if_ural.c > > _______________________________________________ > freebsd-wireless@freebsd.org mailing list > http://lists.freebsd.org/mailman/listinfo/freebsd-wireless > To unsubscribe, send any mail to "freebsd-wireless-unsubscribe@freebsd.org"