From owner-svn-src-all@freebsd.org Thu Jul 19 20:48:18 2018 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 4C2AC104A4AB; Thu, 19 Jul 2018 20:48:18 +0000 (UTC) (envelope-from manu@bidouilliste.com) Received: from mail.blih.net (mail.blih.net [212.83.177.182]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "mail.blih.net", Issuer "mail.blih.net" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 52E4D7B6B7; Thu, 19 Jul 2018 20:48:17 +0000 (UTC) (envelope-from manu@bidouilliste.com) Received: from mail.blih.net (mail.blih.net [212.83.177.182]) by mail.blih.net (OpenSMTPD) with ESMTP id b250e4f3; Thu, 19 Jul 2018 22:48:09 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=bidouilliste.com; h=date :from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-type:content-transfer-encoding; s=mail; bh=BLMt4JohtHJvRmTzG3PCwDsiP88=; b=D7RdL8EQoPXcEWmos9GeLzS6AapN OeT0hYeqxdlv9Y84pkRU/DqTxB4hZU+rEJpuNrgUhtCikt4YCyCdZGVsgC15XSzq dJMO7yg0sFfM39OvLC+hgzG0TxgQZObn2PFtOD9kMk4x0RAUq2+P3OEnLApe7qP6 4/lcD4EwKKvXByE= DomainKey-Signature: a=rsa-sha1; c=nofws; d=bidouilliste.com; h=date :from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-type:content-transfer-encoding; q=dns; s= mail; b=dRES1Iwl4HXxqkYSr92wnmsCeqEZBerQ81nCMz7y0hTm4igxEX4MtfNS 00Db8NOjD2/uVLLUuTb6xnJWdQNHnaLWvS/+48LS2CEpxG7jt+IiqCv/NMXo3yjM 8ojNMU3Os7+vRvLjkcexl7MlIkbY7bb4dw/TwiATQGljgGvwbQ0= Received: from skull.home.blih.net (ip-9.net-89-3-105.rev.numericable.fr [89.3.105.9]) by mail.blih.net (OpenSMTPD) with ESMTPSA id 0e7bea69 TLS version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NO; Thu, 19 Jul 2018 22:48:08 +0200 (CEST) Date: Thu, 19 Jul 2018 22:48:08 +0200 From: Emmanuel Vadot To: Kyle Evans Cc: Nathan Whitehorn , Justin Hibbits , src-committers , svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r336514 - head/sys/dev/vt/hw/ofwfb Message-Id: <20180719224808.36eb9909375a1db67ac42fed@bidouilliste.com> In-Reply-To: References: <201807192022.w6JKMkE6044331@repo.freebsd.org> <72e23592-9ff2-b373-f8cc-755c358989f5@freebsd.org> X-Mailer: Sylpheed 3.7.0 (GTK+ 2.24.32; amd64-portbld-freebsd12.0) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.27 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 19 Jul 2018 20:48:18 -0000 On Thu, 19 Jul 2018 15:38:49 -0500 Kyle Evans wrote: > Seems like some bad decisions have been made with regards to naming... > e.g. https://lkml.org/lkml/2018/6/25/784 See this thread too : http://lists.infradead.org/pipermail/linux-arm-kernel/2018-June/584613.html They did bad things. It seems that the IMX linux guys don't really know what they are talking about. stdout-path is supposed to contain a string. > On Thu, Jul 19, 2018 at 3:26 PM, Nathan Whitehorn > wrote: > > Isn't stdout-path supposed to contain a string rather than an ihandle? This > > code assumes it is an ihandle (or xref phandle), which I think is wrong. > > -Nathan > > > > > > On 07/19/18 13:22, Justin Hibbits wrote: > >> > >> Author: jhibbits > >> Date: Thu Jul 19 20:22:46 2018 > >> New Revision: 336514 > >> URL: https://svnweb.freebsd.org/changeset/base/336514 > >> > >> Log: > >> ofwfb: Check for /chosen/stdout-path in addition to /chosen/stdout > >> Some platforms use /chosen/stdout-path as the property containing > >> the path to > >> the stdout node, not /chosen/stdout. > >> > >> Modified: > >> head/sys/dev/vt/hw/ofwfb/ofwfb.c > >> > >> Modified: head/sys/dev/vt/hw/ofwfb/ofwfb.c > >> > >> ============================================================================== > >> --- head/sys/dev/vt/hw/ofwfb/ofwfb.c Thu Jul 19 20:20:43 2018 > >> (r336513) > >> +++ head/sys/dev/vt/hw/ofwfb/ofwfb.c Thu Jul 19 20:22:46 2018 > >> (r336514) > >> @@ -102,6 +102,10 @@ ofwfb_probe(struct vt_device *vd) > >> if (OF_getprop(chosen, "stdout", &stdout, sizeof(stdout)) == > >> sizeof(stdout)) > >> node = OF_instance_to_package(stdout); > >> + if (node == -1) > >> + if (OF_getprop(chosen, "stdout-path", &stdout, sizeof(stdout)) > >> == > >> + sizeof(stdout)) > >> + node = OF_instance_to_package(stdout); > >> if (node == -1) { > >> /* > >> * The "/chosen/stdout" does not exist try > >> > > > > -- Emmanuel Vadot