From owner-svn-src-all@freebsd.org Fri Nov 27 14:32:42 2020 Return-Path: Delivered-To: svn-src-all@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 19B2B4A8CB3; Fri, 27 Nov 2020 14:32:42 +0000 (UTC) (envelope-from asomers@gmail.com) Received: from mail-ot1-f51.google.com (mail-ot1-f51.google.com [209.85.210.51]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4CjHCY70Tlz3Msj; Fri, 27 Nov 2020 14:32:41 +0000 (UTC) (envelope-from asomers@gmail.com) Received: by mail-ot1-f51.google.com with SMTP id n12so4883103otk.0; Fri, 27 Nov 2020 06:32:41 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=9GhjiNJE36sOIxpjvwo9YyXBktg/tHu2zlm17cCNIKc=; b=sGZK2IRzLmDxu1Z3MiZdVofhIEq7ilKmbec0L41WTF2OOp4aQBK9aSdPOUJrnH14Ai gMATD0B5hC9WcAvIczNlPnZI2mp5MeTFyz+iWG7OcRRqUkftDpO/3mCunP7eBgV77ACM JJc7jfZBocmaihoXe/+ZpaSpKgLFCkJu27Wf2N7qVdyKFhELYFIMbbKyTYJ3G8YRLIbB r/gG7W6f10Mbn2DRz1OPYiAbMj8kCeIN45XrqfBF9L21J40mnFyuBpCYIYFabg4JK0fX G1pXMywDT/vc0Rl0ahVTRILvPYl3hxQkKNlDXV/H8mJrFUejod0veLJoXaUVeQ9vWw7m yAtw== X-Gm-Message-State: AOAM533x2BUZbrk3iAoGp6S7hv1PrTRYl05qck1xIfgcQpMDC86wTH08 yC4cc9ZQqmhYgUTqxCv+v2Nmcoe9KyOrITK4FBNTl0sADWc= X-Google-Smtp-Source: ABdhPJxJvHhqX6sMNTu/04lpZLAQHxwTtHgMUH2MBRn70n4guY/dJUENotbsZYZ5WdnhqEvRhYik4S07FRgoLjsowl0= X-Received: by 2002:a9d:3e1b:: with SMTP id a27mr6296572otd.291.1606487559950; Fri, 27 Nov 2020 06:32:39 -0800 (PST) MIME-Version: 1.0 References: <202011260429.0AQ4TV2B023801@repo.freebsd.org> <1E846E83-998A-4ACC-9491-D0411899C1A7@lists.zabbadoz.net> In-Reply-To: <1E846E83-998A-4ACC-9491-D0411899C1A7@lists.zabbadoz.net> From: Alan Somers Date: Fri, 27 Nov 2020 07:32:28 -0700 Message-ID: Subject: Re: svn commit: r368045 - in head: . etc/mtree rescue/rescue sbin sbin/ping sbin/ping/tests sbin/ping6 sbin/ping6/tests tools/build/mk To: "Bjoern A. Zeeb" Cc: src-committers , svn-src-all , svn-src-head X-Rspamd-Queue-Id: 4CjHCY70Tlz3Msj X-Spamd-Bar: ---- Authentication-Results: mx1.freebsd.org; none X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[] Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Content-Filtered-By: Mailman/MimeDel 2.1.34 X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 27 Nov 2020 14:32:42 -0000 On Fri, Nov 27, 2020 at 5:08 AM Bjoern A. Zeeb < bzeeb-lists@lists.zabbadoz.net> wrote: > On 26 Nov 2020, at 18:51, Alan Somers wrote: > > > On Thu, Nov 26, 2020 at 2:16 AM Bjoern A. Zeeb < > > bzeeb-lists@lists.zabbadoz.net> wrote: > > > >> On 26 Nov 2020, at 4:29, Alan Somers wrote: > >> > >>> Author: asomers > >>> Date: Thu Nov 26 04:29:30 2020 > >>> New Revision: 368045 > >>> URL: https://svnweb.freebsd.org/changeset/base/368045 > >>> > >>> Log: > >>> Merge ping6 to ping > >>> > >>> There is now a single ping binary, which chooses to use ICMP or > >>> ICMPv4 > >>> based on the -4 and -6 options, and the format of the address. > >>> > >>> Submitted by: J=C3=A1n Su=C4=8Dan > >>> Sponsored by: Google LLC (Google Summer of Code 2019) > >>> MFC after: Never > >>> Differential Revision: https://reviews.freebsd.org/D21377 > >> > >> I don=E2=80=99t have IPv4 anymore. > >> I don=E2=80=99t see any WITHOUT_INET or -DINET checks. > >> How can I compile INET out now? > >> > > > > I don't see any such checks before, either. Was it ever possible to > > exclude ping by building WITHOUT_INET? > > No, for various reasons including startup scripts relying on it etc. > I think no one ever bothered to fully find it all. > > But it was possible to just ditch the binary (not installing it into > custom images, or rm -f it post-install along with other things). > > > Now it=E2=80=99s a =E2=80=9Cdual-stack handling=E2=80=9D binary and those= we=E2=80=99ve tried > with a lot of care to make sure they grow compiling out both ways as you > cannot throw away the binary anymore. > > I don=E2=80=99t know how hard it is to do this now. I=E2=80=99ll be happ= y to have a > look and help if it=E2=80=99s not a 5 minute job for you knowing the code= and > split up. Would we just have to handle main.c with #ifdefs and the old > ping[4] files from the Makefile or is ping6 also using shared code from > the former ping[4]? > > > /bz > Yes, that's about right. ping.c is the old ping.c, and ping6.c is the old ping6.c, with main() removed from both. So it should be pretty easy to compile out INET. -Alan